Page MenuHomePhabricator
Create Task
Maniphest T293167

Disable insert-link button when title is empty
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
Samwilson
Authored By
Samwilson
Oct 13 2021, 2:29 AM
Tags
Referenced Files
F34892080: Screen Shot 2021-12-21 at 3.44.30 PM.png
Dec 21 2021, 10:13 PM
F34892077: Screen Shot 2021-12-21 at 3.43.23 PM.png
Dec 21 2021, 10:13 PM
F34870303: insert_link_menu_item.png
Dec 9 2021, 5:20 PM
F34870666: insert_link_disabled.png
Dec 9 2021, 5:20 PM
F34868452: empty_link_alert.png
Dec 9 2021, 11:58 AM
F34853636: insert_link_disabled_step2.png
Dec 7 2021, 9:53 AM
F34853634: insert_link_disabled_step1.png
Dec 7 2021, 9:53 AM
Subscribers
Aklapper
dom_walden
• imaigwilo
• NRodriguez
Samwilson

Description

The 'Insert link' button is disabled when an invalid page name is entered, but is enabled when the title input is empty (e.g. when the dialog is first opened). It does show an alert when trying to insert an empty title, but it'd be nicer to just now allow the button to be pressed (and so get rid of the alert altogether).

Details

SubjectRepoBranchLines +/-
Fix link-inserter event value when dialog opensmediawiki/extensions/WikiEditormaster+1 -1
Disable link-insert button if target is emptymediawiki/extensions/WikiEditormaster+21 -16
Customize query in gerrit

Related Objects

Event Timeline

Samwilson created this task.Oct 13 2021, 2:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 2:29 AM
Samwilson mentioned this in T289214: Disambiguation Pages: Visually differentiate disambiguation links on Wikitext Editor link selector.Oct 13 2021, 11:24 PM
ldelench_wmf added a project: Community-Tech.Nov 9 2021, 11:46 PM
ldelench_wmf moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Nov 22 2021, 4:49 PM
KSiebert set the point value for this task to 1.Nov 23 2021, 9:09 AM
KSiebert moved this task from Needs Discussion to Up Next (May 20-June 3) on the Community-Tech board.
Samwilson claimed this task.Nov 26 2021, 1:37 AM
Samwilson moved this task from Up Next (May 20-June 3) to CommTech-Sprint-14 on the Community-Tech board.
Samwilson edited projects, added Community-Tech (CommTech-Sprint-14); removed Community-Tech.
Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-14) board.
gerritbot added a comment.Nov 26 2021, 3:11 AM

Change 741996 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Disable link-insert button if target is empty

https://gerrit.wikimedia.org/r/741996

gerritbot added a project: Patch-For-Review.Nov 26 2021, 3:11 AM
Samwilson changed the task status from Open to In Progress.Nov 27 2021, 12:47 AM
Samwilson moved this task from In Development 💻 to QA 🐛 on the Community-Tech (CommTech-Sprint-14) board.Nov 29 2021, 9:52 PM
gerritbot added a comment.Nov 29 2021, 10:17 PM

Change 741996 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Disable link-insert button if target is empty

https://gerrit.wikimedia.org/r/741996

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 29 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 29 2021, 11:10 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-15); removed Community-Tech (CommTech-Sprint-14).Dec 3 2021, 7:49 PM
ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-15) board.Dec 3 2021, 7:53 PM
dom_walden subscribed.Dec 7 2021, 9:53 AM

@Samwilson If I close the Insert link dialog with some valid input, when I re-open it the insert-link button is disabled (even if the input is valid).

This does not happen in the parent commit (7fbd917c152ada0852a166ed97541472b874a963).

Open dialog first time, enter some valid input:

insert_link_disabled_step1.png (349×534 px, 24 KB)

Close the dialog (pressing cancel or x) and re-open it:

insert_link_disabled_step2.png (352×527 px, 22 KB)

Samwilson moved this task from QA 🐛 to In Development 💻 on the Community-Tech (CommTech-Sprint-15) board.Dec 8 2021, 1:26 AM

Thanks for finding that Dom! I'll fix it up now.

gerritbot added a comment.Dec 8 2021, 2:04 AM

Change 744902 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Fix link-inserter event value when dialog opens

https://gerrit.wikimedia.org/r/744902

gerritbot added a project: Patch-For-Review.Dec 8 2021, 2:04 AM
Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-15) board.Dec 8 2021, 3:19 AM
gerritbot added a comment.Dec 8 2021, 10:33 PM

Change 744902 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Fix link-inserter event value when dialog opens

https://gerrit.wikimedia.org/r/744902

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.13; 2021-12-13); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 8 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 8 2021, 11:10 PM
MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-15) board.Dec 8 2021, 11:19 PM
dom_walden added a subscriber: • NRodriguez.Dec 9 2021, 11:58 AM

I am a bit confused by the description in this task. Are we supposed to be seeing the alert when the link is empty?

This happens when I press enter (because the button is disabled):

empty_link_alert.png (468×1 px, 49 KB)

@Samwilson? @NRodriguez?

dom_walden added a comment.Dec 9 2021, 5:20 PM

Notes for QA:

  1. Using the source editor, start editing any page on beta (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:Random)
  2. Open the "Insert link" dialog
    insert_link_menu_item.png (305×1 px, 44 KB)

The button that says "Insert link" should be disabled.

insert_link_disabled.png (323×523 px, 17 KB)

I am not sure what should happen if you press the enter key.

Please also read: Things to consider when testing

• imaigwilo subscribed.EditedDec 21 2021, 10:13 PM

Insert button is disabled when title is blank. When user clicks on the disabled insert button nothing happens, the title field is highlighted in red.

Screen Shot 2021-12-21 at 3.43.23 PM.png (1×2 px, 320 KB)

I also confirmed that when user enters text, the insert button is enabled and insert link is enabled.
Screen Shot 2021-12-21 at 3.44.30 PM.png (1×2 px, 321 KB)

• imaigwilo moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Sprint-15) board.Dec 21 2021, 10:21 PM
ldelench_wmf closed this task as Resolved.Dec 22 2021, 12:07 PM
happy5214 moved this task from Backlog to Closed on the WikiEditor board.Feb 7 2022, 7:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL