Page MenuHomePhabricator
Create Task
Maniphest T293168

External links should never be invalid
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

  1. Open the insert-link dialog.
  2. Enter https://example.org/?a=b|c as the 'Target page or URL'.
  3. Note that it displays an 'invalid title' message.
  4. Select the 'To an external web page' radio button.
  5. The invalid message should disappear, and the insert button be enabled, but neither happens and it's not possible to insert the link.

It works correctly if the external radio button is selected before the title is entered, and also if the dialog is closed and then opened again.

Details

SubjectRepoBranchLines +/-
Move insert-link mode constants to a better locationmediawiki/extensions/WikiEditormaster+18 -17
Prevent external links from showing as invalidmediawiki/extensions/WikiEditormaster+47 -8
Customize query in gerrit

Related Objects

Event Timeline

Samwilson created this task.Oct 13 2021, 2:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 2:37 AM
Samwilson mentioned this in T289214: Disambiguation Pages: Visually differentiate disambiguation links on Wikitext Editor link selector.Oct 13 2021, 11:24 PM
ldelench_wmf added a project: Community-Tech.Nov 9 2021, 11:45 PM
• NRodriguez subscribed.Nov 15 2021, 10:56 PM

thanks for writing ticket! I agree that it should work as specified and not how it is currently behaving.
question: is this broken functionality something that our changes introduced?

Samwilson added a comment.Nov 17 2021, 1:38 AM

Yep, previously an external link with a pipe in it worked fine.

ldelench_wmf moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Nov 22 2021, 4:47 PM
KSiebert set the point value for this task to 2.Nov 23 2021, 9:15 AM
KSiebert moved this task from Needs Discussion to Up Next (May 20-June 3) on the Community-Tech board.
Samwilson changed the task status from Open to In Progress.Nov 27 2021, 12:46 AM
Samwilson claimed this task.
Samwilson edited projects, added Community-Tech (CommTech-Sprint-14); removed Community-Tech.
Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-14) board.
gerritbot added a comment.Nov 30 2021, 3:22 AM

Change 742586 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Prevent external links from showing as invalid

https://gerrit.wikimedia.org/r/742586

gerritbot added a project: Patch-For-Review.Nov 30 2021, 3:22 AM
Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-14) board.Nov 30 2021, 10:51 AM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-15); removed Community-Tech (CommTech-Sprint-14).Dec 3 2021, 7:49 PM
ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-15) board.Dec 3 2021, 7:52 PM
gerritbot added a comment.Dec 7 2021, 6:14 AM

Change 742586 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Prevent external links from showing as invalid

https://gerrit.wikimedia.org/r/742586

MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-15) board.Dec 7 2021, 6:15 AM
gerritbot added a comment.Dec 7 2021, 6:53 AM

Change 744709 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Move insert-link mode constants to a better location

https://gerrit.wikimedia.org/r/744709

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 7 2021, 8:00 AM
dom_walden moved this task from QA 🐛 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-15) board.EditedDec 8 2021, 4:04 PM
dom_walden subscribed.

I can no longer reproduce the bug in the description.

There is one unmerged change here so I am going to move into Review so it is not missed.

Notes for QA: I think the unmerged changes look unlikely to cause any problems. I don't think this needs to be put back into QA. Can go straight to Product sign-off or Done after the code has been reviewed and merged.

gerritbot added a comment.Dec 9 2021, 8:13 PM

Change 744709 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Move insert-link mode constants to a better location

https://gerrit.wikimedia.org/r/744709

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2021, 9:10 PM
MusikAnimal moved this task from Review/Feedback 💬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-15) board.Dec 9 2021, 10:55 PM
• NRodriguez closed this task as Resolved.Dec 16 2021, 4:39 PM

I can no longer reproduce the bug in the description. + 1

ldelench_wmf moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-15) board.Dec 20 2021, 3:04 PM
happy5214 moved this task from Backlog to Closed on the WikiEditor board.Feb 7 2022, 7:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL