Log when a user copies an IP address
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	phuedx
	Nov 25 2021, 11:09 AM

Description

Background

As in T279540: Instrument IP address copy action metric, we'd like to understand how many users are copying IP addresses.

AC

When I copy an IP address, an event should be logged
- The event_action property should be "copy"
- The event_context property should be "ip_address"
- The event_source property should be the action/page that I'm on, i.e. one of "action_history", "special_log", "special_recentchanges"
The ipAddressCopyAction instrument created in T279540: Instrument IP address copy action metric is disabled and removed

Notes

In order to disable the ipAddressCopyAction instrument, the wgWMEIPAddressCopyActionEnabled stanza in the production config will have to be removed
See the current.yaml files in the subdirectories in https://gerrit.wikimedia.org/r/plugins/gitiles/schemas/event/secondary/+/refs/heads/master/jsonschema/analytics/mediawiki for numerous examples of JSON Schema schemas that are used in production
wt:Event Platform/Instrumentation How To is a step-by-step guide to creating a creating a schema and validating an event with it
https://www.mediawiki.org/wiki/MediaWiki-Docker/Configuration_recipes/EventLogging is a step-by-step guide to setting up your local development environment

Details

Subject	Repo	Branch	Lines +/-
Remove IP address copy action instrument	mediawiki/extensions/WikimediaEvents	master	+1 -146
Remove wgWMEIPAddressCopyActionEnabled from Beta and production config	operations/mediawiki-config	master	+0 -11
Log when a user copies an IP address	mediawiki/extensions/IPInfo	master	+30 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T292803 IP Info: Explore Instrumentation
Resolved	Tchanders	T296469 Log when a user copies an IP address
Resolved	• AGueyte	T296415 Basic ipinfo instrument setup and first events

Event Timeline

phuedx created this task.Nov 25 2021, 11:09 AM

phuedx added a subtask: T296415: Basic ipinfo instrument setup and first events.

phuedx updated the task description. (Show Details)Nov 25 2021, 12:33 PM

phuedx updated the task description. (Show Details)Nov 25 2021, 12:38 PM

phuedx moved this task from Untriaged to Analytics on the Anti-Harassment board.Nov 25 2021, 2:55 PM

phuedx moved this task from Analytics to Pre-estimation/Triage on the Anti-Harassment board.Nov 25 2021, 3:02 PM

ARamirez_WMF renamed this task from Log when a user copies an IP address to Log when a user copies an IP address [S].Nov 30 2021, 5:38 PM

ARamirez_WMF moved this task from Pre-estimation/Triage to Cards ready for development on the Anti-Harassment board.

phuedx updated the task description. (Show Details)Dec 1 2021, 6:05 AM

Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.Jan 12 2022, 3:51 AM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Blocked/Stalled 🚧 on the Anti-Harassment (The Letter Song) board.Jan 12 2022, 3:53 AM

ARamirez_WMF moved this task from The Letter Song to Blocked/Stalled on the Anti-Harassment board.Feb 8 2022, 4:43 PM

ARamirez_WMF edited projects, added Anti-Harassment; removed Anti-Harassment (The Letter Song).

ARamirez_WMF renamed this task from Log when a user copies an IP address [S] to Log when a user copies an IP address.Feb 15 2022, 6:49 PM

ARamirez_WMF set the point value for this task to 2.

Tchanders moved this task from Blocked/Stalled to Cards ready for development on the Anti-Harassment board.Mar 21 2022, 4:53 PM

ARamirez_WMF moved this task from Cards ready for development to AHaT Sprint 4: The Stetson on the Anti-Harassment board.Mar 22 2022, 3:51 PM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 4: The Stetson); removed Anti-Harassment.

Tchanders claimed this task.Mar 24 2022, 4:16 PM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 4: The Stetson) board.

The ipAddressCopyAction instrument created in T279540: Instrument IP address copy action metric is disabled and removed

@Niharika @phuedx Presumably this means removed from WikimediaEvents, i.e. removal of everything added in T279540? Or does it just mean setting $wgWMEIPAddressCopyActionEnabled to false/removing it?

Change 774892 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/WikimediaEvents@master] Remove IP address copy action instrument

https://gerrit.wikimedia.org/r/774892

gerritbot added a project: Patch-For-Review.Mar 29 2022, 1:53 PM

Change 774902 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] Log when a user copies an IP address

https://gerrit.wikimedia.org/r/774902

Change 774904 had a related patch set uploaded (by Tchanders; author: Tchanders):

[operations/mediawiki-config@master] Remove wgWMEIPAddressCopyActionEnabled from Beta and production config

https://gerrit.wikimedia.org/r/774904

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 4: The Stetson) board.Mar 29 2022, 3:17 PM

Change 774902 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Log when a user copies an IP address

https://gerrit.wikimedia.org/r/774902

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Apr 1 2022, 8:00 AM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 4: The Stetson) board.Apr 1 2022, 9:29 AM

There are 3 patches with this: a change to IPInfo, and two patches removing the old way of logging copying IPs. Moving this to QA because the IPInfo change is ready to test.

Change 774904 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove wgWMEIPAddressCopyActionEnabled from Beta and production config

https://gerrit.wikimedia.org/r/774904

Mentioned in SAL (#wikimedia-operations) [2022-04-04T20:29:30Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 8c81de9c732adef4537226ec6a7023fef40f3396: Remove wgWMEIPAddressCopyActionEnabled from Beta and production config (T296469) (duration: 00m 51s)

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 5: The Bearskin); removed Anti-Harassment (AHaT Sprint 4: The Stetson).Apr 5 2022, 4:12 AM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 5: The Bearskin) board.Apr 5 2022, 4:19 AM

https://en.wikipedia.beta.wmflabs.org/wiki/Special:Log?type=ipinfo&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers

Screen Shot 2022-04-07 at 4.53.08 PM.png (1×2 px, 678 KB)

https://en.wikipedia.beta.wmflabs.org/wiki/0.29309421560561466?action=history

Screen Shot 2022-04-07 at 5.01.04 PM.png (1×2 px, 641 KB)

https://en.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/81.187.41.249

Screen Shot 2022-04-07 at 5.03.10 PM.png (1×2 px, 543 KB)

Niharika closed subtask T296415: Basic ipinfo instrument setup and first events as Resolved.Apr 8 2022, 10:41 PM

• imaigwilo moved this task from QA/Testing 🐞 to Done Q3 2022 on the Anti-Harassment (AHaT Sprint 5: The Bearskin) board.Apr 11 2022, 2:04 PM

Niharika closed this task as Resolved.Apr 27 2022, 12:42 AM

Re-opening this, since one more patch needs merging: https://gerrit.wikimedia.org/r/774892

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 7: The Tin Foil Hat) board.May 4 2022, 1:24 PM

We should probably test that this works on Special:Watchlist.

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 7: The Tin Foil Hat) board.May 5 2022, 9:07 AM

Change 774892 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Remove IP address copy action instrument

https://gerrit.wikimedia.org/r/774892

Tchanders moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 7: The Tin Foil Hat) board.May 5 2022, 9:24 AM

Tchanders moved this task from Done Q4 2022 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 7: The Tin Foil Hat) board.

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.12; 2022-05-16); removed MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).May 5 2022, 10:01 AM

In T296469#7906041, @dom_walden wrote:

We should probably test that this works on Special:Watchlist.

Looks like it is:

Niharika closed this task as Resolved.Jun 14 2022, 4:59 PM

Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM

	F35042920: Screen Shot 2022-04-07 at 4.53.08 PM.png
	Apr 7 2022, 9:03 PM

	F35042926: Screen Shot 2022-04-07 at 5.03.10 PM.png
	Apr 7 2022, 9:03 PM

	F35042924: Screen Shot 2022-04-07 at 5.01.04 PM.png
	Apr 7 2022, 9:03 PM

	F35104812: image.png
	May 5 2022, 1:07 PM

Log when a user copies an IP addressClosed, ResolvedPublic2 Estimated Story PointsActions