Page MenuHomePhabricator

Fix length of columns page_restrictions.pr_level/pr_type on wmf wikis
Closed, ResolvedPublic

Description

https://drift-tracker.toolforge.org/report/core/ shows a schema drift for:

  • Mismatching field size of page_restrictions.pr_level
  • Mismatching field size of page_restrictions.pr_type

on s1, s2, s3, s4, s7

Replicas show the following metadata:

MariaDB [bgwiki_p]> show columns from page_restrictions;
+------------+------------------+------+-----+---------+-------+
| Field      | Type             | Null | Key | Default | Extra |
+------------+------------------+------+-----+---------+-------+
| pr_page    | int(8)           | NO   |     | 0       |       |
| pr_type    | varbinary(255)   | NO   |     |         |       |
| pr_level   | varbinary(255)   | NO   |     |         |       |
| pr_cascade | tinyint(4)       | NO   |     | 0       |       |
| pr_user    | int(10) unsigned | YES  |     | NULL    |       |
| pr_expiry  | varbinary(14)    | YES  |     | NULL    |       |
| pr_id      | int(10) unsigned | NO   |     | 0       |       |
+------------+------------------+------+-----+---------+-------+
7 rows in set (0.01 sec)

The fields pr_level/pr_type has a length of 255, while code has a length of 60 since rMWf38344aba87edbdb5dba23d6433bf3c7cbbb0b51
The commit also changed varchar to varbinary, but that seems to be applied already.

There is no ready ALTER statement in the commit history.
The shorter database fields should be no problem, because the existing type/levels are not that long.

ALTER TABLE /*_*/page_restrictions
  CHANGE pr_type pr_type VARBINARY(60) NOT NULL,
  CHANGE pr_level pr_level VARBINARY(60) NOT NULL;
  1. ALTERs to run: see above
  2. Where to run those changes: s1, s2, s3, s4, s7 - list of wikis needs to be created
  3. When to run those changes: any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: beta cluster is running with the new schema
  6. if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Other notes: This is similiar to T278621 on the jobs table.

Progress

  • s1
  • s2
  • s3
  • s4
  • s7

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

s1: enwiki
s2: all wikis
s4: commonswiki
s7: all wikis
s3: super long list - probably worth running it on even the wikis that have the schema change already applied, as it won't hurt.

Change 769403 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/software/schema-changes@master] change_pr_type_pr_level_T298295.py: New schema change

https://gerrit.wikimedia.org/r/769403

Change 769403 merged by jenkins-bot:

[operations/software/schema-changes@master] change_pr_type_pr_level_T298295.py: New schema change

https://gerrit.wikimedia.org/r/769403

Marostegui updated the task description. (Show Details)

This is all done

Please check also s5, s6, s8 as the drift tracker checks a random wiki, which could pass the check, while other wikis on the same section would fail the check

The last run reports as well:
s5 db1161 cebwiki
s6 db1173 ruwiki

I do it, right now some schema changes are happening on s5 and s6, I get it once they are done.

Mentioned in SAL (#wikimedia-operations) [2022-04-29T12:51:50Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1168 (T298295)', diff saved to https://phabricator.wikimedia.org/P27012 and previous config saved to /var/cache/conftool/dbconfig/20220429-125146-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T13:05:56Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1168 (T298295)', diff saved to https://phabricator.wikimedia.org/P27014 and previous config saved to /var/cache/conftool/dbconfig/20220429-130556-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T13:51:13Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1168 (T298295)', diff saved to https://phabricator.wikimedia.org/P27020 and previous config saved to /var/cache/conftool/dbconfig/20220429-135111-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T13:51:31Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1180 (T298295)', diff saved to https://phabricator.wikimedia.org/P27021 and previous config saved to /var/cache/conftool/dbconfig/20220429-135121-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T13:53:29Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1180 (T298295)', diff saved to https://phabricator.wikimedia.org/P27022 and previous config saved to /var/cache/conftool/dbconfig/20220429-135329-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T14:38:45Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1180 (T298295)', diff saved to https://phabricator.wikimedia.org/P27033 and previous config saved to /var/cache/conftool/dbconfig/20220429-143844-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T14:39:10Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1165 (T298295)', diff saved to https://phabricator.wikimedia.org/P27034 and previous config saved to /var/cache/conftool/dbconfig/20220429-143857-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T14:41:05Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1165 (T298295)', diff saved to https://phabricator.wikimedia.org/P27036 and previous config saved to /var/cache/conftool/dbconfig/20220429-144105-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T15:26:21Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1165 (T298295)', diff saved to https://phabricator.wikimedia.org/P27052 and previous config saved to /var/cache/conftool/dbconfig/20220429-152620-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T15:26:37Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1131 (T298295)', diff saved to https://phabricator.wikimedia.org/P27053 and previous config saved to /var/cache/conftool/dbconfig/20220429-152628-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T15:28:37Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1131 (T298295)', diff saved to https://phabricator.wikimedia.org/P27055 and previous config saved to /var/cache/conftool/dbconfig/20220429-152836-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T16:13:52Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1131 (T298295)', diff saved to https://phabricator.wikimedia.org/P27069 and previous config saved to /var/cache/conftool/dbconfig/20220429-161352-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T16:14:08Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1096:3316 (T298295)', diff saved to https://phabricator.wikimedia.org/P27070 and previous config saved to /var/cache/conftool/dbconfig/20220429-161400-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T16:16:10Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3316 (T298295)', diff saved to https://phabricator.wikimedia.org/P27071 and previous config saved to /var/cache/conftool/dbconfig/20220429-161610-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T17:01:26Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3316 (T298295)', diff saved to https://phabricator.wikimedia.org/P27085 and previous config saved to /var/cache/conftool/dbconfig/20220429-170125-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T17:13:19Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1098:3316 (T298295)', diff saved to https://phabricator.wikimedia.org/P27090 and previous config saved to /var/cache/conftool/dbconfig/20220429-171318-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T17:58:34Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1098:3316 (T298295)', diff saved to https://phabricator.wikimedia.org/P27107 and previous config saved to /var/cache/conftool/dbconfig/20220429-175833-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T17:58:50Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1113:3316 (T298295)', diff saved to https://phabricator.wikimedia.org/P27108 and previous config saved to /var/cache/conftool/dbconfig/20220429-175841-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T17:59:52Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3316 (T298295)', diff saved to https://phabricator.wikimedia.org/P27111 and previous config saved to /var/cache/conftool/dbconfig/20220429-175951-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-29T18:45:07Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3316 (T298295)', diff saved to https://phabricator.wikimedia.org/P27124 and previous config saved to /var/cache/conftool/dbconfig/20220429-184506-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T03:20:12Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1096:3315 (T298295)', diff saved to https://phabricator.wikimedia.org/P27227 and previous config saved to /var/cache/conftool/dbconfig/20220502-032011-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T03:22:30Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3315 (T298295)', diff saved to https://phabricator.wikimedia.org/P27228 and previous config saved to /var/cache/conftool/dbconfig/20220502-032229-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T04:07:47Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3315 (T298295)', diff saved to https://phabricator.wikimedia.org/P27242 and previous config saved to /var/cache/conftool/dbconfig/20220502-040745-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T04:07:55Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1130 (T298295)', diff saved to https://phabricator.wikimedia.org/P27243 and previous config saved to /var/cache/conftool/dbconfig/20220502-040754-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T04:09:08Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1130 (T298295)', diff saved to https://phabricator.wikimedia.org/P27244 and previous config saved to /var/cache/conftool/dbconfig/20220502-040908-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T04:55:33Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1110 (T298295)', diff saved to https://phabricator.wikimedia.org/P27253 and previous config saved to /var/cache/conftool/dbconfig/20220502-045532-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T04:57:50Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1110 (T298295)', diff saved to https://phabricator.wikimedia.org/P27255 and previous config saved to /var/cache/conftool/dbconfig/20220502-045750-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T05:43:05Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1110 (T298295)', diff saved to https://phabricator.wikimedia.org/P27265 and previous config saved to /var/cache/conftool/dbconfig/20220502-054305-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T05:43:14Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1144:3315 (T298295)', diff saved to https://phabricator.wikimedia.org/P27266 and previous config saved to /var/cache/conftool/dbconfig/20220502-054313-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T05:45:31Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3315 (T298295)', diff saved to https://phabricator.wikimedia.org/P27267 and previous config saved to /var/cache/conftool/dbconfig/20220502-054530-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T06:30:47Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3315 (T298295)', diff saved to https://phabricator.wikimedia.org/P27278 and previous config saved to /var/cache/conftool/dbconfig/20220502-063047-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T06:30:55Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1113:3315 (T298295)', diff saved to https://phabricator.wikimedia.org/P27279 and previous config saved to /var/cache/conftool/dbconfig/20220502-063055-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T06:32:13Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3315 (T298295)', diff saved to https://phabricator.wikimedia.org/P27280 and previous config saved to /var/cache/conftool/dbconfig/20220502-063212-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T07:17:28Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3315 (T298295)', diff saved to https://phabricator.wikimedia.org/P27294 and previous config saved to /var/cache/conftool/dbconfig/20220502-071728-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T07:17:41Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1161 (T298295)', diff saved to https://phabricator.wikimedia.org/P27295 and previous config saved to /var/cache/conftool/dbconfig/20220502-071741-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T07:19:58Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1161 (T298295)', diff saved to https://phabricator.wikimedia.org/P27296 and previous config saved to /var/cache/conftool/dbconfig/20220502-071958-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T08:05:13Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1161 (T298295)', diff saved to https://phabricator.wikimedia.org/P27312 and previous config saved to /var/cache/conftool/dbconfig/20220502-080513-ladsgroup.json

Done. Including masters.