Page MenuHomePhabricator

Turn on desktop improvements on new set of pilot wikis
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

We would like to change the default skin version on a new set of pilot wikis from legacy Vector to the most recent version of Vector as per the results of community consultation. These wikis will receive all features currently part of the desktop improvements experience. An exception will be made for thwiki and viwiki. There, the sticky header will initially be disabled by default, and enabled at a later time as a part of an A/B test (focused on testing the success of adding an edit button to the sticky header).

Acceptance criteria

  • T298910 should be resolved in production before the deploy.
  • T288686 should be fixed before mediawiki.org deploy as it's likely to lead to lots of 3rd party installs
  • Pre-deployment criteria: ensure desktop improvements features are tested across all of the wikis below
  • Switch default skin version from legacy Vector to new Vector for the following wikis:

arywiki
frwikiquote
ptwikinews
plwikinews
viwiki
viwikibooks
MediaWiki
Foundation-wiki
Collab-wiki
Strategy-wiki
thwiki

  • Ensure the sticky header feature flag is off for the following wikis: viwiki, thwiki. We will be testing the editing functionality within the sticky header on these wikis at a later time
  • Ensure feature flag for language switching notice in the old location is "on"

QA

For each wiki check in an incognito window that you are getting the modern Vector skin

QA Results - Prod

Event Timeline

ovasileva raised the priority of this task from Medium to High.Jan 6 2022, 5:29 PM
ovasileva updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)
LGoto set the point value for this task to 2.
Jdlrobson subscribed.

Blocked on Olga saying it's time to deploy.

wikiscreenshotstate
arywiki
Screen Shot 2022-01-17 at 9.45.10 AM.png (529×1 px, 214 KB)
frwikiquote
Screen Shot 2022-01-17 at 9.47.40 AM.png (437×1 px, 197 KB)
ptwikinews
Screen Shot 2022-01-17 at 9.48.45 AM.png (421×1 px, 207 KB)
plwikinews
Screen Shot 2022-01-17 at 9.53.28 AM.png (435×1 px, 179 KB)
viwiki
Screen Shot 2022-01-17 at 9.55.53 AM.png (368×1 px, 143 KB)
viwikibooks
Screen Shot 2022-01-17 at 9.57.19 AM.png (559×1 px, 723 KB)
mediawiki
Screen Shot 2022-01-17 at 9.58.06 AM.png (490×1 px, 176 KB)
foundationwiki
Screen Shot 2022-01-17 at 9.58.54 AM.png (426×1 px, 180 KB)
collabwiki
Screen Shot 2022-01-17 at 9.59.51 AM.png (469×1 px, 114 KB)
strategywiki
Screen Shot 2022-01-17 at 10.01.44 AM.png (375×1 px, 84 KB)
thwiki
Screen Shot 2022-01-17 at 10.02.55 AM.png (467×1 px, 241 KB)

Change 755038 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/mediawiki-config@master] Update config for pilot wikis:

https://gerrit.wikimedia.org/r/755038

cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming subscribed.

Because 2nd AC is still WIP, leaving out mediawiki for now. I will add in a follow up config patch.

Moving this ticket to blocked for the time being.

Change 755038 merged by jenkins-bot:

[operations/mediawiki-config@master] Update config for pilot wikis:

https://gerrit.wikimedia.org/r/755038

Mentioned in SAL (#wikimedia-operations) [2022-01-19T19:09:37Z] <cjming@deploy1002> Synchronized dblists/desktop-improvements.dblist: Config: [[gerrit:755038|Update config for pilot wikis: (T298519)]] (duration: 01m 09s)

Mentioned in SAL (#wikimedia-operations) [2022-01-19T19:10:37Z] <cjming@deploy1002> Synchronized wmf-config/config/ptwikinews.yaml: Config: [[gerrit:755038|Update config for pilot wikis: (T298519)]] (duration: 00m 50s)

Mentioned in SAL (#wikimedia-operations) [2022-01-19T19:11:29Z] <cjming@deploy1002> Synchronized wmf-config/config/viwiki.yaml: Config: [[gerrit:755038|Update config for pilot wikis: (T298519)]] (duration: 00m 49s)

Mentioned in SAL (#wikimedia-operations) [2022-01-19T19:12:26Z] <cjming@deploy1002> Synchronized wmf-config/config/foundationwiki.yaml: Config: [[gerrit:755038|Update config for pilot wikis: (T298519)]] (duration: 00m 49s)

Mentioned in SAL (#wikimedia-operations) [2022-01-19T19:17:33Z] <cjming@deploy1002> Synchronized wmf-config/config: Config: [[gerrit:755038|Update config for pilot wikis: (T298519)]] (duration: 00m 49s)

Given language alert issues, we're turning the feature off for pilot wikis except for thwiki, viwiki.

MediaWiki.org has not been done. I think the QA was performed on logged in users rather than anonymous users so probably worth doing that again.

Jdlrobson updated the task description. (Show Details)

Change 761739 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Make Vector 2022 the default skin for MediaWiki.org

https://gerrit.wikimedia.org/r/761739

Change 761739 merged by jenkins-bot:

[operations/mediawiki-config@master] Make Vector 2022 the default skin for MediaWiki.org

https://gerrit.wikimedia.org/r/761739

Mentioned in SAL (#wikimedia-operations) [2022-02-11T00:31:26Z] <thcipriani@deploy1002> Synchronized wmf-config/config/mediawikiwiki.yaml: Config: [[gerrit:761739|Make Vector 2022 the default skin for MediaWiki.org (T298519)]] (duration: 00m 48s)

Mentioned in SAL (#wikimedia-operations) [2022-02-11T00:33:22Z] <thcipriani@deploy1002> Synchronized dblists/desktop-improvements.dblist: Config: [[gerrit:761739|Make Vector 2022 the default skin for MediaWiki.org (T298519)]] (duration: 00m 48s)

We would like to change the default skin version on a new set of pilot wikis from legacy Vector to the most recent version of Vector as per the results of community consultation.

In which places did this community consultation take place? Can you please provide links?

Test Result - Prod

Status:
Environment: see below
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

@ovasileva Below are the results of my tests in Prod. I put my best guess on whether some failed because I'm not sure if the different wiki's behave differently. I'm also passing the wikis that need the query param to show the sticky header when anon per our discussion in standup, this is different from what I understand the the task description.

wikisidebar, user menu, sticky header, ULS
✅ AC1: arywiki
Screen Recording 2022-02-15 at 2.33.44 PM.mov.gif (902×1 px, 1 MB)
Screen Recording 2022-02-16 at 6.16.43 AM.mov.gif (546×984 px, 1 MB)
✅ AC2: frwikiquote
Screen Recording 2022-02-15 at 3.33.04 PM.mov.gif (902×1 px, 3 MB)
Screen Recording 2022-02-16 at 6.21.47 AM.mov.gif (546×984 px, 1 MB)
❓ AC3: ptwikinewsThe font in the sticky header is smaller and with a different font.
Screen Recording 2022-02-15 at 3.35.54 PM.mov.gif (902×1 px, 1 MB)
Screen Recording 2022-02-15 at 3.35.20 PM.mov.gif (902×1 px, 1 MB)
Screen Recording 2022-02-16 at 6.53.02 AM.mov.gif (542×1 px, 418 KB)
✅ AC4: plwikinews
Screen Recording 2022-02-15 at 3.40.21 PM.mov.gif (902×1 px, 1 MB)
Screen Recording 2022-02-16 at 6.56.04 AM.mov.gif (542×1 px, 1 MB)
❌ AC5: viwikiThe user menu expands when you hover over it. Clicking the button doesn't dismiss the menu, you have to move away from it. If you click the user menu button you have to click outside of it to collapse it.
Screen Recording 2022-02-15 at 3.44.57 PM.mov.gif (902×1 px, 1 MB)
Screen Recording 2022-02-16 at 6.58.51 AM.mov.gif (542×1 px, 1 MB)
✅ AC6: viwikibooks//Could not find a book with languages.
Screen Recording 2022-02-15 at 3.49.39 PM.mov.gif (902×1 px, 870 KB)
Screen Recording 2022-02-16 at 7.00.20 AM.mov.gif (542×1 px, 801 KB)
✅ AC7: MediaWikiCould not verify ULS. The search button in the sticky header is fixed.
Screen Recording 2022-02-15 at 3.55.52 PM.mov.gif (902×1 px, 2 MB)
Screen Recording 2022-02-16 at 6.19.42 PM.mov.gif (542×1 px, 1 MB)
✅ AC8: Foundation-wikiCould not find a page with ULS. Default search text is no longer truncated.
Screen Recording 2022-02-15 at 3.59.38 PM.mov.gif (902×1 px, 1 MB)
Screen Recording 2022-02-16 at 6.22.13 PM.mov.gif (542×1 px, 1 MB)
✅ AC9: Collab-wiki
Screen Recording 2022-02-15 at 4.02.04 PM.mov.gif (902×1 px, 1 MB)
✅ AC10: Strategy-wiki/
Screen Recording 2022-02-15 at 5.43.18 PM.mov.gif (902×1 px, 1 MB)
✅ AC11: thwiki
Screen Recording 2022-02-15 at 5.49.33 PM.mov.gif (902×1 px, 1 MB)
Screen Recording 2022-02-16 at 6.36.25 PM.mov.gif (542×1 px, 1 MB)

For each wiki check in an incognito window that you are getting the modern Vector skin

@Edtadros many of the screenshots are showing the logged in interface ( AC11, AC8, AC7,AC5,AC4,AC3, AC2,AC1)

@Jdlrobson, Ahh....I thought it was odd that it asked for incognito. Thought maybe it had to do with cache. I will retest as anon. Thanks.

@Edtadros - all of this looks good except for the search cutting off (See AC8 in T298519#7713541). @Jdlrobson, @alexhollender_WMF - do you remember if this already tracked or should we open a new task?

@Edtadros - all of this looks good except for the search cutting off (See AC8 in T298519#7713541). @Jdlrobson, @alexhollender_WMF - do you remember if this already tracked or should we open a new task?

not tracked as far as I know

@ovasileva I've updated my comments and screenshots with anon test results in T298519#7713541. I'm moving this to Ready for Signoff. The search truncation issue looks resolved. The only issues that need your attention are AC3: ptwikinews with the unique font in the sticky header. I'm not sure if this is an issue. And AC5: viwiki with the user menu button behavior. Jon mentioned this is probably due to a gadget.

@ovasileva I've updated my comments and screenshots with anon test results in T298519#7713541. I'm moving this to Ready for Signoff. The search truncation issue looks resolved. The only issues that need your attention are AC3: ptwikinews with the unique font in the sticky header. I'm not sure if this is an issue. And AC5: viwiki with the user menu button behavior. Jon mentioned this is probably due to a gadget.

Seems like a local gadget to show the menu on hover. Otherwise, looks good, resolving!