Page MenuHomePhabricator

Fix mismatching field type of page.page_touched on wmf wikis
Closed, ResolvedPublic

Description

https://drift-tracker.toolforge.org/report/core/ shows a schema drift for:

Mismatching field type of page.page_touched

on s1, s2, s3, s4, s7

According to T42626 the timestamp should be adjust from varbinary(14) to binary(14) because there is no need to hold infinite.
The column was added in 64ac6b8e775dd8582ea9cc5f24235488f076c5b3#change-pVGjpnYAcwz0

There is no ready ALTER statement in the commit history.

ALTER TABLE /*_*/page
  CHANGE page_touched page_touched BINARY(14) NOT NULL;
  1. ALTERs to run: see above
  2. Where to run those changes: s1, s2, s3, s4, s7 - list of wikis needs to be created
  3. When to run those changes: any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: beta cluster is running with the new schema
  6. if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Progress

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Mentioned in SAL (#wikimedia-operations) [2022-05-19T08:36:02Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3315 (T298557)', diff saved to https://phabricator.wikimedia.org/P28090 and previous config saved to /var/cache/conftool/dbconfig/20220519-083601-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T08:36:14Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1110 (T298557)', diff saved to https://phabricator.wikimedia.org/P28091 and previous config saved to /var/cache/conftool/dbconfig/20220519-083609-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T09:00:45Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1110 (T298557)', diff saved to https://phabricator.wikimedia.org/P28094 and previous config saved to /var/cache/conftool/dbconfig/20220519-090044-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T09:46:00Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1110 (T298557)', diff saved to https://phabricator.wikimedia.org/P28101 and previous config saved to /var/cache/conftool/dbconfig/20220519-094559-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T09:46:13Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1144:3315 (T298557)', diff saved to https://phabricator.wikimedia.org/P28102 and previous config saved to /var/cache/conftool/dbconfig/20220519-094607-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T10:11:09Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3315 (T298557)', diff saved to https://phabricator.wikimedia.org/P28107 and previous config saved to /var/cache/conftool/dbconfig/20220519-101108-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T10:56:24Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3315 (T298557)', diff saved to https://phabricator.wikimedia.org/P28112 and previous config saved to /var/cache/conftool/dbconfig/20220519-105624-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T10:56:44Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1161 (T298557)', diff saved to https://phabricator.wikimedia.org/P28113 and previous config saved to /var/cache/conftool/dbconfig/20220519-105637-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T11:20:06Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1161 (T298557)', diff saved to https://phabricator.wikimedia.org/P28115 and previous config saved to /var/cache/conftool/dbconfig/20220519-112006-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T12:05:21Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1161 (T298557)', diff saved to https://phabricator.wikimedia.org/P28124 and previous config saved to /var/cache/conftool/dbconfig/20220519-120521-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T12:44:58Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1096:3315 (T298557)', diff saved to https://phabricator.wikimedia.org/P28131 and previous config saved to /var/cache/conftool/dbconfig/20220519-124456-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T13:11:09Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3315 (T298557)', diff saved to https://phabricator.wikimedia.org/P28135 and previous config saved to /var/cache/conftool/dbconfig/20220519-131108-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T13:56:25Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3315 (T298557)', diff saved to https://phabricator.wikimedia.org/P28139 and previous config saved to /var/cache/conftool/dbconfig/20220519-135624-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T13:56:37Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1130 (T298557)', diff saved to https://phabricator.wikimedia.org/P28140 and previous config saved to /var/cache/conftool/dbconfig/20220519-135632-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-05-19T14:14:54Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1130 (T298557)', diff saved to https://phabricator.wikimedia.org/P28142 and previous config saved to /var/cache/conftool/dbconfig/20220519-141453-marostegui.json

s5 is all done except the master, which will be done after this switchover: T308725

s5 is all done except the master, which will be done after this switchover: T308725

Done

Drift tracker says it's not done in most of s6. Including its master https://drift-tracker.toolforge.org/report/core/ but thankfully this should be runnable live on master?

It was only needed for labswiki? I can review tomorrow

no it was needed for all of s6. Thanks. No rush.

This will need a switchover on s6 master

Mentioned in SAL (#wikimedia-operations) [2022-06-28T07:11:58Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1173 (T298557)', diff saved to https://phabricator.wikimedia.org/P30510 and previous config saved to /var/cache/conftool/dbconfig/20220628-071157-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T07:12:19Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1165 (T298557)', diff saved to https://phabricator.wikimedia.org/P30511 and previous config saved to /var/cache/conftool/dbconfig/20220628-071210-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T07:20:24Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1165 (T298557)', diff saved to https://phabricator.wikimedia.org/P30513 and previous config saved to /var/cache/conftool/dbconfig/20220628-072024-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T08:05:40Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1165 (T298557)', diff saved to https://phabricator.wikimedia.org/P30524 and previous config saved to /var/cache/conftool/dbconfig/20220628-080539-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T08:05:52Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1113:3316 (T298557)', diff saved to https://phabricator.wikimedia.org/P30525 and previous config saved to /var/cache/conftool/dbconfig/20220628-080547-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T08:27:55Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3316 (T298557)', diff saved to https://phabricator.wikimedia.org/P30531 and previous config saved to /var/cache/conftool/dbconfig/20220628-082755-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T09:13:11Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3316 (T298557)', diff saved to https://phabricator.wikimedia.org/P30539 and previous config saved to /var/cache/conftool/dbconfig/20220628-091310-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T09:13:27Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1098:3316 (T298557)', diff saved to https://phabricator.wikimedia.org/P30541 and previous config saved to /var/cache/conftool/dbconfig/20220628-091318-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T09:38:07Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1098:3316 (T298557)', diff saved to https://phabricator.wikimedia.org/P30547 and previous config saved to /var/cache/conftool/dbconfig/20220628-093807-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T10:23:23Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1098:3316 (T298557)', diff saved to https://phabricator.wikimedia.org/P30560 and previous config saved to /var/cache/conftool/dbconfig/20220628-102322-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T10:23:38Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1096:3316 (T298557)', diff saved to https://phabricator.wikimedia.org/P30561 and previous config saved to /var/cache/conftool/dbconfig/20220628-102331-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T10:46:31Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3316 (T298557)', diff saved to https://phabricator.wikimedia.org/P30568 and previous config saved to /var/cache/conftool/dbconfig/20220628-104631-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T11:31:46Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3316 (T298557)', diff saved to https://phabricator.wikimedia.org/P30572 and previous config saved to /var/cache/conftool/dbconfig/20220628-113146-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T11:31:58Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1168 (T298557)', diff saved to https://phabricator.wikimedia.org/P30573 and previous config saved to /var/cache/conftool/dbconfig/20220628-113154-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T11:40:20Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1168 (T298557)', diff saved to https://phabricator.wikimedia.org/P30574 and previous config saved to /var/cache/conftool/dbconfig/20220628-114020-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T12:25:35Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1168 (T298557)', diff saved to https://phabricator.wikimedia.org/P30577 and previous config saved to /var/cache/conftool/dbconfig/20220628-122535-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T12:25:49Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1180 (T298557)', diff saved to https://phabricator.wikimedia.org/P30578 and previous config saved to /var/cache/conftool/dbconfig/20220628-122543-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T12:34:24Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1180 (T298557)', diff saved to https://phabricator.wikimedia.org/P30579 and previous config saved to /var/cache/conftool/dbconfig/20220628-123424-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T13:19:39Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1180 (T298557)', diff saved to https://phabricator.wikimedia.org/P30582 and previous config saved to /var/cache/conftool/dbconfig/20220628-131939-marostegui.json

s6 has been done entirely, I am going to schedule a switchover for next tuesday 4th July

Marostegui updated the task description. (Show Details)
Marostegui updated the task description. (Show Details)