Page MenuHomePhabricator
Create Task
Maniphest T298916

Any code that checks getSkinName for vector must now also check vector-2022
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The code $skin->getSkinName() === 'vector' is often used in hooks to determine whether to take certain actions in code. Wherever this pattern exists we should also check 'vector-2022' now that Vector is 2 separate skins.

On top of this certain extensions allow disabling features on a skin basis. These should be updated.

TODO

QA

Details

SubjectRepoBranchLines +/-
[Hooks] Revise getModuleFile function for vector-2022 skinmediawiki/extensions/WikimediaEventsmaster+34 -24
Update skin checks with new vector skin key.mediawiki/extensions/ContentTranslationwmf/1.38.0-wmf.20+1 -1
Update skin checks with new vector skin key.mediawiki/extensions/ContentTranslationmaster+1 -1
Add new vector skin key to RelatedArticlesFooterAllowedSkins.operations/mediawiki-configmaster+3 -3
Update skin checks for new vector skin key.mediawiki/extensions/ProofreadPagemaster+3 -3
Update hook to check for new vector skin key.mediawiki/skins/Vectormaster+2 -2
Update hook to check for new vector skin key.mediawiki/extensions/ContentTranslationmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jan 10 2022, 10:12 PM
Jdlrobson added projects: MediaWiki-extensions-WikimediaEvents, Vector (legacy skin).Jan 10 2022, 10:14 PM
Jdlrobson updated the task description. (Show Details)
cjming claimed this task.Jan 10 2022, 10:20 PM
Jdlrobson removed cjming as the assignee of this task.Jan 10 2022, 11:00 PM
Jdlrobson triaged this task as High priority.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: cjming.
Wellverywell subscribed.Jan 11 2022, 12:55 AM
LGoto set the point value for this task to 2.Jan 11 2022, 6:25 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming claimed this task.Jan 11 2022, 6:48 PM
cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jan 11 2022, 9:24 PM

Change 753149 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/ContentTranslation@master] Update hook to check for new vector skin key.

https://gerrit.wikimedia.org/r/753149

gerritbot added a project: Patch-For-Review.Jan 11 2022, 9:24 PM

Change 753150 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/ProofreadPage@master] Update skin checks for new vector skin key.

https://gerrit.wikimedia.org/r/753150

gerritbot added a comment.Jan 11 2022, 9:57 PM

Change 753158 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/WikimediaEvents@master] Update skin checks with new vector skin key.

https://gerrit.wikimedia.org/r/753158

gerritbot added a comment.Jan 11 2022, 11:13 PM

Change 753149 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Update hook to check for new vector skin key.

https://gerrit.wikimedia.org/r/753149

Jdlrobson moved this task from Doing to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 11 2022, 11:14 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Jan 11 2022, 11:32 PM

Change 753182 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Update hook to check for new vector skin key.

https://gerrit.wikimedia.org/r/753182

gerritbot added a comment.Jan 11 2022, 11:55 PM

Change 753187 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/mediawiki-config@master] Add new vector skin key to RelatedArticlesFooterAllowedSkins.

https://gerrit.wikimedia.org/r/753187

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 12 2022, 12:00 AM
gerritbot added a comment.Jan 12 2022, 12:15 AM

Change 753193 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/ContentTranslation@master] Update skin checks with new vector skin key.

https://gerrit.wikimedia.org/r/753193

gerritbot added a comment.Jan 12 2022, 12:23 AM

Change 753195 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/UniversalLanguageSelector@master] Update skin check with new vector skin key.

https://gerrit.wikimedia.org/r/753195

gerritbot added a comment.Jan 12 2022, 12:29 AM

Change 753182 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update hook to check for new vector skin key.

https://gerrit.wikimedia.org/r/753182

gerritbot added a comment.Jan 12 2022, 9:01 AM

Change 753150 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Update skin checks for new vector skin key.

https://gerrit.wikimedia.org/r/753150

Jdlrobson updated the task description. (Show Details)Jan 12 2022, 3:36 PM
gerritbot added a comment.Jan 12 2022, 4:01 PM

Change 753193 abandoned by Clare Ming:

[mediawiki/extensions/ContentTranslation@master] Update skin checks with new vector skin key.

Reason:

not needed

https://gerrit.wikimedia.org/r/753193

gerritbot added a comment.Jan 12 2022, 7:15 PM

Change 753187 merged by jenkins-bot:

[operations/mediawiki-config@master] Add new vector skin key to RelatedArticlesFooterAllowedSkins.

https://gerrit.wikimedia.org/r/753187

Jdlrobson updated the task description. (Show Details)Jan 12 2022, 7:18 PM
Stashbot added a comment.Jan 12 2022, 7:19 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-12T19:19:06Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:753187|Add new vector skin key to RelatedArticlesFooterAllowedSkins. (T298916)]] (duration: 01m 21s)

Jdlrobson removed cjming as the assignee of this task.Jan 12 2022, 7:23 PM
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 13 2022, 12:53 AM
LGoto assigned this task to • nray.Jan 13 2022, 6:06 PM
cjming updated the task description. (Show Details)Jan 13 2022, 11:23 PM
gerritbot added a comment.Jan 13 2022, 11:52 PM

Change 753158 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] [Hooks] Revise getModuleFile function for vector-2022 skin

https://gerrit.wikimedia.org/r/753158

Nikerabbit moved this task from Needs Triage to Upstream/Other teams on the ContentTranslation board.Jan 17 2022, 11:34 AM
• nray closed this task as Resolved.Jan 18 2022, 10:27 PM
• nray reassigned this task from • nray to cjming.
• nray subscribed.
gerritbot added a comment.Feb 3 2022, 4:38 PM

Change 753193 restored by Jdlrobson:

[mediawiki/extensions/ContentTranslation@master] Update skin checks with new vector skin key.

https://gerrit.wikimedia.org/r/753193

gerritbot added a comment.Feb 3 2022, 4:56 PM

Change 753193 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Update skin checks with new vector skin key.

https://gerrit.wikimedia.org/r/753193

gerritbot added a comment.Feb 3 2022, 5:36 PM

Change 759314 had a related patch set uploaded (by Jdlrobson; author: Clare Ming):

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.20] Update skin checks with new vector skin key.

https://gerrit.wikimedia.org/r/759314

gerritbot added a comment.Feb 3 2022, 7:25 PM

Change 759314 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.20] Update skin checks with new vector skin key.

https://gerrit.wikimedia.org/r/759314

Stashbot added a comment.Feb 3 2022, 7:33 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-03T19:33:15Z] <taavi@deploy1002> Synchronized php-1.38.0-wmf.20/extensions/ContentTranslation/modules/entrypoints/ext.cx.entrypoints.contributionsmenu.js: Backport: [[gerrit:759314|Update skin checks with new vector skin key. (T298916 T300814)]] (duration: 00m 50s)

Stashbot mentioned this in T300814: Live preview doesn't work with Vector 2022 skin.Feb 3 2022, 7:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL