Page MenuHomePhabricator
Create Task
Maniphest T299601

Restrict creating Types to users with a special right
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Restrict creating Types to users with a special rightmediawiki/extensions/WikiLambdamaster+1 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Jan 19 2022, 10:28 PM
DVrandecic mentioned this in T299176: Phase Theta – Root task.Jan 19 2022, 11:01 PM
Jdforrester-WMF triaged this task as High priority.Mar 8 2022, 11:26 PM
Jdforrester-WMF moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase θ – Throttling) board.
Jdforrester-WMF moved this task from Ready to do to Ready: G6. Stable and secure running (Performance) on the Abstract Wikipedia team (Phase θ – Throttling) board.Apr 18 2022, 6:39 PM
Jdforrester-WMF moved this task from Ready: G6. Stable and secure running (Performance) to Ready: G6. Stable & secure on the Abstract Wikipedia team (Phase θ – Throttling) board.Aug 2 2022, 4:59 PM
gengh added a parent task: T321187: Add all necessary path-operation-user restrictions.Oct 19 2022, 12:26 PM
Jdforrester-WMF mentioned this in T282914: Provide user rights for editing of ZObjects at all, and specific ones for ZImplementations, ZTesters, and ZFunctions.Nov 30 2022, 10:21 PM
gengh claimed this task.Feb 22 2023, 11:56 AM
gengh moved this task from Ready: G6. Stable & secure to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Feb 28 2023, 10:08 AM
DVrandecic subscribed.Mar 30 2023, 10:54 PM

That seems still to work with users without special rights?

Etonkovidova subscribed.EditedApr 25 2023, 9:28 PM
In T299601#8743715, @DVrandecic wrote:

That seems still to work with users without special rights?

Yes, it seems to be the case.
Checked https://wikifunctions.beta.wmflabs.org (marked with ); the behavior is not correct according to Help:Wikifunctions/User rights

User groupCan modify/add existing Type content & publish?Can publish a new Type?
Users groupcannot publish
Screen Shot 2023-04-25 at 2.15.56 PM.png (1×1 px, 204 KB)
can select Type on Special:CreateZObject; cannot publish
Screen Shot 2023-04-25 at 1.46.40 PM.png (1×1 px, 231 KB)
sysop (e.g. Special:Log - creation of a new Type)no can select Type on Special:CreateZObject; start modifying the content; can publish
gerritbot added a comment.Apr 26 2023, 10:32 PM

Change 912411 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] tests: Also test creations in ZObjectAuthorization

https://gerrit.wikimedia.org/r/912411

gerritbot added a project: Patch-For-Review.Apr 26 2023, 10:32 PM
gengh moved this task from QA / Ready to close to Ready: G6. Stable & secure on the Abstract Wikipedia team (Phase θ – Throttling) board.May 16 2023, 10:30 AM
DVrandecic added a comment.EditedMay 17 2023, 12:33 AM

Can still create types with no special rights, see

https://wikifunctions.beta.wmflabs.org/w/index.php?title=Z10764&action=history

gengh removed gengh as the assignee of this task.May 22 2023, 1:54 PM
gengh subscribed.
Jdforrester-WMF claimed this task.Jun 5 2023, 8:08 PM
gerritbot added a comment.Jun 6 2023, 12:20 AM

Change 927314 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Restrict creating Types to users with a special right

https://gerrit.wikimedia.org/r/927314

gerritbot added a comment.Jun 6 2023, 7:54 PM

Change 927314 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Restrict creating Types to users with a special right

https://gerrit.wikimedia.org/r/927314

Jdforrester-WMF moved this task from Ready: G6. Stable & secure to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Jun 6 2023, 7:56 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 6 2023, 8:00 PM
Jdforrester-WMF closed this task as Resolved.Jun 8 2023, 9:26 PM
Etonkovidova mentioned this in T340090: [QA-task] Creating Types - check User groups workflow.Jun 22 2023, 3:48 AM
DVrandecic mentioned this in T299598: Add security limits to the Wikifunctions system to maintain stability and integrity of the content.Jul 6 2023, 12:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL