Page MenuHomePhabricator

Clean up InitialiseSettings
Closed, DeclinedPublic

Description

After consultation with @Lucas_Werkmeister_WMDE on IRC, I'm going to clean up InitialiseSettings.php so that each line of the page mentions to at most one Phabricator ticket. This increases the readability of the document.

Example:
Previous status for enwiki:

	'+enwiki' => [
		'eventcoordinator' => [ 'confirmed' ], // T193075
		'sysop' => [ 'abusefilter', 'abusefilter-helper', 'accountcreator', 'autoreviewer', 'confirmed', 'eventcoordinator', 'filemover', 'reviewer', 'rollbacker', 'templateeditor', 'massmessage-sender', 'extendedconfirmed', 'extendedmover', 'patroller' ], // T126607, T133981, T149019, T175684, T193075
	],

Cleaned up status for enwiki:

	'+enwiki' => [
		'eventcoordinator' => [ 'confirmed' ], // T193075
		'sysop' => [
			'abusefilter',
			'abusefilter-helper', // T175684
			'accountcreator',
			'autoreviewer',
			'confirmed',
			'eventcoordinator', // T193075
			'filemover',
			'reviewer',
			'rollbacker',
			'templateeditor',
			'massmessage-sender',
			'extendedconfirmed', // T126607
			'extendedmover', // T133981
			'patroller', // T149019
		],
	],

In order for reviewers and deployers to be able to review the changes, I'm going to do this task in a series of smaller changes, beginning with wgAddGroups and covering A-E in the first patch.

I will continue to do so for the entire document.

Event Timeline

Change 762140 had a related patch set uploaded (by 4nn1l2; author: 4nn1l2):

[operations/mediawiki-config@master] InitialiseSettings: General cleanup

https://gerrit.wikimedia.org/r/762140

Change 762140 merged by jenkins-bot:

[operations/mediawiki-config@master] InitialiseSettings: General cleanup

https://gerrit.wikimedia.org/r/762140

Mentioned in SAL (#wikimedia-operations) [2022-02-14T14:35:30Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:762140|InitialiseSettings: General cleanup (T301647)]] (should be a no-op) (duration: 00m 48s)

4nn1l2 changed the task status from Open to In Progress.Feb 14 2022, 2:37 PM

Change 762819 had a related patch set uploaded (by 4nn1l2; author: 4nn1l2):

[operations/mediawiki-config@master] InitialiseSettings: General cleanup

https://gerrit.wikimedia.org/r/762819

Change 762819 merged by jenkins-bot:

[operations/mediawiki-config@master] InitialiseSettings: General cleanup

https://gerrit.wikimedia.org/r/762819

Mentioned in SAL (#wikimedia-operations) [2022-02-15T14:28:58Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:762819|InitialiseSettings: General cleanup (T301647)]] (wgAddGroups F-I) (duration: 02m 41s)

Change 763225 had a related patch set uploaded (by 4nn1l2; author: 4nn1l2):

[operations/mediawiki-config@master] InitialiseSettings: General cleanup, wgAddGroups (J-P)

https://gerrit.wikimedia.org/r/763225

Change 763225 merged by jenkins-bot:

[operations/mediawiki-config@master] InitialiseSettings: General cleanup, wgAddGroups (J-P)

https://gerrit.wikimedia.org/r/763225

Mentioned in SAL (#wikimedia-operations) [2022-02-16T21:16:33Z] <tgr@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:763225|InitialiseSettings: General cleanup, wgAddGroups (J-P) (T301647)]] (duration: 00m 51s)

That's a most welcome change, thanks!

Change 763398 had a related patch set uploaded (by 4nn1l2; author: 4nn1l2):

[operations/mediawiki-config@master] InitialiseSettings: General cleanup, wgAddGroups (R-Z)

https://gerrit.wikimedia.org/r/763398

Change 763398 merged by jenkins-bot:

[operations/mediawiki-config@master] InitialiseSettings: General cleanup, wgAddGroups (R-Z)

https://gerrit.wikimedia.org/r/763398

Mentioned in SAL (#wikimedia-operations) [2022-02-17T14:19:10Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:763398|InitialiseSettings: General cleanup, wgAddGroups (R-Z) (T301647)]] (no-op) (duration: 00m 50s)

Change 764465 had a related patch set uploaded (by 4nn1l2; author: 4nn1l2):

[operations/mediawiki-config@master] InitialiseSettings: General cleanup, wgRemoveGroups (A-D)

https://gerrit.wikimedia.org/r/764465

Change 764465 merged by jenkins-bot:

[operations/mediawiki-config@master] InitialiseSettings: General cleanup, wgRemoveGroups (A-D)

https://gerrit.wikimedia.org/r/764465

Mentioned in SAL (#wikimedia-operations) [2022-02-22T21:32:54Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 6d1d9a9ee2d633cf67e81fd2277deb4a61b87891: InitialiseSettings: General cleanup, wgRemoveGroups (A-D) (T301647) (duration: 00m 50s)

Aklapper removed a project: Patch-For-Review.

The published version at https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php appears to be getting out of sync, any relation to this?

Specifically the usergroup/rights sections appear to be missing (or were they moved to another file I'm overlooking there?)

The published version at https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php appears to be getting out of sync, any relation to this?

Specifically the usergroup/rights sections appear to be missing (or were they moved to another file I'm overlooking there?)

Some settings are beings moved to other files (including usergroups/rights which are now in core-Permissions.php), see T308932.

Pppery subscribed.

Boldly closing as declined since this was a personal project by a now-WMF-Banned user that it's unlikely anyone else will pick up.