Maniphest T301930

End the Vector skin version migration mode
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 17 2022, 12:02 AM

Tags

Referenced Files

None

Subscribers

Description

When the migration of database preferences has occurred in T299104 we can remove all code relating to skin versioning to complete the technical goal.

Acceptance criteria

All code relating to the old preference is removed e.g. includes/HTMLForm/Fields/HTMLLegacySkinVersionField.php
Make SkinVersion an abstract class and make the isLegacy method a simple return false or return true

QA

Visit /w/index.php/Selenium_category_test?useskin=vector and confirm you get old Vector
Visit /w/index.php/Selenium_category_test?useskin=vector-2022 and confirm you get new Vector
In Special:Preferences confirm you can change to legacy Vector
In Special:Preferences confirm you can change to modern Vector

Details

	Subject	Repo	Branch	Lines +/-
	End migration mode	mediawiki/skins/Vector	master	+112 -1 K

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T273473 [Epic] Improve the table of contents
		Resolved		Jdrewniak	T291098 [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys
		Resolved		Jdrewniak	T301930 End the Vector skin version migration mode

Event Timeline

Jdlrobson created this task.Feb 17 2022, 12:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2022, 12:02 AM

Jdlrobson added a parent task: T291098: [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys.Feb 17 2022, 12:02 AM

Change 755813 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] End migration mode

https://gerrit.wikimedia.org/r/755813

gerritbot added a project: Patch-For-Review.Feb 17 2022, 12:03 AM

Jdlrobson triaged this task as High priority.Feb 18 2022, 10:10 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Needs Prioritization (Tech)).Mar 16 2022, 9:42 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson mentioned this in T303860: ToC: ToC appears empty on certain pages.Mar 16 2022, 10:33 PM

LGoto set the point value for this task to 5.Mar 22 2022, 5:14 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson moved this task from Ready for Development to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 22 2022, 11:15 PM

LGoto assigned this task to Jdrewniak.Mar 23 2022, 4:40 PM

Change 755813 merged by jenkins-bot:

[mediawiki/skins/Vector@master] End migration mode

https://gerrit.wikimedia.org/r/755813

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2022, 5:10 PM

Change 774839 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.39.0-wmf.4] End migration mode

https://gerrit.wikimedia.org/r/774839

gerritbot added a project: Patch-For-Review.Mar 29 2022, 4:59 PM

Jdrewniak closed this task as Resolved.Mar 31 2022, 5:00 PM