@cmadeo Heads up, I just noticed the text seems to be truncated at the API itself, so we won't be able to get to your full text state easily. Here's the object returned for the notification that was triggered by this edit. Notice the body value:

{
          "wiki": "enwiki",
          "id": 241957574,
          "type": "edit-user-talk",
          "category": "edit-user-talk",
          "section": "alert",
          "timestamp": {
            "utciso8601": "2022-03-09T17:02:51Z",
            "utcunix": 1646845371,
            "unix": "1646845371",
            "utcmw": "20220309170251",
            "mw": "20220309170251",
            "date": "Today"
          },
          "title": {
            "full": "User talk:Tsevener",
            "namespace": "User_talk",
            "namespace-key": 3,
            "text": "Tsevener"
          },
          "agent": {
            "id": 35904678,
            "name": "TSevener (WMF)"
          },
          "revid": 1076152880,
          "targetpages": [],
          "*": {
            "header": "‪TSevener (WMF)‬ left a message on <strong>your talk page</strong> in \"<strong>‪Testing new topic with long reply.‬</strong>\".",
            "compactHeader": "‪TSevener (WMF)‬ left you a message in \"<strong>‪Testing new topic with long reply.‬</strong>\".",
            "body": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Adipiscing elit ut aliq...",
            "icon": "edit-user-talk",
            "links": {
              "primary": {
                "url": "https://en.wikipedia.org/wiki/User_talk:Tsevener?markasread=241957574&markasreadwiki=enwiki#c-TSevener_(WMF)-2022-03-09T17:02:00.000Z-Testing_new_topic_with_long_reply.",
                "label": "View message"
              },
              "secondary": [
                {
                  "url": "https://en.wikipedia.org/wiki/User:TSevener_(WMF)",
                  "label": "‪TSevener (WMF)‬",
                  "tooltip": "",
                  "description": "",
                  "icon": "userAvatar",
                  "prioritized": true
                },
                {
                  "url": "https://en.wikipedia.org/w/index.php?title=User_talk:Tsevener&oldid=prev&diff=1076152880",
                  "label": "View changes",
                  "description": "",
                  "icon": "changes",
                  "prioritized": true
                }
              ],
              "legacyPrimary": {
                "url": "//en.wikipedia.org/wiki/User_talk:Tsevener?markasread=241957574&markasreadwiki=enwiki#Testing_new_topic_with_long_reply.",
                "label": "View message"
              }
            },
            "iconUrl": "/w/extensions/Echo/modules/icons/edit-user-talk-progressive.svg"
          }
        }

@Tsevener Ah, this is a bummer, but I think that the value of a detail page is still really strong.

hi @cmadeo @OTichonova - I'm in the process of populating the data of this screen, and I have a few comments / questions:

1. According to the Figma, some header subtitles say "On English Wikipedia" and some say "From English Wikipedia". Can we stick to one phrasing. Also better yet, can we remove the preposition entirely and just say "English Wikipedia"? I'm reminded of this ticket that caused lots of translation problems with the way the Explore feed does it. We may want to consider removing the preposition from any notifications cells as well.

2. I will make a Google doc of screenshots that I have so far of the various types, but there are some that stick out to me as odd with the header title (Edit milestone, Welcome, successful/failed mentions, user rights change) - can you add a mock on what these should look like? My initial implementation has "From [currently logged-in user]" as the header title which feels odd - but the notifications API indicates this is the user that triggered the notification.

(This is just scratch UI to check the data)

3. When should "Go to Discussion page" from the mocks be used? This sounds like the future type of talk page notifications that we weren't going to support in V1 yet, but correct me if I'm wrong. I can't find the Phab ticket where we discussed that decision.

@cmadeo @OTichonova

Here's a spreadsheet of where I'm at with detail screen data. Let me know if anything seems off as far as data goes. If this is too much to sift through it might be better to have a mock for each notification type for QA to confirm when this gets to that stage.

https://docs.google.com/spreadsheets/d/1ie3haerLDOraj79r-6Rz4AQwMfkGngjSVr2vmCpZwOs/edit?usp=sharing

According to the Figma, some header subtitles say "On English Wikipedia" and some say "From English Wikipedia". Can we stick to one phrasing. Also better yet, can we remove the preposition entirely and just say "English Wikipedia"? I'm reminded of this ticket that caused lots of translation problems with the way the Explore feed does it. We may want to consider removing the preposition from any notifications cells as well.

Totally fine to remove the preposition from here and the notification cells. I updated the Figma for the detail view to start

I will make a Google doc of screenshots that I have so far of the various types, but there are some that stick out to me as odd with the header title (Edit milestone, Welcome, successful/failed mentions, user rights change) - can you add a mock on what these should look like? My initial implementation has "From [currently logged-in user]" as the header title which feels odd - but the notifications API indicates this is the user that triggered the notification.

I'll make some mocks for these.

When should "Go to Discussion page" from the mocks be used? This sounds like the future type of talk page notifications that we weren't going to support in V1 yet, but correct me if I'm wrong. I can't find the Phab ticket where we discussed that decision.

On all of our sister projects (except for WikiNews) talk pages are called 'Discussions' pages, so if possible it would be great to call 'talk pages' discussion pages for non Wikipedia projects. (Wikinews uses the term 'collaboration')

On all of our sister projects (except for WikiNews) talk pages are called 'Discussions' pages, so if possible it would be great to call 'talk pages' discussion pages for non Wikipedia projects. (Wikinews uses the term 'collaboration')

@cmadeo Good to know, thanks! Does this also include user talk pages? For example:

• "Message on your collaboration page" - title label on a list cell of a WikiNews user talk message notification (if we can't extract a topic title)
• "Go to your discussion page" - link on the detail screen of a Wikidata user talk page message notification

@Tsevener strangely, this does not apply to user talk pages on any of these projects, they are all referred to as Talk pages eg:

• "message on your talk page" (for all projects)
• "message on [article/file/etc] discussion page"

Pre-work PR: https://github.com/wikimedia/wikipedia-ios/pull/4158

Part 1 PR: https://github.com/wikimedia/wikipedia-ios/pull/4162

Part 2 PR: https://github.com/wikimedia/wikipedia-ios/pull/4164

Part 3 PR: https://github.com/wikimedia/wikipedia-ios/pull/4166

Hi all, I'm really sorry to come in with a last minute update from Design, but could we bump the 'from' line and the 'subject' line both up to 17pt from 15pt? I'm realizing I wasn't following the correct typography guidelines that Olga and I are developing. These type sizes are updated in Figma.

In T302453#7807466, @cmadeo wrote:

could we bump the 'from' line and the 'subject' line both up to 17pt from 15pt?

Sure thing – I'll make that update.

Thank you @Dmantena !

Two small requested changes based on usability testing:

1. Would it be possible to update the string for all cases of 'Go to user page' (note, not 'Go to your talk page') to display the editor's username (eg. Go to [Editor's username] user page)
2. Would it be possible to truncate the lines in the menu? Currently I'm seeing them overflow and push out the destination. Example of proposed design below:

Please let me know if you'd prefer to have a separate ticket for both or either of these requests.

1. Would it be possible to update the string for all cases of 'Go to user page' (note, not 'Go to your talk page') to display the editor's username (eg. Go to [Editor's username] user page)

@cmadeo Sure thing – it looks like the logic to do so was already implemented.

2. Would it be possible to truncate the lines in the menu? Currently I'm seeing them overflow and push out the destination. Example of proposed design below:

This one is a little bit trickier. Currently, that cell is a just a default, non-custom, Apple UITableViewCell with the value1 configuration. It appears like the behavior of this system configuration (which supports displaying the main text label and the detail text label) automatically removes the detail text label if the main text label overflows. I don't immediately see a quick API supported way to change this behavior. There are definitely a few paths towards solutions, but want to surface that it'd be a Medium amount of work to get to a sustainable solution.

Related: what do you think about dropping the "Go to" text prefix from all these actions? Meaning, "Your talk page" and "Amy's talk page" instead of "Go to your talk page" and "Go to Amy's talk page". This would a) remove that repeated/potentially unneeded text and b) have the added benefit of probably reducing the number of occurrences of #2 without having to create anything custom?

Thanks @Dmantena!

Great idea to drop the 'Go to' prefix! I'd be happy to see that implemented, thank you for the suggestion!

Totally hear you via the truncation issues, one question I have is if it would be possible to avoid a situation where we are showing just a few characters from the link destination (eg. a string like 'bagelpigeons userpage on w')

Also I'm so sorry about the screenshot from my previous comment not exporting correctly, not that it really matters but it should have looked like this:

PR for truncation up at: https://github.com/wikimedia/wikipedia-ios/pull/4185

Totally hear you via the truncation issues, one question I have is if it would be possible to avoid a situation where we are showing just a few characters from the link destination (eg. a string like 'bagelpigeons userpage on w')

Currently, we're relying on Apple's default truncation handling. Specifically, the "tail truncation" option they provide. We could potentially do some custom text truncation, but I'm hesitant to go down this route because I'm not fully aware of challenges we may encounter with languages other than English and we'd also then potentially be displaying incongruent results (like if two rows are displaying truncated text like your screenshot above, the start and end of their tail truncation would be different depending on where the truncation begins).

@cmadeo these tweaks should be in the next TestFlight nightly build (1913).

Wowie! These are looking great! Thank you for the updates!!!

Two more string change requests:

	Is there any way for us to know if a message is on your talk page but not in your primary app language? Currently this says 'Talk page' but it's my talk page on ES Wiki. Not a big deal if this isn't possible, just something I hadn't caught until now.

	1) Similar to the update to include the sender's username in the string for their userpage, could we do the same for their talk page? 2) It looks like Toni's talk page is showing up twice on this list. If it's the primary link is there anyway we can hide it from the secondary links menu?

Phew, okay sorry! The first note from above is not relevant and is a random artifact of me spamming my own talk page too much on ES wiki

@cmadeo All good! Thanks for talking it through with us today.

PR for removing primary action from secondary actions list up at: https://github.com/wikimedia/wikipedia-ios/pull/4193

Looking great! Thanks for all of the excellent updates @Dmantena + @Tsevener !

Looking good on 6.9.0 (1921)