Resizing textarea reduces its width in CodeMirror
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Apr 12 2022, 1:27 PM

Description

What is the problem?

When I have CodeMirror enabled, if I resize the textarea, the width of div.CodeMirror reduces slightly (and the scrollbar moves to the left).

codemirror_resize.png (800×1 px, 143 KB)

I can reproduce on Firefox and Chromium. Only when RTP is not enabled.

Steps to reproduce problem

Edit a page (e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=BeforeEach-name-0.20468147312084506-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n&action=edit)
Turn on the CodeMirror (little pen icon in the menu)
Inspect the .CodeMirror element, record the width (using devtools)
Resize the textarea (with the little thingy in the bottom left)
Inspect the .CodeMirror element again, compare the width with what you recorded at 3

Expected behavior: They should be the same
Observed behavior: They are not

Environment

Browser: Firefox 91, Chromium 87
Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.39.0-alpha (0a0e6e2) 13:17, 12 April 2022.
Editor, if applicable: WikiEditor 0.5.3 (85098ce) 06:15, 12 April 2022. CodeMirror 4.0.0 (758dd2c) 06:13, 12 April 2022.

Details

	Subject	Repo	Branch	Lines +/-
	ext.CodeMirror.js: Keep at 100% parent width	mediawiki/extensions/CodeMirror	master	+3 -2

Customize query in gerrit

Related Objects

Mentioned In: T303767: Ensure that Realtime Preview is compatible with CodeMirror
Mentioned Here: rECMI5061cc122808: ext.CodeMirror.js: Keep at 100% parent width
rEWED9e3664416ffd: Localisation updates from https://translatewiki.net.
rECMI758dd2c86fd2: Localisation updates from https://translatewiki.net.
rEWED85098ce2eda4: Localisation updates from https://translatewiki.net.
rMW0a0e6e2d195b: Merge "Test dynamic configuration logic"

Event Timeline

dom_walden created this task.Apr 12 2022, 1:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2022, 1:27 PM

dom_walden mentioned this in T303767: Ensure that Realtime Preview is compatible with CodeMirror.Apr 12 2022, 2:32 PM

• JMcLeod_WMF moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Apr 25 2022, 2:07 PM

• JMcLeod_WMF set the point value for this task to 3.Apr 27 2022, 11:25 AM

MusikAnimal moved this task from Needs Discussion to Up Next (May 20-June 3) on the Community-Tech board.Apr 27 2022, 11:26 AM

• JMcLeod_WMF moved this task from Up Next (May 20-June 3) to CommTech-Sprint-24 on the Community-Tech board.Apr 27 2022, 11:55 AM

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-24); removed Community-Tech.

Restricted Application edited projects, added Community-Tech; removed Community-Tech (CommTech-Sprint-24). · View Herald TranscriptApr 27 2022, 11:55 AM

• JMcLeod_WMF moved this task from New & TBD Tickets to Up Next (May 20-June 3) on the Community-Tech board.Jun 6 2022, 2:26 PM

• NRodriguez moved this task from Up Next (May 20-June 3) to CommTech-Sprint-27 on the Community-Tech board.Jun 29 2022, 7:24 PM

• NRodriguez edited projects, added Community-Tech (CommTech-Sprint-27); removed Community-Tech.

TheresNoTime claimed this task.Jul 6 2022, 9:36 AM

TheresNoTime moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-27) board.Jul 6 2022, 9:50 AM

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-28); removed Community-Tech (CommTech-Sprint-27).Jul 6 2022, 1:22 PM

• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-28) board.Jul 6 2022, 1:25 PM

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-29); removed Community-Tech (CommTech-Sprint-28).Jul 18 2022, 5:34 PM

• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-29) board.Jul 18 2022, 5:37 PM

• NRodriguez moved this task from Backlog to 🌟Top Priority on the Realtime Preview board.Jul 20 2022, 12:05 PM

TheresNoTime changed the subtype of this task from "Bug Report" to "Task".Aug 1 2022, 8:26 PM

TheresNoTime changed the subtype of this task from "Task" to "Bug Report".

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-30); removed Community-Tech (CommTech-Sprint-29).Aug 2 2022, 3:11 PM

• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-30) board.Aug 2 2022, 3:17 PM

TheresNoTime changed the task status from Open to In Progress.Aug 4 2022, 10:47 AM

Change 820430 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/CodeMirror@master] ext.CodeMirror.js: Keep at 100% parent width

https://gerrit.wikimedia.org/r/820430

gerritbot added a project: Patch-For-Review.Aug 4 2022, 11:55 AM

TheresNoTime changed the task status from In Progress to Open.Aug 4 2022, 11:59 AM

TheresNoTime moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-30) board.

Change 820430 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] ext.CodeMirror.js: Keep at 100% parent width

https://gerrit.wikimedia.org/r/820430

MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-30) board.Aug 12 2022, 12:38 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 12 2022, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 12 2022, 1:29 AM

I cannot reproduce this bug on Firefox, Chromium and Safari.

On Firefox, I tested resizing with and without RTP enabled on all 5 skins and also RTL.

Test environment: https://en.wikipedia.beta.wmflabs.org WikiEditor 0.5.3 (9e36644) 06:52, 11 August 2022. CodeMirror 4.0.0 (5061cc1) 11:54, 4 August 2022.
Test browsers: Firefox 91, Chromium 87, Safari 15.
Skins: Vector 2022, Vector 2010, Minerva, Timeless, MonoBook.