Realtime Preview button shows no indication it is enabled in MonoBook skin
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Apr 12 2022, 2:31 PM

Description

What is the problem?

Preview off:

Preview on:

In other skins, the "Preview" button is blue when it is on.

Steps to reproduce problem

Login to beta and enable Realtime Preview via Special:Preferences beta tab
Go to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Selenium_Echo_mention_test_0.8148390162093141&action=edit&useskin=monobook
Click the "Preview" button

Environment

Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.39.0-alpha (c8c7432) 13:33, 12 April 2022.
Editor, if applicable: WikiEditor 0.5.3 (85098ce) 06:15, 12 April 2022. CodeMirror 4.0.0 (758dd2c) 06:13, 12 April 2022.

Details

	Subject	Repo	Branch	Lines +/-
	Realtime Preview: make button toggle state more visible in MonoBook	mediawiki/extensions/WikiEditor	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned Here: rEWED06cda6ee49dd: Merge "Remove all unused "loading" code, messages and animations"
rECMI758dd2c86fd2: Localisation updates from https://translatewiki.net.
rEWED85098ce2eda4: Localisation updates from https://translatewiki.net.
rMWc8c743203048: Merge "Remove unused i18n message of removed CacheHelper classes"

Event Timeline

dom_walden created this task.Apr 12 2022, 2:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2022, 2:31 PM

Nice catch! I think the solution here (given we don't put much design effort into Monobook) is to mimic what is done for the CodeMirror button. This should be pretty easy to fix.

Change 781062 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/WikiEditor@master] Realtime Preview: make button toggle state more visible in MonoBook

https://gerrit.wikimedia.org/r/781062

gerritbot added a project: Patch-For-Review.Apr 14 2022, 10:39 PM

MusikAnimal edited projects, added Community-Tech (CommTech-Sprint-23); removed Community-Tech.Apr 14 2022, 11:41 PM

MusikAnimal moved this task from Ready 🎬 to Review / Feedback 💬 on the Community-Tech (CommTech-Sprint-23) board.

MusikAnimal set the point value for this task to 2.

Change 781062 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime Preview: make button toggle state more visible in MonoBook

https://gerrit.wikimedia.org/r/781062

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2022, 7:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).Apr 20 2022, 8:00 PM

MusikAnimal moved this task from Review / Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-23) board.Apr 20 2022, 8:39 PM

RTP off:

RTP on:

This looks the same as the CodeMirror button when it is on:

I briefly checked the other skins to make sure the look of the button on and off had not changed.

Test environment: https://en.wikipedia.beta.wmflabs.org WikiEditor 0.5.3 (06cda6e) 16:15, 22 April 2022.

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-24); removed Community-Tech (CommTech-Sprint-23).Apr 25 2022, 4:56 PM

• JMcLeod_WMF moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-24) board.Apr 25 2022, 4:59 PM

Great job

• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-24) board.May 24 2022, 6:25 PM

happy5214 moved this task from Backlog to Closed on the WikiEditor board.Jul 31 2023, 9:57 PM

	F35066748: monobook_on.png
	Apr 25 2022, 8:09 AM

	F35066754: monobook_on_cm.png
	Apr 25 2022, 8:09 AM

	F35066746: monobook_off.png
	Apr 25 2022, 8:09 AM

Realtime Preview button shows no indication it is enabled in MonoBook skinClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions