Page MenuHomePhabricator
Create Task
Maniphest T306904

[ToC] Increase threshold for ToC collapsing to 1000px
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
ovasileva
Apr 26 2022, 2:19 PM
Tags
Referenced Files
F35069327: Screen Recording 2022-04-26 at 6.47.40 PM.mov.gif
Apr 27 2022, 1:50 AM
F35069315: Screen Recording 2022-04-26 at 6.39.21 PM.mov.gif
Apr 27 2022, 1:41 AM
Subscribers
Agusbou2015
Aklapper
• alexhollender_WMF
AlexisJazz
bwang
debt
Edtadros
View All 20 Subscribers
Tokens
"Like" token, awarded by alexhollender_WMF.

Description

Background

A number of users have noticed that the new ToC is tricky to use on narrower screens. While we are currently working on a long-term solution in T306660: [Goal] Table of contents on narrow screens in vector-2022, we would like to implement a short term solution that will improve the experience for people currently using the new ToC

Acceptance criteria

  • Increase threshold for ToC collapsing to 1000px (up from 720px)

QA Results - Beta

ACStatusDetails
1✅T306904#7883087

QA Results - Prod

ACStatusDetails
1✅T306904#7883090

Details

SubjectRepoBranchLines +/-
[ToC] Increase threshold for ToC collapsing to 1000pxmediawiki/skins/Vectorwmf/1.39.0-wmf.8+4 -4
[ToC] Increase threshold for ToC collapsing to 1000pxmediawiki/skins/Vectorwmf/1.39.0-wmf.9+4 -4
[ToC] Increase threshold for ToC collapsing to 1000pxmediawiki/skins/Vectormaster+4 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva triaged this task as High priority.Apr 26 2022, 2:19 PM
ovasileva created this task.
• alexhollender_WMF updated the task description. (Show Details)Apr 26 2022, 2:19 PM
• alexhollender_WMF awarded a token.
• alexhollender_WMF renamed this task from Increase threshold for ToC collapsing to 1000px to [ToC] Increase threshold for ToC collapsing to 1000px .Apr 26 2022, 3:36 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Apr 26 2022, 3:42 PM
gerritbot added a comment.Apr 26 2022, 5:12 PM

Change 786353 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [ToC] Increase threshold for ToC collapsing to 1000px

https://gerrit.wikimedia.org/r/786353

gerritbot added a project: Patch-For-Review.Apr 26 2022, 5:12 PM
LGoto moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.Apr 26 2022, 5:12 PM
LGoto set the point value for this task to 2.
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Apr 26 2022, 5:17 PM
LGoto assigned this task to bwang.Apr 26 2022, 5:21 PM
gerritbot added a comment.Apr 26 2022, 6:02 PM

Change 785942 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.39.0-wmf.8] [ToC] Increase threshold for ToC collapsing to 1000px

https://gerrit.wikimedia.org/r/785942

gerritbot added a comment.Apr 26 2022, 6:03 PM

Change 785943 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.39.0-wmf.9] [ToC] Increase threshold for ToC collapsing to 1000px

https://gerrit.wikimedia.org/r/785943

gerritbot added a comment.Apr 26 2022, 6:04 PM

Change 786353 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [ToC] Increase threshold for ToC collapsing to 1000px

https://gerrit.wikimedia.org/r/786353

Jdlrobson reassigned this task from bwang to Jdrewniak.Apr 26 2022, 6:43 PM
Jdlrobson reassigned this task from Jdrewniak to Edtadros.
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: bwang.
Jdlrobson added a subscriber: Jdrewniak.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).Apr 26 2022, 7:01 PM
gerritbot added a comment.Apr 26 2022, 8:28 PM

Change 785943 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.39.0-wmf.9] [ToC] Increase threshold for ToC collapsing to 1000px

https://gerrit.wikimedia.org/r/785943

gerritbot added a comment.Apr 26 2022, 8:28 PM

Change 785942 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.39.0-wmf.8] [ToC] Increase threshold for ToC collapsing to 1000px

https://gerrit.wikimedia.org/r/785942

Perryprog mentioned this in T306912: Floating ToC "shunts" article text away at large zoom levels.Apr 26 2022, 8:31 PM
Stashbot added a comment.Apr 26 2022, 8:36 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-26T20:36:39Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.8/skins/Vector/resources/skins.vector.styles/: 31ed884d6eda998f8625a88be0f4aa5fd67aef4b: [ToC] Increase threshold for ToC collapsing to 1000px (T306904) (duration: 00m 50s)

Stashbot added a comment.Apr 26 2022, 8:37 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-26T20:37:30Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.9/skins/Vector/resources/skins.vector.styles/: 019a812176bb940383ddeb22f8a74b5d0f447bf1: [ToC] Increase threshold for ToC collapsing to 1000px (T306904) (duration: 00m 50s)

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.8; 2022-04-18); removed MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).Apr 26 2022, 9:00 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Apr 27 2022, 1:41 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Increase threshold for ToC collapsing to 1000px (up from 720px)

Screen Recording 2022-04-26 at 6.39.21 PM.mov.gif (924×1 px, 686 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Apr 27 2022, 1:50 AM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Increase threshold for ToC collapsing to 1000px (up from 720px)

Screen Recording 2022-04-26 at 6.47.40 PM.mov.gif (924×1 px, 470 KB)

Edtadros updated the task description. (Show Details)Apr 27 2022, 1:51 AM
ovasileva mentioned this in T306660: [Goal] Table of contents on narrow screens in vector-2022.Apr 28 2022, 9:00 AM
ovasileva closed this task as Resolved.Apr 28 2022, 10:20 AM

Looks good, resolving

Agusbou2015 subscribed.May 10 2022, 10:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL