Page MenuHomePhabricator

Replace existing Special:NewLexeme page with the new one
Closed, ResolvedPublic5 Estimated Story Points

Description

We want to replace the existing Special:NewLexeme page with the new improved page. After this the existing Special:NewLexeme page will no longer be accessible.

For this to happen we still need:

  • successful user testing with the page in production
  • addressed any major findings from user testing
  • prefilling of input fields (T298154)

Acceptance criteria:

Related Objects

Event Timeline

Backlog refinement note: This probably doesn’t need to be configurable, we can just replace all the code on master and let it roll out with the train.

Backlog refinement note: This probably doesn’t need to be configurable, we can just replace all the code on master and let it roll out with the train.

But to ensure it doesn’t roll back with the train, I suggest that after it’s rolled out to group1, we deploy a backport of the corresponding change to the no-longer-used train. (We should get that approved by the train conductors though, since it disturbs the assumption that the train can roll back to a stable, known-good previous version. I think it should be acceptable in this case, but they should at least be aware of it.)

karapayneWMDE set the point value for this task to 5.Oct 18 2022, 9:53 AM

Current plan: roll this out with the train on Nov. 2nd.

Dragging this into the sprint as discussed so we can get this prepared in time for Nov. 2nd.

Thanks for the reminder. I missed that you added an alternative link there. Thanks! I'll see if that is ok and if we can still switch it in time or if it'll have to go in the next sprint.

This will probably start with moving the PHP files over the old special page, something like:

  • git mv src/MediaWiki/Specials/SpecialNewLexemeAlpha.php src/MediaWiki/Specials/SpecialNewLexeme.php
  • git mv tests/phpunit/mediawiki/Specials/SpecialNewLexemeAlphaTest.php tests/phpunit/mediawiki/Specials/SpecialNewLexemeTest.php

Also:

  • adjust the class names in both of the above files
  • adjust Registrar.php to pass the “alpha” services into SpecialNewLexeme and drop the registration of the “alpha” special page
  • remove the temporary config setting to enable the “alpha” page
  • update any documentation referencing the “alpha” name
  • delete any code and messages that are now unused (e.g. ItemSelectorWidgetField, I think)
  • update browser tests (move newAlpha.js over new.js and newlexemeAlpha.page.js over newlexeme.page.js, similar to the PHP files)
  • probably more I’m forgetting :)

Change 850097 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Make Special:NewLexemeAlpha replace Special:NewLexeme

https://gerrit.wikimedia.org/r/850097

Change 850097 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Make Special:NewLexemeAlpha replace Special:NewLexeme

https://gerrit.wikimedia.org/r/850097

Should be deployed with the train next week (or testable on Beta in the meantime – currently it’s not quite working but I hope that will resolve itself in a few minutes).

Change 890387 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Remove unused $wgLexemeEnableNewAlpha

https://gerrit.wikimedia.org/r/890387

Change 890387 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove unused $wgLexemeEnableNewAlpha

https://gerrit.wikimedia.org/r/890387

Mentioned in SAL (#wikimedia-operations) [2023-02-20T14:12:26Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:890387|Remove unused $wgLexemeEnableNewAlpha (T307866)]]

Mentioned in SAL (#wikimedia-operations) [2023-02-20T14:14:07Z] <samtar@deploy1002> lucaswerkmeister-wmde and samtar: Backport for [[gerrit:890387|Remove unused $wgLexemeEnableNewAlpha (T307866)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-02-20T14:20:11Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:890387|Remove unused $wgLexemeEnableNewAlpha (T307866)]] (duration: 07m 44s)