Page MenuHomePhabricator

css "revert" should mark as Valid value
Closed, ResolvedPublicFeature

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Edit a css page which wgPageContentModel is sanitized-css
  • replace content by follow content:
a {
	display: revert;
	color: revert;
}

What happens?:

  • Invalid or unsupported value for property display at line 2 character 11.
  • Invalid or unsupported value for property color at line 3 character 9.

What should have happened instead?:
mark "revert" as vaild value.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
TemplateStyles v1.0 (a0f32c4)

Event Timeline

SunAfterRain renamed this task from css "revert" should not mark as Invalid or unsupported value to css "revert" should mark as Valid value.May 15 2022, 4:23 AM
Izno added a project: css-sanitizer.
Izno moved this task from Unsorted to W3C Working Draft (or earlier) on the css-sanitizer board.
Izno subscribed.

This should be fixed after https://gerrit.wikimedia.org/r/c/css-sanitizer/+/562681 is in a new release of css sanitizer.

@Izno: Maybe worth a separate ticket to request a v4 release (to be listed on https://gerrit.wikimedia.org/g/css-sanitizer/ )?

@Izno: Maybe worth a separate ticket to request a v4 release (to be listed on https://gerrit.wikimedia.org/g/css-sanitizer/ )?

I haven't made a specific ticket because Reedy noted it at T287972#7806787, where css-sanitizer is listed in the primary description to boot.

Izno changed the subtype of this task from "Bug Report" to "Feature Request".Jan 14 2023, 1:52 AM
Tgr assigned this task to Anomie.
Tgr subscribed.

The changes were included in 4.0, released in 2022 July (rMWVDbd89258378cc: Upgrading wikimedia/css-sanitizer (v3.0.2 => v4.0.0)). The feature now works in production.