Page MenuHomePhabricator
Create Task
Maniphest T309055

Make FeatureManager more robust to process multiple requirements for a feature
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

While working on T300612 we discovered hidden technical complexity and an opportunity to refactor the feature management code. This task is needed to unblock work there.

Background

See T300612#7927452

Description

Allow FeatureManager to process more complex requirements to determine if a feature should be enabled.

Developer notes

  • Create a builder class as a mechanism for taking a list of requirements and generating the corresponding requirement for the FeatureManager to evaluate.
  • Refactor the original Vector hooks method and incorporate its functionality in the new requirements list.
  • Remove/rename shouldDisableMaxWidth() to be used for both its former eponymous feature and for the sticky header feature.
  • Update the original Vector hooks method to use Title:Value instances instead to be able to test method more easily in isolation.

Acceptance criteria

  • Both DisableMaxWidth and sticky header feature should work with the newly refactored FeatureManager
  • All features continue to work with the newly refactored FeatureManager
  • Tests are added/updated for FeatureManager and new builder class

Related Objects
Search...

Event Timeline

cjming created this task.May 23 2022, 9:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2022, 9:24 PM
cjming mentioned this in T300612: Sticky header: sticky header "gap" appearing on diffs of pages with other sticky elements.May 23 2022, 9:25 PM
cjming updated the task description. (Show Details)
Jdlrobson triaged this task as Medium priority.May 24 2022, 3:58 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming updated the task description. (Show Details)May 24 2022, 5:10 PM
Jdlrobson updated the task description. (Show Details)May 25 2022, 4:53 PM
LGoto set the point value for this task to 5.May 25 2022, 4:53 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
ovasileva added a project: Desktop Improvements (Vector 2022).May 31 2022, 3:14 PM
ovasileva added a parent task: T300612: Sticky header: sticky header "gap" appearing on diffs of pages with other sticky elements.
ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-FY-2021-22).May 31 2022, 5:54 PM
Jdlrobson moved this task from Incoming to Needs Prioritization (Tech) on the Web-Team-Backlog board.Jun 1 2022, 9:09 PM
Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog.
Jdlrobson moved this task from Incoming to Page Tools on the Desktop Improvements (Vector 2022) board.Jun 2 2022, 6:09 PM
Jdlrobson moved this task from Backlog to Vector code cleanup on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jun 6 2022, 7:27 PM
Jdlrobson moved this task from Vector code cleanup to Tracking Indefinitely on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Mar 21 2023, 6:03 PM
Jdlrobson claimed this task.Mar 27 2023, 9:01 PM
Jdlrobson moved this task from Tracking Indefinitely to Backlog on the Web-Team-Backlog (Needs Prioritization (Tech)) board.
Jdlrobson subscribed.

I think this one might be done. Will check.

Jdlrobson closed this task as Resolved.Mar 27 2023, 10:07 PM

Checked in with the team and there seems agreement that this is done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL