Page MenuHomePhabricator
Create Task
Maniphest T309683

Turn off table of contents A/B test
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Background

We are currently testing the table of contents across our pilot wikis. We would like to turn off this test once we have two weeks of data

Acceptance criteria

  • Turn off table of contents a/b test on Jun 9 (Remove VectorWebABTestEnrollment definition leaving the disabled sticky header definition for "default")
  • Table of contents should be enabled for 100% of users. (wgVectorTableOfContents set to true for all users)
  • Update master of Vector to reflect default configuration of desktop improvements.

Sign off steps

  • Make sure a task exists for removing the wgVectorTableOfContents feature flag (but preserving the A/B test code) >> T310527

Details

SubjectRepoBranchLines +/-
Turn off TOC A/B test for pilot wikisoperations/mediawiki-configmaster+3 -36
Match default config of TOC to pilot wikismediawiki/skins/Vectormaster+1 -1
Disable TOC A/B test for beta clusteroperations/mediawiki-configmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva created this task.Jun 1 2022, 7:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2022, 7:39 AM
ovasileva triaged this task as Medium priority.Jun 1 2022, 7:40 AM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 1 2022, 8:54 PM
Jdlrobson updated the task description. (Show Details)Jun 1 2022, 9:01 PM
Jdlrobson mentioned this in T309632: ToC disappearing at narrow widths during A/B test run.
LGoto moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.Jun 2 2022, 5:15 PM
Jdlrobson updated the task description. (Show Details)Jun 2 2022, 5:20 PM
LGoto set the point value for this task to 2.Jun 2 2022, 5:21 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
ovasileva updated the task description. (Show Details)Jun 2 2022, 5:22 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 3 2022, 3:57 PM
bwang moved this task from Doing to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming claimed this task.Jun 10 2022, 5:28 PM
cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

I'll take care of this on Monday 6/13

gerritbot added a comment.Jun 13 2022, 3:59 PM

Change 805179 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/mediawiki-config@master] Turn off TOC A/B test for pilot wikis

https://gerrit.wikimedia.org/r/805179

gerritbot added a project: Patch-For-Review.Jun 13 2022, 3:59 PM
cjming removed cjming as the assignee of this task.Jun 13 2022, 3:59 PM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming subscribed.
cjming claimed this task.Jun 13 2022, 4:18 PM
cjming moved this task from Code Review to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jun 13 2022, 4:50 PM

Change 805201 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Match default config of TOC to pilot wikis

https://gerrit.wikimedia.org/r/805201

cjming added a comment.Jun 13 2022, 4:52 PM

hi @ovasileva re: 1st AC:

Remove VectorWebABTestEnrollment definition leaving the disabled sticky header definition for "default"

does this mean leaving the disabled TOC A/B test for default?

cjming removed cjming as the assignee of this task.Jun 13 2022, 4:59 PM
cjming mentioned this in T310527: Remove Table of Contents feature flag.
cjming updated the task description. (Show Details)
cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jun 13 2022, 5:15 PM

Change 805206 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/mediawiki-config@master] Disable TOC A/B test for beta cluster

https://gerrit.wikimedia.org/r/805206

cjming added a comment.EditedJun 13 2022, 5:16 PM

Per planning today:

  • We are turning off TOC A/B test for beta cluster today.
  • Turning off TOC A/B test for production on Thursday 6/16.
Jdlrobson assigned this task to cjming.Jun 13 2022, 5:35 PM
gerritbot added a comment.Jun 13 2022, 8:23 PM

Change 805206 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable TOC A/B test for beta cluster

https://gerrit.wikimedia.org/r/805206

Stashbot added a comment.Jun 13 2022, 8:27 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-13T20:27:35Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:805206|Disable TOC A/B test for beta cluster (T309683)]] (duration: 03m 29s)

cjming moved this task from Code Review to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 13 2022, 10:10 PM
cjming removed cjming as the assignee of this task.Jun 14 2022, 4:28 PM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 14 2022, 5:07 PM
cjming claimed this task.Jun 14 2022, 5:08 PM
gerritbot added a comment.Jun 14 2022, 5:23 PM

Change 805201 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Match default config of TOC to pilot wikis

https://gerrit.wikimedia.org/r/805201

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 14 2022, 6:00 PM
cjming moved this task from Blocked on Others to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 16 2022, 2:14 AM
Jdlrobson removed cjming as the assignee of this task.Jun 16 2022, 5:10 PM
Jdlrobson assigned this task to cjming.
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jun 16 2022, 8:06 PM

Change 805179 merged by jenkins-bot:

[operations/mediawiki-config@master] Turn off TOC A/B test for pilot wikis

https://gerrit.wikimedia.org/r/805179

Stashbot added a comment.Jun 16 2022, 8:12 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-16T20:12:14Z] <cjming@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:805179|Turn off TOC A/B test for pilot wikis (T309683)]] (duration: 03m 37s)

Maintenance_bot removed a project: Patch-For-Review.Jun 16 2022, 8:30 PM
cjming removed cjming as the assignee of this task.Jun 16 2022, 9:57 PM
cjming moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming added a subscriber: jwang.Jun 21 2022, 5:06 PM

hi @jwang - just fyi, the test has been disabled since last Thursday 6/16 -- so analysis can start whenever you're ready

ovasileva closed this task as Resolved.Jun 27 2022, 10:25 AM
ovasileva claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL