Page MenuHomePhabricator

Refactor collapsed TOC solution to use grid when supported
Closed, ResolvedPublic3 Estimated Story Points

Description

Refactor the CSS-only solution for collapsed TOC once grid is merged. We want to maintain the existing absolute positioning based solution for grade C browsers

Acceptance criteria

  • TOC can collapse into the page title on using grid
  • TOC at narrow screens on grade C browers is usable
  • no UI regressions

Developer notes

Although the current solution works with grid enabled, we want to update the CSS to work on larger screen sizes using grid, in order to unblock follow up work (T307901)

Event Timeline

ovasileva raised the priority of this task from Medium to High.Jul 1 2022, 1:50 PM

Change 812371 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Update CSS to allow TOC to be collapsed at any viewport by adding .vector-toc-collapsed class

https://gerrit.wikimedia.org/r/812371

bwang renamed this task from Refactor TOC at narrow screens css-only solution post-grid to Refactor collapsed TOC solution to use.Jul 8 2022, 4:16 PM
bwang renamed this task from Refactor collapsed TOC solution to use to Refactor collapsed TOC solution to use grid.
bwang updated the task description. (Show Details)

Originally this task was written to refactor the narrow screens TOC to use the grid, but since the grid is now disabled on lower screens for browsers that don't support CSS grid, this task was updated to only encompass updating the CSS to use the grid for collapsed TOC, essentially the prework to T307901.

This was simpler than expected, POC patch here: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/812371

bwang renamed this task from Refactor collapsed TOC solution to use grid to Refactor collapsed TOC solution to use grid when supported.Jul 18 2022, 4:28 PM
bwang updated the task description. (Show Details)

From our discussion from SHDT today, we clarified that we can still use the grid for the collapsed TOC implementation so long as we maintain the existing implementation for grade c browsers.

Jdlrobson lowered the priority of this task from High to Medium.Jul 19 2022, 5:09 PM
ovasileva raised the priority of this task from Medium to High.Jul 21 2022, 5:15 PM
bwang removed bwang as the assignee of this task.Jul 22 2022, 4:46 PM
cjming moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

Change 812371 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update CSS to allow TOC to be collapsed at larger viewports using grid

https://gerrit.wikimedia.org/r/812371

cjming reassigned this task from cjming to bwang.

lgtm - nice succinct work @bwang!