Page MenuHomePhabricator
Create Task
Maniphest T312379

Migrate usage of Database::select to SelectQueryBuilder in Cognate
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Details

SubjectRepoBranchLines +/-
Use SelectQueryBuilder in RecalculateCognateNormalizedHashesmediawiki/extensions/Cognatemaster+14 -16
Add RecalculateCognateNormalizedHashesIntegrationTestmediawiki/extensions/Cognatemaster+83 -0
Use SelectQueryBuilder in PurgeDeletedCognatePagesmediawiki/extensions/Cognatemaster+24 -28
Fix maintenance/purgeDeletedCognatePages, add testsmediawiki/extensions/Cognatemaster+100 -0
Use SelectQueryBuilder in populateCognatePagesmediawiki/extensions/Cognatemaster+19 -10
Add PopulateCognatePagesIntegrationTestmediawiki/extensions/Cognatemaster+72 -0
Use SelectQueryBuilder in CognateStoremediawiki/extensions/Cognatemaster+25 -34
Add tests for CognateStore::selectSitesForPagemediawiki/extensions/Cognatemaster+19 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Maintenance_bot created this task.Jul 7 2022, 6:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 6:27 AM
Ladsgroup added a project: Cognate.Jul 7 2022, 7:22 AM
Lydia_Pintscher added projects: wmde-wikidata-tech, Wikidata.Jul 7 2022, 7:25 PM
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptJul 7 2022, 7:25 PM
Maintenance_bot moved this task from Inbox to Sorted Team A on the [DEPRECATED] wdwb-tech board.Jul 7 2022, 7:29 PM
ItamarWMDE subscribed.Jan 31 2023, 2:42 PM

Prio Notes:

  • Does not affect end users / production
  • Does affect development efforts
  • Might affect onboarding efforts
  • Does not affect additional stakeholders
ItamarWMDE moved this task from Incoming to [DOT] Prioritized on the wmde-wikidata-tech board.Jan 31 2023, 2:43 PM
ItamarWMDE added a project: Wikidata Dev Team.
ItamarWMDE moved this task from Incoming to [DOT] Tech Backlog on the Wikidata Dev Team board.Jan 31 2023, 3:05 PM
karapayneWMDE moved this task from [DOT] Tech Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Feb 1 2023, 10:38 AM
hoo claimed this task.Feb 2 2023, 9:17 AM
hoo moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.
hoo edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
hoo moved this task from Parents/Waiting to Doing on the Wikidata Dev Team (Sprint-∞) board.
hoo set the point value for this task to 5.
ItamarWMDE moved this task from [DOT] Prioritized to Ongoing on the wmde-wikidata-tech board.Feb 6 2023, 9:33 AM
gerritbot added a comment.Feb 11 2023, 10:34 PM

Change 888299 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@master] Add tests for CognateStore::selectSitesForPage

https://gerrit.wikimedia.org/r/888299

gerritbot added a project: Patch-For-Review.Feb 11 2023, 10:34 PM

Change 888300 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@master] Use SelectQueryBuilder in CognateStore

https://gerrit.wikimedia.org/r/888300

gerritbot added a comment.Feb 11 2023, 10:34 PM

Change 888301 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@master] Add PopulateCognatePagesIntegrationTest

https://gerrit.wikimedia.org/r/888301

gerritbot added a comment.Feb 11 2023, 10:34 PM

Change 888302 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@master] Use SelectQueryBuilder in populateCognatePages

https://gerrit.wikimedia.org/r/888302

gerritbot added a comment.Feb 11 2023, 11:35 PM

Change 888305 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@master] Fix maintenance/purgeDeletedCognatePages, add tests

https://gerrit.wikimedia.org/r/888305

gerritbot added a comment.Feb 12 2023, 4:57 PM

Change 888299 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Add tests for CognateStore::selectSitesForPage

https://gerrit.wikimedia.org/r/888299

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 12 2023, 5:00 PM
gerritbot added a comment.Feb 13 2023, 10:13 AM

Change 888300 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Use SelectQueryBuilder in CognateStore

https://gerrit.wikimedia.org/r/888300

gerritbot added a comment.Feb 13 2023, 10:13 AM

Change 888301 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Add PopulateCognatePagesIntegrationTest

https://gerrit.wikimedia.org/r/888301

gerritbot added a comment.Feb 13 2023, 10:15 AM

Change 888302 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Use SelectQueryBuilder in populateCognatePages

https://gerrit.wikimedia.org/r/888302

gerritbot added a comment.Feb 13 2023, 10:19 AM

Change 888305 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Fix maintenance/purgeDeletedCognatePages, add tests

https://gerrit.wikimedia.org/r/888305

Lucas_Werkmeister_WMDE subscribed.Feb 13 2023, 10:26 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 13 2023, 10:30 AM
gerritbot added a comment.Feb 13 2023, 11:55 AM

Change 888666 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@master] Use SelectQueryBuilder in PurgeDeletedCognatePages

https://gerrit.wikimedia.org/r/888666

gerritbot added a project: Patch-For-Review.Feb 13 2023, 11:55 AM
gerritbot added a comment.Feb 13 2023, 12:15 PM

Change 888676 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@master] Add RecalculateCognateNormalizedHashesIntegrationTest

https://gerrit.wikimedia.org/r/888676

gerritbot added a comment.Feb 13 2023, 12:15 PM

Change 888677 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Cognate@master] Use SelectQueryBuilder in RecalculateCognateNormalizedHashes

https://gerrit.wikimedia.org/r/888677

hoo moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Feb 13 2023, 12:19 PM
gerritbot added a comment.Feb 13 2023, 1:11 PM

Change 888666 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Use SelectQueryBuilder in PurgeDeletedCognatePages

https://gerrit.wikimedia.org/r/888666

gerritbot added a comment.Feb 13 2023, 2:56 PM

Change 888676 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Add RecalculateCognateNormalizedHashesIntegrationTest

https://gerrit.wikimedia.org/r/888676

gerritbot added a comment.Feb 13 2023, 2:56 PM

Change 888677 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Use SelectQueryBuilder in RecalculateCognateNormalizedHashes

https://gerrit.wikimedia.org/r/888677

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2023, 3:31 PM
hoo moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.Feb 13 2023, 4:34 PM
hoo moved this task from Product Verification to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.Feb 20 2023, 3:40 PM
ItamarWMDE closed this task as Resolved.Feb 21 2023, 1:47 PM
ItamarWMDE moved this task from Tech Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.

Sweet! All migrated: https://codesearch.wmcloud.org/extensions/?q=-%3Eselect%5C(&i=nope&files=&excludeFiles=&repos=Extension:Cognate \o/

karapayneWMDE moved this task from Our work done to 2023 completed tasks on the Wikidata Dev Team (Sprint-∞) board.May 12 2023, 7:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL