Page MenuHomePhabricator

Migrate usage of Database::select to SelectQueryBuilder in CategoryTree
Closed, ResolvedPublic

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Event Timeline

Change #1024467 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CategoryTree@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1024467

Change #1024467 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1024467