Page MenuHomePhabricator

Migrate usage of Database::select to SelectQueryBuilder in Flow
Closed, ResolvedPublic

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Event Timeline

Change #1025446 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@master] maintenance: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1025446

Change #1025446 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] maintenance: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1025446

Change #1026106 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026106

Change #1026106 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026106

Umherirrender claimed this task.
Umherirrender removed a project: Patch-For-Review.

Change #1029560 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Flow@master] Revert "Migrate to IReadableDatabase::newSelectQueryBuilder"

https://gerrit.wikimedia.org/r/1029560

Change #1029562 had a related patch set uploaded (by Zabe; author: Bartosz Dziewoński):

[mediawiki/extensions/Flow@wmf/1.43.0-wmf.4] Revert "Migrate to IReadableDatabase::newSelectQueryBuilder"

https://gerrit.wikimedia.org/r/1029562

Change #1029562 merged by jenkins-bot:

[mediawiki/extensions/Flow@wmf/1.43.0-wmf.4] Revert "Migrate to IReadableDatabase::newSelectQueryBuilder"

https://gerrit.wikimedia.org/r/1029562

Change #1029560 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Revert "Migrate to IReadableDatabase::newSelectQueryBuilder"

https://gerrit.wikimedia.org/r/1029560

Mentioned in SAL (#wikimedia-operations) [2024-05-09T19:42:03Z] <jhuneidi@deploy1002> Started scap: Backport for [[gerrit:1029562|Revert "Migrate to IReadableDatabase::newSelectQueryBuilder" (T312418 T364499)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-09T19:44:43Z] <jhuneidi@deploy1002> jhuneidi and zabe: Backport for [[gerrit:1029562|Revert "Migrate to IReadableDatabase::newSelectQueryBuilder" (T312418 T364499)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-09T19:59:41Z] <jhuneidi@deploy1002> Finished scap: Backport for [[gerrit:1029562|Revert "Migrate to IReadableDatabase::newSelectQueryBuilder" (T312418 T364499)]] (duration: 17m 37s)

Change #1030974 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Flow@master] Revert "Revert "Migrate to IReadableDatabase::newSelectQueryBuilder""

https://gerrit.wikimedia.org/r/1030974

Change #1030974 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Migrate to IReadableDatabase::newSelectQueryBuilder (second attempt)

https://gerrit.wikimedia.org/r/1030974