Migrate usage of Database::select to SelectQueryBuilder in ShortUrl
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Maintenance_bot
	Jul 7 2022, 6:28 AM

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

	Subject	Repo	Branch	Lines +/-
	Migrate callers of Database::select() ,Database::selectField() and Database::selectRow() to SelectQueryBuilder	mediawiki/extensions/ShortUrl	master	+33 -34

		Status	Subtype	Assigned	Task
		Resolved		None	T311866 Migrate Database::select usages to SelectQueryBuilder (in WMF-deployed extensions)
		Resolved		BluDoge	T312445 Migrate usage of Database::select to SelectQueryBuilder in ShortUrl

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 6:28 AM

Hello,
I will be working on this ticket if possible.
Thanks

Change 985378 had a related patch set uploaded (by Mehdi Zidani; author: Mehdi Zidani):

[mediawiki/extensions/ShortUrl@master] Migrate callers of Database::select() ,Database::selectField() and Database::selectRow() to SelectQueryBuilder

Change 985378 merged by jenkins-bot:

[mediawiki/extensions/ShortUrl@master] Migrate callers of Database::select() ,Database::selectField() and Database::selectRow() to SelectQueryBuilder