Page MenuHomePhabricator

Migrate usage of Database::select to SelectQueryBuilder in Wikibase
Closed, ResolvedPublic

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/Wikibasemaster+33 -34
mediawiki/extensions/Wikibasemaster+34 -24
mediawiki/extensions/Wikibasemaster+224 -268
mediawiki/extensions/Wikibasemaster+21 -33
mediawiki/extensions/Wikibasemaster+19 -25
mediawiki/extensions/Wikibasemaster+112 -139
mediawiki/extensions/Wikibasemaster+143 -121
mediawiki/extensions/Wikibasemaster+17 -28
mediawiki/extensions/Wikibasemaster+10 -12
mediawiki/extensions/Wikibasemaster+14 -15
mediawiki/extensions/Wikibasemaster+39 -72
mediawiki/extensions/Wikibasemaster+26 -31
mediawiki/extensions/Wikibasemaster+17 -20
mediawiki/extensions/Wikibasemaster+17 -15
mediawiki/extensions/Wikibasemaster+5 -11
mediawiki/extensions/Wikibasemaster+31 -37
mediawiki/extensions/Wikibasemaster+15 -21
mediawiki/extensions/Wikibasemaster+27 -14
mediawiki/extensions/Wikibasemaster+9 -14
mediawiki/extensions/Wikibasemaster+18 -27
mediawiki/extensions/Wikibasemaster+12 -14
mediawiki/extensions/Wikibasemaster+8 -12
mediawiki/extensions/Wikibasemaster+15 -15
mediawiki/extensions/Wikibasemaster+81 -64
mediawiki/extensions/Wikibasemaster+8 -14
mediawiki/extensions/Wikibasemaster+26 -35
mediawiki/extensions/Wikibasemaster+35 -55
mediawiki/extensions/Wikibasemaster+18 -10
Show related patches Customize query in gerrit

Event Timeline

Change 829826 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in WikibasePingback

https://gerrit.wikimedia.org/r/829826

Change 829827 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in SqlEntityIdPager

https://gerrit.wikimedia.org/r/829827

Change 829826 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in WikibasePingback

https://gerrit.wikimedia.org/r/829826

Change 830154 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in DatabaseMatchingTermsLookup

https://gerrit.wikimedia.org/r/830154

Change 829827 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in SqlEntityIdPager

https://gerrit.wikimedia.org/r/829827

Change 830198 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in ReplicaMasterAwareRecordIdsAcquirer

https://gerrit.wikimedia.org/r/830198

Change 830154 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in DatabaseMatchingTermsLookup

https://gerrit.wikimedia.org/r/830154

Change 830198 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in ReplicaMasterAwareRecordIdsAcquirer

https://gerrit.wikimedia.org/r/830198

Change 855049 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in EntityChangeLookup

https://gerrit.wikimedia.org/r/855049

Change 855049 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in EntityChangeLookup

https://gerrit.wikimedia.org/r/855049

Change 855585 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in RecentChangesFinder

https://gerrit.wikimedia.org/r/855585

Change 855613 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in SqlSiteLinkConflictLookup

https://gerrit.wikimedia.org/r/855613

Change 855646 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in ChangesSubscriptionTableBuilder

https://gerrit.wikimedia.org/r/855646

Change 855656 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in PropertyInfoTableBuilder

https://gerrit.wikimedia.org/r/855656

Change 855585 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder for recentchanges queries

https://gerrit.wikimedia.org/r/855585

Change 855613 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in SqlSiteLinkConflictLookup

https://gerrit.wikimedia.org/r/855613

Change 855646 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in ChangesSubscriptionTableBuilder

https://gerrit.wikimedia.org/r/855646

Change 855656 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in PropertyInfoTableBuilder

https://gerrit.wikimedia.org/r/855656

Change 860919 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in WikiPageEntityRedirectLookup

https://gerrit.wikimedia.org/r/860919

Change 860920 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in WikiPageEntityStore

https://gerrit.wikimedia.org/r/860920

Change 860921 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in BulkSubscriptionUpdater

https://gerrit.wikimedia.org/r/860921

Change 860919 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in WikiPageEntityRedirectLookup

https://gerrit.wikimedia.org/r/860919

Change 860920 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in WikiPageEntityStore

https://gerrit.wikimedia.org/r/860920

Change 860921 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in BulkSubscriptionUpdater

https://gerrit.wikimedia.org/r/860921

Change 867669 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in pruneItemsPerSite.php and test

https://gerrit.wikimedia.org/r/867669

Change 867677 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in SqlSubscriptionLookup

https://gerrit.wikimedia.org/r/867677

Change 867669 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in pruneItemsPerSite.php and test

https://gerrit.wikimedia.org/r/867669

Change 867677 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in SqlSubscriptionLookup

https://gerrit.wikimedia.org/r/867677

Change 875974 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in WikiPageEntityRedirectLookup

https://gerrit.wikimedia.org/r/875974

Change 875975 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder for wb_id_counters queries

https://gerrit.wikimedia.org/r/875975

Change 875974 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in WikiPageEntityRedirectLookup

https://gerrit.wikimedia.org/r/875974

Change 875975 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder for wb_id_counters queries

https://gerrit.wikimedia.org/r/875975

Change 885380 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in EntityUsageTable

https://gerrit.wikimedia.org/r/885380

Change 885380 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in EntityUsageTable

https://gerrit.wikimedia.org/r/885380

Change 924512 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in UnexpectedUnconnectedPagePrimer

https://gerrit.wikimedia.org/r/924512

Change 924521 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in SqlSubscriptionManager

https://gerrit.wikimedia.org/r/924521

Change 924522 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in BulkSubscriptionUpdater

https://gerrit.wikimedia.org/r/924522

Change 924523 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in EntityUsageTableBuilder

https://gerrit.wikimedia.org/r/924523

Change 924512 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in UnexpectedUnconnectedPagePrimer

https://gerrit.wikimedia.org/r/924512

Change 924521 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in SqlSubscriptionManager

https://gerrit.wikimedia.org/r/924521

Change 924522 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in BulkSubscriptionUpdater

https://gerrit.wikimedia.org/r/924522

Change 924523 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in EntityUsageTableBuilder

https://gerrit.wikimedia.org/r/924523

Change 926480 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in tests

https://gerrit.wikimedia.org/r/926480

Change 926480 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in tests

https://gerrit.wikimedia.org/r/926480

Change 927230 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in SQL term store

https://gerrit.wikimedia.org/r/927230

Change 927234 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in two repo classes

https://gerrit.wikimedia.org/r/927234

Change 927230 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in SQL terms store

https://gerrit.wikimedia.org/r/927230

Change 927234 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in two repo classes

https://gerrit.wikimedia.org/r/927234

Change 927618 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in DatabaseTermsCollisionDetector

https://gerrit.wikimedia.org/r/927618

Change 928107 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in DatabaseTermInLangIdsResolver

https://gerrit.wikimedia.org/r/928107

Change 928107 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in DatabaseTermInLangIdsResolver

https://gerrit.wikimedia.org/r/928107

Change 927618 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in DatabaseTermsCollisionDetector

https://gerrit.wikimedia.org/r/927618

Change 928597 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Reduce JOIN support in PageTableEntityQuery

https://gerrit.wikimedia.org/r/928597

Change 928598 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in PageTableEntityQueryBase

https://gerrit.wikimedia.org/r/928598

Change 928597 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Reduce JOIN support in PageTableEntityQuery

https://gerrit.wikimedia.org/r/928597

Change 928598 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use SelectQueryBuilder in PageTableEntityQueryBase

https://gerrit.wikimedia.org/r/928598

Lucas_Werkmeister_WMDE claimed this task.

DONE. No converted calls to ->select left (only one test usage in WikiPageEntityMetaDataLookupTest::getLaggedDatabase(), where ->select() is mocked based on the real ->select()).