Page MenuHomePhabricator

Print shows ToC button for Vector 2022
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Print an article on en.wikipedia with Vector-2022 enabled

What happens?:
A checkbox and the ToC button are displayed in print

What should have happened instead?:
The checkbox and ToC button should have been hidden, as they are interactive elements that cannot be used in print and are not expected by the print stylesheet

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
The elements in question are: .mw-checkbox-hack-checkbox #vector-toc-collapsed-button

Screenshot 2022-07-19 at 13.04.12.png (212×392 px, 20 KB)

Developer notes

Straightforward to hide the checkbox + TOC button/icon on print.less

QA Results - Beta

ACStatusDetails
1T313298#8135578

QA Results - Prod

ACStatusDetails
1T313298#8135589

Event Timeline

Change 817321 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Hide TOC button on print

https://gerrit.wikimedia.org/r/817321

cjming updated the task description. (Show Details)
cjming subscribed.

Change 817321 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Hide TOC button on print

https://gerrit.wikimedia.org/r/817321

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The checkbox and ToC button should have been hidden, as they are interactive elements that cannot be used in print and are not expected by the print stylesheet

Screen Shot 2022-08-06 at 4.13.23 PM.png (718×1 px, 474 KB)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The checkbox and ToC button should have been hidden, as they are interactive elements that cannot be used in print and are not expected by the print stylesheet

Screen Shot 2022-08-06 at 4.28.53 PM.png (822×1 px, 582 KB)