Page MenuHomePhabricator

Update globes in Wikibase.default.php
Closed, ResolvedPublic2 Estimated Story Points

Description

There is a list of globes defined at:
https://github.com/wikimedia/Wikibase/blob/master/repo/config/Wikibase.default.php#L208

It would be good to add at least a couple more, namely Ceres = Q596, and Charon = Q6604. A Wikidata query would also find more globes that could be added.

Event Timeline

We can add more yes. Can we get the list of Items we want to add?

We can add more yes. Can we get the list of Items we want to add?

That sounds like something that needs a query ... so have asked at https://www.wikidata.org/wiki/Wikidata:Request_a_query#Globes_we_might_want_to_have_coordinates_on !

OK, going through all uses of globe in P625, and uses of P376 (per https://www.wikidata.org/w/index.php?title=Wikidata:Request_a_query&oldid=1700293636#Globes_we_might_want_to_have_coordinates_on). Also, ignoring fictional items such as Q1005907 (Earth depicted in Star Trek), Q5807471 (dinosaur land), I think we need to add: Q596, Q16711, Q107556, Q158244, Q3030, Q6604, Q149012, Q150249, Q510728, Q1385178, Q11558, Q16081, Q16765, Q844672, Q149374, Q319, Q193, Q17754, Q3257, Q15662, Q17751, Q324. Here's a drop-in code replacement that does this (re-ordering by current use and adding more on the end, let me know if you want me to git push this):

		'http://www.wikidata.org/entity/Q2' => 'earth',
		'http://www.wikidata.org/entity/Q405' => 'moon',
		'http://www.wikidata.org/entity/Q111' => 'mars',
		'http://www.wikidata.org/entity/Q313' => 'venus',
		'http://www.wikidata.org/entity/Q308' => 'mercury',
		'http://www.wikidata.org/entity/Q2565' => 'titan',
		'http://www.wikidata.org/entity/Q596' => 'ceres',
		'http://www.wikidata.org/entity/Q339' => 'pluto',
		'http://www.wikidata.org/entity/Q3123' => 'io',
		'http://www.wikidata.org/entity/Q3359' => 'triton',
		'http://www.wikidata.org/entity/Q16711' => 'eros',
		'http://www.wikidata.org/entity/Q107556' => 'lutetia',
		'http://www.wikidata.org/entity/Q158244' => 'gaspra',
		'http://www.wikidata.org/entity/Q3169' => 'ganymede',
		'http://www.wikidata.org/entity/Q3322' => 'titania',
		'http://www.wikidata.org/entity/Q3143' => 'europa',
		'http://www.wikidata.org/entity/Q3030' => 'vesta',
		'http://www.wikidata.org/entity/Q3303' => 'enceladus',
		'http://www.wikidata.org/entity/Q6604' => 'charon',
		'http://www.wikidata.org/entity/Q3134' => 'callisto',
		'http://www.wikidata.org/entity/Q17958' => 'iapetus',
		'http://www.wikidata.org/entity/Q15040' => 'dione',
		'http://www.wikidata.org/entity/Q15047' => 'tethys',
		'http://www.wikidata.org/entity/Q3352' => 'miranda',
		'http://www.wikidata.org/entity/Q3338' => 'umbriel',
		'http://www.wikidata.org/entity/Q7547' => 'phobos',
		'http://www.wikidata.org/entity/Q15034' => 'mimas',
		'http://www.wikidata.org/entity/Q15050' => 'rhea',
		'http://www.wikidata.org/entity/Q7548' => 'deimos',
		'http://www.wikidata.org/entity/Q149012' => 'ida',
		'http://www.wikidata.org/entity/Q150249' => 'steins',
		'http://www.wikidata.org/entity/Q510728' => 'ida i dactyl',
		'http://www.wikidata.org/entity/Q1385178' => 'ryugu',
		'http://www.wikidata.org/entity/Q3332' => 'oberon',
		'http://www.wikidata.org/entity/Q3343' => 'ariel',
		'http://www.wikidata.org/entity/Q11558' => 'bennu',
		'http://www.wikidata.org/entity/Q15037' => 'hyperion',
		'http://www.wikidata.org/entity/Q16081' => 'proteus',
		'http://www.wikidata.org/entity/Q16765' => 'thebe',
		'http://www.wikidata.org/entity/Q17975' => 'phoebe',
		'http://www.wikidata.org/entity/Q149417' => 'mathilde',
		'http://www.wikidata.org/entity/Q844672' => 'churyumov',
		'http://www.wikidata.org/entity/Q149374' => 'itokawa',
		'http://www.wikidata.org/entity/Q319' => 'jupiter',
		'http://www.wikidata.org/entity/Q193' => 'saturn',
		'http://www.wikidata.org/entity/Q17754' => 'janus',
		'http://www.wikidata.org/entity/Q3257' => 'amalthea',
		'http://www.wikidata.org/entity/Q15662' => 'puck',
		'http://www.wikidata.org/entity/Q17751' => 'epimetheus',
		'http://www.wikidata.org/entity/Q324' => 'uranus'

Perfect! Thank you, Mike.
Yes if you want to push it go for it.

Ah, pull request posted at https://github.com/wikimedia/Wikibase/pull/235 - but it's saying it should be on gerrit instead. No idea how to do that (or time to find out...)!

No worries. It's a good task to get someone new on the team started.

Change 828116 had a related patch set uploaded (by WelpThatWorked; author: Mike Peel):

[mediawiki/extensions/Wikibase@master] Add to globe list

https://gerrit.wikimedia.org/r/828116

I added a review comment on Gerrit – I think this needs a corresponding patch in the GeoData extension, and I’m not sure who could review that (maybe @MaxSem?).

Change 828116 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add additional celestial bodies to globe list

https://gerrit.wikimedia.org/r/828116