"What code would need to be added to EditNoticesOnMobile.js suppress the upstream mobile edit notice implementation should volunteers at en.wiki to do this?"

There are some words missing in this line, I think. I'm not sure what you mean.

In T316177#8187214, @AlexisJazz wrote:

"What code would need to be added to EditNoticesOnMobile.js suppress the upstream mobile edit notice implementation should volunteers at en.wiki to do this?"

There are some words missing in this line, I think. I'm not sure what you mean.

Eeek, you're right. That language was confusing – thank you for saying something, @AlexisJazz. Does this revised language make more sense to you?

1. What code would need to be added to EditNoticesOnMobile.js in order to suppress the upstream mobile edit notice implementation, should volunteers at en.wiki prefer for people to see the mobile edit notices EditNoticesOnMobile.js make available?

Right. How about the other way around? Have your solution read mw.user.options.get('gadget-EditNoticesOnMobile') and disable itself? (only works if/when/where EditNoticesOnMobile is available as a gadget though)

In T316177#8187467, @AlexisJazz wrote:

Right. How about the other way around? Have your solution read mw.user.options.get('gadget-EditNoticesOnMobile') and disable itself? (only works if/when/where EditNoticesOnMobile is available as a gadget though)

We'll look into whether doing the above is possible.

In the meantime, I've added this as an open question to the task description.

How about the other way around? Have your solution read mw.user.options.get('gadget-EditNoticesOnMobile') and disable itself? (only works if/when/where EditNoticesOnMobile is available as a gadget though)

If we're supporting gadget replacements at all for this feature, which we are, I'd rather let our version (which is inherently going to be distributed to all wikis because it's inside VE) be disabled by many gadgets rather than us needing to explicitly update it to support any other gadgets that come along. E.g. some wiki might want their own implementation rather than ours or yours, or someone who intensely dislikes edit notices could make a gadget that just disables the core implementation without replacing it...

In T316177#8199226, @DLynch wrote:

How about the other way around? Have your solution read mw.user.options.get('gadget-EditNoticesOnMobile') and disable itself? (only works if/when/where EditNoticesOnMobile is available as a gadget though)

If we're supporting gadget replacements at all for this feature, which we are, I'd rather let our version (which is inherently going to be distributed to all wikis because it's inside VE) be disabled by many gadgets rather than us needing to explicitly update it to support any other gadgets that come along. E.g. some wiki might want their own implementation rather than ours or yours, or someone who intensely dislikes edit notices could make a gadget that just disables the core implementation without replacing it...

Either way some switch has to be provided. If I can set window.dontLoadVEEditNotices = true or something, that'll work.

https://phabricator.wikimedia.org/rMEXTd046bc1d44faf877e2e71cd7f46b20371ef04e32 : " Edit notices are not shown if the user has the EditNoticesOnMobile gadget enabled."

This is likely the right call as the upstream mobile edit notice implementation could probably load before any gadget. (when visiting a page edit link directly)

Providing a switch for other gadgets or "someone who intensely dislikes edit notices" could still be beneficial, but may not work in every single case.