ClientError fieldname 'tags' is conflicting
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tgr
	Sep 4 2022, 2:45 AM

Description

The ClientError event schema contains a tags field which is supposed to contain key-value pairs of various debug information. It is currently unused, and probably unusuable as the data is sent to logstash but logstash fields contain a different tags field, which I think is set here based on the source of the data, and is a plain array (as can be seen in the test data here).

Details

	Subject	Repo	Branch	Lines +/-
	mediawiki/client/error: rename 'tags' to 'error_context'	schemas/event/primary	master	+271 -6

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open		None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Open		None	T85394 Use OOUI suggestions/autocompletion components only (instead of jquery.suggestions, jquery.ui.autocomplete)
Open		None	T125725 [epic] Update autocomplete search box with metadata and remove and delete the old searchSuggest system
Open		None	T177251 Dead keys prevent autocomplete in search box
Resolved		ovasileva	T244392 [GOAL] Deploy the new Vue.js search experience
Resolved		ovasileva	T275200 Analyze results of A/B test for new search widget
Resolved		ovasileva	T249297 Deploy the new Vue.js search experience
Resolved		• jlinehan	T255585 [EPIC] Extend client-side error logging coverage to include English Wikipedia
Resolved		Tgr	T265096 Tag errors where a banner is being displayed
Resolved		ovasileva	T254488 Identify top mobile error rate contributors
Resolved		Tgr	T256173 Allow filtering of errors from logged in users
Resolved		Jdlrobson	T314948 Make channel(topic) a filterable field in logstash
Resolved	BUG REPORT	Tgr	T316992 ClientError fieldname 'tags' is conflicting

Event Timeline

Tgr created this task.Sep 4 2022, 2:45 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2022, 2:45 AM

Tgr added parent tasks: T256173: Allow filtering of errors from logged in users, T265096: Tag errors where a banner is being displayed, T314948: Make channel(topic) a filterable field in logstash.Sep 4 2022, 2:50 AM

Change 829295 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[schemas/event/primary@master] mediawiki/client/error: rename 'tags' to 'labels'

https://gerrit.wikimedia.org/r/829295

gerritbot added a project: Patch-For-Review.Sep 4 2022, 2:53 AM

phuedx mentioned this in T317656: Allow Instrumentation Engineers to label events sent during a pageview or session.Sep 13 2022, 5:23 PM

Change 829295 merged by Ottomata:

[schemas/event/primary@master] mediawiki/client/error: rename 'tags' to 'error_context'

https://gerrit.wikimedia.org/r/829295

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2022, 4:30 PM

colewhite moved this task from Inbox to Radar on the Observability-Logging board.Sep 21 2022, 10:53 AM

Aklapper edited projects, added Instrument-ClientError; removed DoNotUse---Instrument-ClientError.Nov 24 2022, 1:55 PM

Nothing left to do, I think.

ClientError fieldname 'tags' is conflictingClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

ClientError fieldname 'tags' is conflicting
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...