Page MenuHomePhabricator
Create Task
Maniphest T318763

Work out how to bring in new Phabricator translations again
Closed, ResolvedPublic
Actions

Description

In T299694#8111845, @Nikerabbit wrote:

Mukunda was handling this process before. I hope it's documented somewhere so that someone else can take it up.

In T299694#7996625, @Dylsss wrote:

Actually, there is a deployment next week and there are scn translations in the repository, but according to rPHTR Phabricator Translations, the language needs to be added to src/locales/ before it will show up. Which I'm not sure I fully understand since there are languages in settings which have translations, but don't have a file in that directory (e.g. zh-hans/zh-hant).

Upstream Stuff:

Details

SubjectRepoBranchLines +/-
Phabricator: Delete chatlog groupphabricator/translationswmf/stable+1 -1 K
Update the PHP files Phabricator reads to show the latest translationsphabricator/translationswmf/stable+66 K -9 K
Phabricator: Delete chatlog grouptranslatewikimaster+0 -9
Clean up a bunch of thingsphabricator/translationswmf/stable+713 -7 K
Remove "Releeph" and "Phragment" groups from Translatewikitranslatewikimaster+0 -18
Update arcanist translations toophabricator/translationswmf/stable+2 K -2 K
Update source strings from Phrabricatorphabricator/translationswmf/stable+17 K -17 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Sep 27 2022, 11:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2022, 11:10 PM
Reedy added parent tasks: T299694: Adding sicilian language (scn), T318762: Slovenian language in Phabricator.Sep 27 2022, 11:10 PM
Aklapper renamed this task from Work out how to bring in new translations again to Work out how to bring in new Phabricator translations again.Nov 30 2022, 9:13 AM
Aklapper added a subtask: T321350: Phabricator translations can no more be received due to decommissioning of git-ssh.Nov 30 2022, 9:17 AM
Nikerabbit closed subtask T321350: Phabricator translations can no more be received due to decommissioning of git-ssh as Resolved.Dec 8 2022, 12:44 PM
brennen subscribed.Mar 15 2023, 6:18 PM
brennen moved this task from To Triage to Infrastructure on the Phabricator board.Mar 20 2023, 10:25 PM
brennen added a project: User-brennen.
brennen moved this task from INBOX to Priority Backlog 📥 on the Release-Engineering-Team board.May 24 2023, 4:35 PM
brennen edited projects, added Release-Engineering-Team (Priority Backlog 📥); removed Release-Engineering-Team.
Aklapper added a comment.Jul 19 2023, 8:57 AM

Also note that git submodule init says it's still in Gerrit:
Submodule 'translations' (https://gerrit.wikimedia.org/r/phabricator/translations) registered for path 'translations'
Should probably move to GitLab like most other stuff nowadays.

RhinosF1 subscribed.Jul 19 2023, 9:14 AM
Aklapper triaged this task as Medium priority.Aug 2 2023, 9:08 AM
Frostly subscribed.Sep 16 2023, 9:25 PM
brennen moved this task from Backlog to Next on the User-brennen board.Oct 18 2023, 3:20 PM
Aklapper mentioned this in T321380: Move phabricator/deployments repository from Diffusion to GitLab/Gerrit.Oct 24 2023, 8:23 PM
Aklapper added a comment.Oct 28 2023, 8:42 AM

See T283327 for some older hints

Pppery mentioned this in T294754: Remove trailing whitespace from Phabricator message documentation.Oct 29 2023, 8:10 PM
Pppery subscribed.Oct 29 2023, 10:03 PM

Other noise: Hundreds/thousands of source strings have been modified as a result of the rename to Phorge, and (because of the general bitrot in this area) no changes to the source strings have been synced to Translatewiki since October 2021 (!). Furthermore, each message key is a hash of the English message, so even changes that should merely be marked FUZZY would (barring effort on the translatewiki side) register as entirely new keys. I guess I probably should still submit a patch to update the repo, but beware,

gerritbot added a comment.Oct 29 2023, 11:08 PM

Change 969518 had a related patch set uploaded (by Pppery; author: Pppery):

[phabricator/translations@wmf/stable] Update source strings from Phrabricator

https://gerrit.wikimedia.org/r/969518

gerritbot added a project: Patch-For-Review.Oct 29 2023, 11:08 PM
Pppery mentioned this in T349989: Phabricator and translatewiki disagree over how to indent JSON files.Oct 29 2023, 11:10 PM
gerritbot added a comment.Oct 29 2023, 11:53 PM

Change 969520 had a related patch set uploaded (by Pppery; author: Pppery):

[phabricator/translations@wmf/stable] Update arcanist translations too

https://gerrit.wikimedia.org/r/969520

Nikerabbit added a comment.Oct 30 2023, 6:41 AM

We have a little bit of fuzzy matching logic, but processing thousands of changes at a time is very tedious :(

gerritbot added a comment.Nov 15 2023, 4:06 PM

Change 969518 merged by Brennen Bearnes:

[phabricator/translations@wmf/stable] Update source strings from Phrabricator

https://gerrit.wikimedia.org/r/969518

gerritbot added a comment.Nov 15 2023, 4:06 PM

Change 969520 merged by Brennen Bearnes:

[phabricator/translations@wmf/stable] Update arcanist translations too

https://gerrit.wikimedia.org/r/969520

Maintenance_bot removed a project: Patch-For-Review.Nov 15 2023, 4:10 PM
Pppery added a comment.Nov 15 2023, 4:13 PM

The next step is to process an import/export on the translatewiki side, probably give some time for translators to update the hundreds of outdated strings, and then the repo needs another patch to update the place Phabricator reads (which is not the same as where translatewiki writes), and then it needs to be deployed.

Nikerabbit added a comment.Nov 15 2023, 4:18 PM

Processing:

[18:15:35] -rakkaus:#translatewiki- [nike] Imported 14 new messages or translations for phabricator-phabricator-celerity.
[18:15:35] -rakkaus:#translatewiki- [nike] Imported 2 new messages or translations for phabricator-phabricator-macro.
[18:15:35] -rakkaus:#translatewiki- [nike] Imported 4 new messages or translations for phabricator-phabricator-phriction.
[18:15:35] -rakkaus:#translatewiki- [nike] Imported 2 new messages or translations for phabricator-phabricator-phurl.
[18:15:36] -rakkaus:#translatewiki- [nike] Imported 8 new messages or translations for phabricator-phabricator-project.
[18:15:40] -rakkaus:#translatewiki- [nike] There are changes to check for groups phabricator-arcanist-core, phabricator-phabricator-almanac,
phabricator-phabricator-audit, phabricator-phabricator-auth, phabricator-phabricator-base, phabricator-phabricator-cache,
phabricator-phabricator-calendar, phabricator-phabricator-conduit, phabricator-phabricator-config, phabricator-phabricator-console,
phabricator-phabricator-core, phabricator-phabricator-daemon, [...]
Nikerabbit added a comment.Nov 15 2023, 4:42 PM

Okay this will take forever. I spend 20 minutes just for reviewing phabricator-arcanist-core for manually connecting renamed messages.

gerritbot added a comment.Nov 16 2023, 5:10 AM

Change 974717 had a related patch set uploaded (by Pppery; author: Pppery):

[phabricator/translations@wmf/stable] Clean up a bunch of things

https://gerrit.wikimedia.org/r/974717

gerritbot added a project: Patch-For-Review.Nov 16 2023, 5:10 AM
Pppery claimed this task.Nov 17 2023, 2:03 AM
gerritbot added a comment.Nov 18 2023, 12:49 AM

Change 975388 had a related patch set uploaded (by Pppery; author: Pppery):

[translatewiki@master] Remove "Releeph" and "Phragment" groups from Translatewiki

https://gerrit.wikimedia.org/r/975388

gerritbot added a comment.Nov 18 2023, 7:18 PM

Change 975413 had a related patch set uploaded (by Pppery; author: Pppery):

[phabricator/translations@wmf/stable] Run generate.php and arc liberate

https://gerrit.wikimedia.org/r/975413

Pppery added a comment.Nov 22 2023, 4:26 AM

See also https://we.phorge.it/T15055

valerio.bozzolan updated the task description. (Show Details)Nov 23 2023, 6:15 AM
valerio.bozzolan awarded a token.
valerio.bozzolan subscribed.
gerritbot added a comment.Dec 13 2023, 9:17 AM

Change 975388 merged by jenkins-bot:

[translatewiki@master] Remove "Releeph" and "Phragment" groups from Translatewiki

https://gerrit.wikimedia.org/r/975388

gerritbot added a comment.Fri, Apr 19, 1:46 PM

Change #974717 merged by Brennen Bearnes:

[phabricator/translations@wmf/stable] Clean up a bunch of things

https://gerrit.wikimedia.org/r/974717

gerritbot added a comment.Fri, Apr 19, 3:42 PM

Change #1022023 had a related patch set uploaded (by Pppery; author: Pppery):

[translatewiki@master] Phabricator: Delete chatlog group

https://gerrit.wikimedia.org/r/1022023

gerritbot added a comment.Fri, Apr 19, 3:56 PM

Change #1022053 had a related patch set uploaded (by Pppery; author: Pppery):

[phabricator/translations@wmf/stable] Phabricator: Delete chatlog group

https://gerrit.wikimedia.org/r/1022053

gerritbot added a comment.Tue, Apr 23, 6:39 AM

Change #1022023 merged by jenkins-bot:

[translatewiki@master] Phabricator: Delete chatlog group

https://gerrit.wikimedia.org/r/1022023

gerritbot added a comment.Tue, Apr 23, 2:40 PM

Change #975413 merged by Brennen Bearnes:

[phabricator/translations@wmf/stable] Update the PHP files Phabricator reads to show the latest translations

https://gerrit.wikimedia.org/r/975413

Pppery moved this task from Infrastructure to 2024-04-23 on the Phabricator board.Tue, Apr 23, 3:09 PM
Pppery edited projects, added Phabricator (2024-04-23); removed Phabricator.
Pppery closed this task as Resolved.EditedTue, Apr 23, 4:03 PM

Closing this as resolved since it seems to have been deployed and works, I still have some more cleanup of the translations repo I want to do, but that can go in another task.

The process here still requires someone to manually process translations whenever a new version of upstream is deployed, or when any translations are updated on the translatewiki site, and requires additional manual work for a new language to be added. I plan to keep doing that stuff as it comes up, but feel free to poke me (or, if you're brave, run it yourself) if I fall behind.

Pppery mentioned this in T363188: Update phabricator-translations for 2023.49 release.Tue, Apr 23, 4:32 PM
Pppery mentioned this in T299694: Adding sicilian language (scn).Thu, Apr 25, 9:12 PM
gerritbot added a comment.Sun, May 12, 11:31 AM

Change #1022053 merged by Aklapper:

[phabricator/translations@wmf/stable] Phabricator: Delete chatlog group

https://gerrit.wikimedia.org/r/1022053

Maintenance_bot removed a project: Patch-For-Review.Sun, May 12, 12:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL