Maniphest T320519

1.40.0-wmf.14 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Assigned To

Authored By

	thcipriani
	Oct 11 2022, 2:42 PM

Details

Backup Train Conductor: • demon
Release Version: 1.40.0-wmf.14
Release Date: Dec 12 2022, 12:00 AM

2022 week 50 1.40-wmf.14 Changes wmf/1.40.0-wmf.14

This MediaWiki Train Deployment is scheduled for the week of Monday, December 12th:

Monday December 12th	Tuesday, December 13th	Wednesday, December 14th	Thursday, December 15th	Friday
Backports only.	Branch `wmf.14` and deploy to Group 0 Wikis.	Deploy `wmf.14` to Group 1 Wikis.	Deploy `wmf.14` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.14 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.40.0-wmf.13

Next: 1.40.0-wmf.15

Subject	Repo	Branch	Lines +/-
all wikis to 1.40.0-wmf.14	operations/mediawiki-config	master	+325 -325
group1 wikis to 1.40.0-wmf.14	operations/mediawiki-config	master	+536 -536
group0 wikis to 1.40.0-wmf.14	operations/mediawiki-config	master	+128 -128
testwikis wikis to 1.40.0-wmf.14	operations/mediawiki-config	master	+4 -4
Branch commit for wmf/1.40.0-wmf.14	mediawiki/core	wmf/1.40.0-wmf.14	+991 -3

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	hashar	T320519 1.40.0-wmf.14 deployment blockers
Resolved	BUG REPORT	Func	T325034 Removal of RangeChronologicalPager::rangeConds breaks Special:CheckUser's period selection and causes CheckUser pipeline failures
Resolved	PRODUCTION ERROR	xSavitar	T325137 UnexpectedValueException: Invalid version string ""

Event Timeline

thcipriani created this task.Oct 11 2022, 2:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2022, 2:42 PM

thcipriani assigned this task to hashar.Oct 31 2022, 3:53 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: • demon.

thcipriani set the point value for this task to 5.

thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).

I have been sworn in as the last train conductor of the year 2022!

Risky Patch! 🚂🔥

Change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/853079
Summary: This (and the preceding patch) together add language counter CSS support for Parsoid (Cite) HTML
- This may potentially cause misrendering of Cite ref counters when a page is opened in Visual Editor for editing.
- I am flagging this risky ultra conservatively since the Cite numbering localization in Parsoid HTML for non-english wikis has been broken forever and this should only improve the situation. But, this could inadvertently impact rendering inside VE and be noticed anyway.
Test plan:
- Tested locally and will test on beta cluster.
- Will test on testwiki, officewiki, mediawiki.org after group 0 deploy, and subsequently on other wikis on group 1 and group 2 deploys
Places to monitor: Won't show up in logs, but there might be user reports in Phab.
Revert plan: We can try to fix the CSS and swat deploy the CSS fixes. But, if we find the disruption is severe and there isn't a simple fix, we might recommend reverting the ptach.
Affected wikis: all wikis
IRC contact: `subbu, subbu_ss, cscott
UBN Task Projects/tags: Parsoid, Content-Transform-Team
Would you like to backport this change rather than ride the train?: No

This revert should go in before the branch is cut: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/867232

This is not critical, it will just write a lot of useless data to graphoid. I'll make an updated version later.

Dreamy_Jazz added a subtask: T325034: Removal of RangeChronologicalPager::rangeConds breaks Special:CheckUser's period selection and causes CheckUser pipeline failures.Dec 13 2022, 2:26 AM

Change 866820 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.40.0-wmf.14] Branch commit for wmf/1.40.0-wmf.14

https://gerrit.wikimedia.org/r/866820

gerritbot added a project: Patch-For-Review.Dec 13 2022, 3:07 AM

Change 866820 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.14] Branch commit for wmf/1.40.0-wmf.14

https://gerrit.wikimedia.org/r/866820

Change 867308 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.40.0-wmf.14

https://gerrit.wikimedia.org/r/867308

Change 867308 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.40.0-wmf.14

https://gerrit.wikimedia.org/r/867308

Mentioned in SAL (#wikimedia-operations) [2022-12-13T04:02:30Z] <mwpresync@deploy1002> Started scap: testwikis wikis to 1.40.0-wmf.14 refs T320519

Mentioned in SAL (#wikimedia-operations) [2022-12-13T04:54:41Z] <mwpresync@deploy1002> Finished scap: testwikis wikis to 1.40.0-wmf.14 refs T320519 (duration: 52m 11s)

Ladsgroup subscribed.Dec 13 2022, 5:49 AM

Nikerabbit subscribed.Dec 13 2022, 6:06 AM

In T320519#8461769, @daniel wrote:

This revert should go in before the branch is cut: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/867232

This is not critical, it will just write a lot of useless data to graphoid. I'll make an updated version later.

That got merged before the wmf branch cut and the patch is included in wmf/1.40.0-wmf.14.

Change 867522 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group0 wikis to 1.40.0-wmf.14

https://gerrit.wikimedia.org/r/867522

Change 867522 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.40.0-wmf.14

https://gerrit.wikimedia.org/r/867522

Mentioned in SAL (#wikimedia-operations) [2022-12-13T09:17:36Z] <hashar@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.40.0-wmf.14 refs T320519

Dreamy_Jazz closed subtask T325034: Removal of RangeChronologicalPager::rangeConds breaks Special:CheckUser's period selection and causes CheckUser pipeline failures as Resolved.Dec 13 2022, 9:50 AM

Dreamy_Jazz reopened subtask T325034: Removal of RangeChronologicalPager::rangeConds breaks Special:CheckUser's period selection and causes CheckUser pipeline failures as Open.

matmarex closed subtask T325034: Removal of RangeChronologicalPager::rangeConds breaks Special:CheckUser's period selection and causes CheckUser pipeline failures as Resolved.Dec 13 2022, 4:05 PM

hashar added a subtask: T325137: UnexpectedValueException: Invalid version string "".Dec 14 2022, 9:25 AM

The fix for T325137 is being worked on and we should have a hotfix in the afternoon. Once backported, I will promote group1 , probably late in the afternoon (from an European point of view).

In T320519#8466074, @hashar wrote:

The fix for T325137 is being worked on and we should have a hotfix in the afternoon. Once backported, I will promote group1 , probably late in the afternoon (from an European point of view).

Fix is up: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/868066

I won't be around to backport it, unfortunately.

I'll backport it between my meetings.

hashar closed subtask T325137: UnexpectedValueException: Invalid version string "" as Resolved.Dec 14 2022, 4:09 PM

Change 868104 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group1 wikis to 1.40.0-wmf.14

https://gerrit.wikimedia.org/r/868104

Change 868104 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.40.0-wmf.14

https://gerrit.wikimedia.org/r/868104

Mentioned in SAL (#wikimedia-operations) [2022-12-14T16:43:11Z] <hashar@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.40.0-wmf.14 refs T320519

Mentioned in SAL (#wikimedia-operations) [2022-12-14T16:50:19Z] <hashar@deploy1002> Synchronized php: group1 wikis to 1.40.0-wmf.14 refs T320519 (duration: 07m 06s)

hashar mentioned this in T325205: MediaWiki\Revision\RevisionAccessException: Page {name} not found.Dec 14 2022, 4:56 PM

Change 868226 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] all wikis to 1.40.0-wmf.14

https://gerrit.wikimedia.org/r/868226

Change 868226 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.40.0-wmf.14

https://gerrit.wikimedia.org/r/868226

Mentioned in SAL (#wikimedia-operations) [2022-12-15T09:08:18Z] <hashar@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.40.0-wmf.14 refs T320519

I am claiming the last MediaWiki train of the year 2022 to be a SUCCESS.

Congratulations everyone that shipped code ;)

antoine-approve

Umherirrender mentioned this in T325329: PHP Notice: Trying to access array offset on value of type bool (Wt2Html/PP/Processors/AddRedLinks.php).Dec 15 2022, 11:00 PM

1.40.0-wmf.14 deployment blockersClosed, ResolvedPublic5 Estimated Story PointsReleaseActions