Maniphest T320531

Configure VE backend to use Parsoid directly on the beta cluster and testwiki
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Oct 11 2022, 3:57 PM

Description

Before we switch VisualEditor away from using RESTbase in production, we need to try out the new backend code on SOME (not all) sites on the beta cluster and on testwiki.

dewiki.beta
testwiki

Relevant configuration:

# New config being introduced, see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/844465/8/extension.json#114
$VisualEditorDefaultParsoidClient = 'direct';

# NOTE: we used to force direct mode by disabling VRS alltogether, but other extensions use it!
#            So we should enable it again.
$wmgUseRestbaseVRS= false;

Relevant configuration:

$wmgUseRestbaseVRS= false;

NOTE: this is already enabled on labswiki (wikitech).

Details

Subject	Repo	Branch	Lines +/-
Set wmgVisualEditorAccessRestbaseDirectly = false for testwiki and dewiki.beta	operations/mediawiki-config	master	+8 -0
Set VisualEditorDefaultParsoidClient for dewiki-beta mad testwiki	operations/mediawiki-config	master	+18 -15
Beta: Switch VE on dewiki to direct mode	operations/mediawiki-config	master	+9 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T324931 Clean up open RESTBase related tickets
In Progress	None	T262315 <CORE TECHNOLOGY> API Migration & RESTbase Sunset
Open	None	T264669 Move VE API from RESTBase into core.
Open	None	T344944 Move Parsoid endpoints out of RESTbase
In Progress	None	T328559 Replace usage of RESTbase parsoid endpoints
Resolved	daniel	T320529 Configure VE backend to use Parsoid directly, instead of calling RESTbase
Resolved	daniel	T320536 Ensure that stashing backend for the VE API has sufficient capacity
Resolved	daniel	T320531 Configure VE backend to use Parsoid directly on the beta cluster and testwiki
Resolved	daniel	T320535 Put Parsoid output into the ParserCache on the beta cluster and testwiki

Event Timeline

daniel created this task.Oct 11 2022, 3:57 PM

daniel mentioned this in T320535: Put Parsoid output into the ParserCache on the beta cluster and testwiki.Oct 11 2022, 4:18 PM

daniel updated the task description. (Show Details)

daniel renamed this task from Configure VE backend to use Parsoid directly on the beta cluster an testwiki to Configure VE backend to use Parsoid directly on the beta cluster and testwiki.Oct 11 2022, 4:31 PM

daniel added a subtask: T320535: Put Parsoid output into the ParserCache on the beta cluster and testwiki.

daniel updated the task description. (Show Details)Oct 11 2022, 5:54 PM

daniel updated the task description. (Show Details)Oct 12 2022, 9:15 AM

daniel updated the task description. (Show Details)Oct 12 2022, 9:18 AM

daniel updated the task description. (Show Details)

daniel mentioned this in T320529: Configure VE backend to use Parsoid directly, instead of calling RESTbase.

Change 841858 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[operations/mediawiki-config@master] Beta: Switch VE on dewiki to direct mode

https://gerrit.wikimedia.org/r/841858

gerritbot added a project: Patch-For-Review.Oct 12 2022, 9:22 AM

Change 841858 merged by jenkins-bot:

[operations/mediawiki-config@master] Beta: Switch VE on dewiki to direct mode

https://gerrit.wikimedia.org/r/841858

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2022, 8:30 PM

daniel updated the task description. (Show Details)Oct 12 2022, 8:32 PM

The change on beta de.wp seems to have broken saving changes to existing pages using visual editor. (Opening the editor doesn't fail, only saving/reviewing; and saving new pages also works.)

Testing on https://de.wikipedia.beta.wmflabs.org/wiki/Benutzer:Yatu, I get an error message mentioning HTTP 412 (Precondition Failed).

This happens because when opening VE, it loads the existing page HTML client-side (the request is sent from the JS code in the user's browser, not from the PHP code) from https://de.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/Benutzer%3AYatu?redirect=false&stash=true, which presumably still points to RESTBase. But when saving, it calls the core MediaWiki/Parsoid code, which doesn't have the original stashed HTML, so it fails.

There are a few ways to fix this:

Set wmgVisualEditorAccessRestbaseDirectly = false for this wiki, so that the client-side request is replaced by a server-side request (easiest fix for now, and we use this config on private production wikis; however it'd be better not to use this for public production wikis, since it makes the editor slower to load)
Make that URL be served by MediaWiki, not RESTBase (I don't know how to go about that)
Set $wgVisualEditorFullRestbaseURL to a different URL prefix that is served by MediaWiki and contains compatible APIs (I don't know if such URL prefix actually exists now)

daniel mentioned this in T320703: VisualEditor can't save pages on de.wikipedia.beta.Oct 13 2022, 9:21 AM

Filed T320703: VisualEditor can't save pages on de.wikipedia.beta

daniel mentioned this in T320704: When VisualEditor saves an edit, it should use the same backend that the HTML was originally loaded from.Oct 13 2022, 9:42 AM

daniel triaged this task as High priority.Oct 18 2022, 2:58 PM

daniel moved this task from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.

DAlangi_WMF awarded a token.Oct 19 2022, 2:34 PM

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Oct 20 2022, 3:53 PM

daniel updated the task description. (Show Details)Oct 20 2022, 5:20 PM

daniel added a parent task: T320536: Ensure that stashing backend for the VE API has sufficient capacity.Oct 20 2022, 5:23 PM

Change 845058 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[operations/mediawiki-config@master] Set VisualEditorDefaultParsoidClient for dewiki

https://gerrit.wikimedia.org/r/845058

gerritbot added a project: Patch-For-Review.Oct 20 2022, 9:17 PM

daniel closed subtask T320535: Put Parsoid output into the ParserCache on the beta cluster and testwiki as Resolved.Nov 3 2022, 8:27 PM

Change 845058 merged by jenkins-bot:

[operations/mediawiki-config@master] Set VisualEditorDefaultParsoidClient for dewiki-beta mad testwiki

https://gerrit.wikimedia.org/r/845058

Mentioned in SAL (#wikimedia-operations) [2022-11-07T08:04:41Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:845058|Set VisualEditorDefaultParsoidClient for dewiki-beta mad testwiki (T320531)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-07T08:05:01Z] <urbanecm@deploy1002> urbanecm and daniel: Backport for [[gerrit:845058|Set VisualEditorDefaultParsoidClient for dewiki-beta mad testwiki (T320531)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-11-07T08:23:36Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:845058|Set VisualEditorDefaultParsoidClient for dewiki-beta mad testwiki (T320531)]] (duration: 18m 54s)

Change 853919 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[operations/mediawiki-config@master] Set wmgVisualEditorAccessRestbaseDirectly = false for testwiki and dewiki.beta

https://gerrit.wikimedia.org/r/853919

Change 853919 merged by jenkins-bot:

[operations/mediawiki-config@master] Set wmgVisualEditorAccessRestbaseDirectly = false for testwiki and dewiki.beta

https://gerrit.wikimedia.org/r/853919

Mentioned in SAL (#wikimedia-operations) [2022-11-07T08:57:34Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:853919|Set wmgVisualEditorAccessRestbaseDirectly = false for testwiki and dewiki.beta (T320531)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-07T08:57:54Z] <urbanecm@deploy1002> urbanecm and daniel: Backport for [[gerrit:853919|Set wmgVisualEditorAccessRestbaseDirectly = false for testwiki and dewiki.beta (T320531)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-11-07T09:06:42Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:853919|Set wmgVisualEditorAccessRestbaseDirectly = false for testwiki and dewiki.beta (T320531)]] (duration: 09m 07s)

daniel closed this task as Resolved.Nov 7 2022, 7:59 PM

daniel claimed this task.

daniel updated the task description. (Show Details)

	F35565345: image.png
	Oct 13 2022, 1:09 AM

Configure VE backend to use Parsoid directly on the beta cluster and testwikiClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Configure VE backend to use Parsoid directly on the beta cluster and testwiki
Closed, ResolvedPublic
Actions

Related Objects
Search...