Page MenuHomePhabricator

Nearby popups not scrolled into view completely when containing images
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to reproduce

  • Open a map on a wiki with the nearby feature
  • Enable nearby
  • Click on a dot that's close to the upper end of the map to expand the popup

What happens

  • The popup opens above the dot and scrolls into view
  • Scrolling stops at some point and the popup is cut off

CutOffPopup.png (391×441 px, 147 KB)

Note
This seems to happen only when images are present. The popup scrolls into view when the images are still being loaded. So the finale size of the popup is not known to the browser when the scroll into view is supposed to happen.

Event Timeline

Change 835119 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Consider thumbnail width/height when rendering nearby popups

https://gerrit.wikimedia.org/r/835119

WMDE-Fisch set the point value for this task to 1.

Change 835119 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Consider thumbnail width/height when rendering nearby popups

https://gerrit.wikimedia.org/r/835119

WMDE-Fisch claimed this task.