Page MenuHomePhabricator

Edit: Check if the event page belongs to the wiki where the organizer is trying to edit event information
Open, In Progress, Needs TriagePublic2 Estimated Story Points

Description

As an event organizer who is trying to edit my event registration information, I want to be redirected to the wiki of the my event, so that I can successfully edit my event registration information.

Acceptance Criteria:

  • Given an event organizer goes to the Special:EditEventRegistration/{eventID}
  • Or if they go to Special:MyEvents (Kebab menu "Edit Registration")
    • And the event ID does not belong to the wiki where the user is trying to access the page
      • Then we display the following text: "Please edit the event registration details on [wiki name], the wiki where the event was created."
        • Hyperlink to the proper wiki Special:EditEventRegistration/{eventID} on the following text: "edit the event registration details on [wiki name]"
          • Note that the wiki name should be displayed as a URL (such as en.wikipedia.org) rather than the DB name

Design
Design specs

image.png (706×2 px, 106 KB)

Event Timeline

ifried renamed this task from Check if the event page belongs to the wiki where the user is trying to access on Special:EditEventRegistration/{eventID} to [Edit] Check if the event page belongs to the wiki where the organizer is trying to edit event information.Feb 29 2024, 4:04 PM
ifried renamed this task from [Edit] Check if the event page belongs to the wiki where the organizer is trying to edit event information to Edit: Check if the event page belongs to the wiki where the organizer is trying to edit event information.
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)

Hello, @gonyeahialam! Can you add in a visual example in the "Visual example" section of this task? Thank you in advance!

Hello, @gonyeahialam! Can you add in a visual example in the "Visual example" section of this task? Thank you in advance!

Done

ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried set the point value for this task to 3.
ifried changed the point value for this task from 3 to 2.Mar 5 2024, 4:21 PM

Assigning to @cmelo, since I heard he is working on this (and correct me if I am wrong, please!)

Change 1011123 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Add notice for when the user tries to edit registration on another wiki

https://gerrit.wikimedia.org/r/1011123

cmelo changed the task status from Open to In Progress.Mar 15 2024, 2:46 PM

Change 1011123 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add notice for when the user tries to edit registration on another wiki

https://gerrit.wikimedia.org/r/1011123

✅ This is working correctly and acceptance criteria is met in both Special:EditEventRegistration/{eventID} and Special:MyEvents (Kebab menu "Edit Registration")

Screenshot 2024-03-18 at 4.57.02 PM.png (424×2 px, 65 KB)


@cmelo two things though:

  1. The linked text should be a stronger font weight. Note the difference between the comp and the build :
compbuild
image.png (706×2 px, 106 KB)
Screenshot 2024-03-18 at 4.57.02 PM.png (424×2 px, 65 KB)
  1. I noticed on spanish betacluster that the url was not linked. I am assuming this is a limitation of the translation (or possibly just because it hasn't been translated yet), but wanted to check with you here to make sure.

Screenshot 2024-03-18 at 5.08.30 PM.png (348×1 px, 50 KB)

✅ This is working correctly and acceptance criteria is met in both Special:EditEventRegistration/{eventID} and Special:MyEvents (Kebab menu "Edit Registration")

Screenshot 2024-03-18 at 4.57.02 PM.png (424×2 px, 65 KB)


@cmelo two things though:

  1. The linked text should be a stronger font weight. Note the difference between the comp and the build :
compbuild
image.png (706×2 px, 106 KB)
Screenshot 2024-03-18 at 4.57.02 PM.png (424×2 px, 65 KB)
  1. I noticed on spanish betacluster that the url was not linked. I am assuming this is a limitation of the translation (or possibly just because it hasn't been translated yet), but wanted to check with you here to make sure.

Screenshot 2024-03-18 at 5.08.30 PM.png (348×1 px, 50 KB)

Hi @vaughnwalters, thank you.
For item 1 I will check if it is doable, I think it is the default style of this ooui component, not sure if I will be able to change it.

For item 2 I will take a look, but I think you are right, the issue might be related to the missing translation and should be solved as soon as it is translated.

Change #1014498 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Bold the link text on Especial:EditEventRegistration for the non local wiki notice

https://gerrit.wikimedia.org/r/1014498

Hi @vaughnwalters, I was able to fix both issues.

The issue on Spanish was an error made by who translated it, basically a space was added at the beginning and the end of the link causing this issue.

Change #1014498 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Bold the link text on EditEventRegistration for the non local wiki notice

https://gerrit.wikimedia.org/r/1014498

✅ This is working correctly and acceptance criteria is met in both Special:EditEventRegistration/{eventID} and Special:MyEvents (Kebab menu "Edit Registration")

Screenshot 2024-03-18 at 4.57.02 PM.png (424×2 px, 65 KB)


@cmelo two things though:

  1. The linked text should be a stronger font weight. Note the difference between the comp and the build :
compbuild
image.png (706×2 px, 106 KB)
Screenshot 2024-03-18 at 4.57.02 PM.png (424×2 px, 65 KB)
  1. I noticed on spanish betacluster that the url was not linked. I am assuming this is a limitation of the translation (or possibly just because it hasn't been translated yet), but wanted to check with you here to make sure.

Screenshot 2024-03-18 at 5.08.30 PM.png (348×1 px, 50 KB)

Hi @vaughnwalters, thank you.
For item 1 I will check if it is doable, I think it is the default style of this ooui component, not sure if I will be able to change it.

For item 2 I will take a look, but I think you are right, the issue might be related to the missing translation and should be solved as soon as it is translated.

Hi @vaughnwalters, I was able to fix both issues.

The issue on Spanish was an error made by who translated it, basically a space was added at the beginning and the end of the link causing this issue.

This looks correct on English betacluster now. On spanish betacluster (for example), it is not bolded, but I think this is out of scope for this ticket as this will be up to the translator to follow the correct formatting. Is this correct @cmelo?

en betaclusteres betacluster
Screenshot 2024-04-09 at 4.28.12 PM.png (472×1 px, 73 KB)
Screenshot 2024-04-10 at 12.44.22 PM.png (308×1 px, 55 KB)

This looks correct on English betacluster now. On spanish betacluster (for example), it is not bolded, but I think this is out of scope for this ticket as this will be up to the translator to follow the correct formatting. Is this correct @cmelo?

en betaclusteres betacluster
Screenshot 2024-04-09 at 4.28.12 PM.png (472×1 px, 73 KB)
Screenshot 2024-04-10 at 12.44.22 PM.png (308×1 px, 55 KB)

This will be up to the translator to add the bold text in other translations. Moving to design sign off.