Page MenuHomePhabricator

Deploy geoshape expansion to wikis
Open, Needs TriagePublic

Description

We've demonstrated this new behavior on the beta cluster, and are ready to proceed to more wikis. My initial recommendation is that we just enable everywhere, some time next week. We expect that the impact will be mostly minor and positive: most maps with external data will load faster for readers, and some significant load reduction will happen on the maps servers, which should speed up maps in general. The only potentially negative impact will be on a handful of pages which include complex SPARQL queries: these will take much longer to serve. After smoke testing, for example by saving this page, we see that the final result is as planned, the page contains the same content as before, the external data is left unexpanded. We don't anticipate any other negative impacts. See also T326630.

This will be deployed by enabling the $wgKartographerExternalDataParseTimeFetch feature flag, so it can go out any day and can be immediately reverted if we hear of problems.

What to monitor:

Event Timeline

We haven't finalized a plan for what this deployment should look like. @Lena_WMDE and the developers will update the task description once we have consensus.

Change 879559 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[operations/mediawiki-config@master] Enable kartographer external data parse time fetch for all wikis

https://gerrit.wikimedia.org/r/879559

We have at least the minimum monitoring in place now, so full deployment is unblocked.

Change 879559 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable kartographer external data parse time fetch for all wikis

https://gerrit.wikimedia.org/r/879559

Mentioned in SAL (#wikimedia-operations) [2023-01-30T09:52:23Z] <awight@deploy1002> Started scap: Backport for [[gerrit:879559|Enable kartographer external data parse time fetch for all wikis (T326317)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-30T09:54:05Z] <awight@deploy1002> lilients and awight: Backport for [[gerrit:879559|Enable kartographer external data parse time fetch for all wikis (T326317)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-30T10:00:17Z] <awight@deploy1002> Finished scap: Backport for [[gerrit:879559|Enable kartographer external data parse time fetch for all wikis (T326317)]] (duration: 07m 53s)

Change 884889 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Strip invalid GeoJSON properties after ExternalData expansion

https://gerrit.wikimedia.org/r/884889

We temporarily enabled this feature on all wikis Jan 30th, 10:00-13:23 UTC. Two issues were spotted, which we'll address in subtasks:

  • geoshape service requests unexpectedly jumped up by 3x, which is contrary to our theory that they could only decrease.
  • Static thumbnails were missing some of the time. We think our migration was too hard because it made different caches of the same revision temporarily incompatible.

Change 884889 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] Strip invalid GeoJSON properties after ExternalData expansion

Reason:

T332973

https://gerrit.wikimedia.org/r/884889