Page MenuHomePhabricator

AbuseFilter does not show contents of message
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
JTannerWMF
Jan 19 2023, 4:37 PM
Referenced Files
F36535407: Go back.png
Jan 27 2023, 10:41 PM
F36535409: Publisb anyway.png
Jan 27 2023, 10:41 PM
F36439965: Block.png
Jan 23 2023, 6:26 PM
F36439963: Abuse filter triggered.png
Jan 23 2023, 6:26 PM
F36372423: Block.png
Jan 20 2023, 8:34 PM
F36372421: Abuse filter triggered.png
Jan 20 2023, 8:34 PM
F36372417: IMG_0265.png
Jan 20 2023, 8:34 PM
F36372419: IMG_0264.png
Jan 20 2023, 8:34 PM

Description

Steps to replicate the issue (include links if applicable):

  • Go into iOS app and trigger abuse filter when editing

What happens?:

  • If the message is at MediaWiki:Abusefilter-warning-foo, the user will see <abusefilter-warning-foo>,

What should have happened instead?:

  • User should see contents of that page

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
The styling of it should be the same as EditNotices. You can draw inspiration from the Android implementation.

Design

Link to Figma designs

An AbuseFilter gets triggered when an editor tries to publish a low quality edit that gets detected and a warning message gets sent to the editor (all content of the message should be displayed in the modal on mobile). They could also be blocked, or the edit can be disallowed in a variety of ways (more information found in Extension:AbuseFilter/Actions ).

  • If the alert message recommends a change but doesn't block the edit it would be displayed as an alert modal with two options 'Go back' or 'Publish anyway'.
  • If the editor is unable to publish the edit after triggering a different type of an AbuseFilter, then they will see a warning modal similar to a block message, where they are only able to acknowledge the alert and are brought back to the editing screen.

Screens

Editor taps on pencil on article viewEditing screenEditor taps 'Next' and sees a 'Preview'Editor can add an 'Edit Summary'AbuseFilter triggered, warning message sent but editor may still publish or go back to editing screenAbuseFilter triggered and editor cannot publish the edit
Article.png (667×375 px, 213 KB)
IMG_0263-1.png (667×375 px, 69 KB)
IMG_0264.png (667×375 px, 156 KB)
IMG_0265.png (667×375 px, 40 KB)
Publisb anyway.png (667×375 px, 42 KB)
Go back.png (667×375 px, 41 KB)

Note for QA

As a part of this, please regression test page protection logic on our editor and article description editor, to be sure it still works as before. Our plan is to release blocked work, edit notices and abuse filter work before we pick up T313772.

Event Timeline

Some of this work overlaps with displaying proper blocked messages (T275118), so moving this to Waiting while that pre-work is being done.

@OTichonova you should be able to test this by adding "the abuse filter will block this" or "the abuse filter will warn about this" to a Test Wikipedia edit. Note that this displays the same panel as Blocked messages, so you may want to wait on design review until that feedback is addressed.

JTannerWMF claimed this task.