Page MenuHomePhabricator
Create Task
Maniphest T327656

Load thumbnail image on click in nearby
Closed, ResolvedPublic
Actions

Description

We want to load images on click to work around the API limit for thumbnails and allow adding more than 50 nearby points.

Screenshot from 2023-02-03 12-46-34.png (573×1 px, 203 KB)

Implementation

  • Change limit from 50 to 100
  • Load thumbnail on click instead of directly with the API call
  • Scroll into view after the image is loaded ( even if we scroll twice then ) to prevent popups that are out of view

Demo for fix:
https://de.wikipedia.org/wiki/Bremen#/map/0

  • Load nearby points & click on one of them (e.g. at the top of the screen )

Details

SubjectRepoBranchLines +/-
Nearby: Don't create popup HTML twice without/with thumbnailmediawiki/extensions/Kartographermaster+14 -29
Nearby: Fetch up to 50 thumbnails in 1 API requestmediawiki/extensions/Kartographermaster+12 -3
Nearby: Load thumbnails on click onlymediawiki/extensions/Kartographermaster+35 -56
Nearby: Cache thumbnail API responsesmediawiki/extensions/Kartographermaster+31 -8
Nearby: Rebuild popup creation to avoid private callmediawiki/extensions/Kartographermaster+27 -15
Nearby: Scroll popup into view after thumbnail is retreivedmediawiki/extensions/Kartographermaster+6 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

lilients_WMDE created this task.Jan 23 2023, 2:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2023, 2:15 PM
lilients_WMDE mentioned this in T308227: Visually grouping/un-grouping markers on zoom in nearby feature.Jan 23 2023, 2:19 PM
lilients_WMDE removed lilients_WMDE as the assignee of this task.Jan 23 2023, 2:23 PM
lilients_WMDE moved this task from Sprint Backlog to UX/PM Review on the WMDE-TechWish-Sprint-2023-01-18 board.
lilients_WMDE moved this task from Backlog to Ready for story time on the WMDE-GeoInfo-FocusArea board.
gerritbot added a comment.Jan 23 2023, 2:26 PM

Change 882571 had a related patch set uploaded (by Svantje Lilienthal; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Nearby: Load thumbnails on click only

https://gerrit.wikimedia.org/r/882571

gerritbot added a project: Patch-For-Review.Jan 23 2023, 2:26 PM
gerritbot added a comment.Jan 24 2023, 3:32 PM

Change 882574 had a related patch set uploaded (by Svantje Lilienthal; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Nearby: Cache thumbnail API responses

https://gerrit.wikimedia.org/r/882574

gerritbot added a comment.Jan 24 2023, 3:34 PM

Change 882586 had a related patch set uploaded (by Svantje Lilienthal; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Nearby: Fetch up to 50 thumbnails in 1 API request

https://gerrit.wikimedia.org/r/882586

WMDE-Fisch updated the task description. (Show Details)Jan 25 2023, 3:19 PM
WMDE-Fisch moved this task from UX/PM Review to Tech Review on the WMDE-TechWish-Sprint-2023-01-18 board.
WMDE-Fisch subscribed.

Talked about it in story time. We'll scroll into view when the image size is known.

lilients_WMDE moved this task from Tech Review to Sprint Backlog on the WMDE-TechWish-Sprint-2023-01-18 board.Jan 31 2023, 2:10 PM
WMDE-Fisch claimed this task.Feb 2 2023, 9:21 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2023-01-18 board.
gerritbot added a comment.Feb 2 2023, 11:42 AM

Change 886009 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] Nearby: Scroll popup into view after thumbnail is retreived

https://gerrit.wikimedia.org/r/886009

gerritbot added a comment.Feb 2 2023, 1:22 PM

Change 886041 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] Nearby: Rebuild popup creation and update

https://gerrit.wikimedia.org/r/886041

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Feb 2 2023, 1:25 PM
WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2023-01-18 board.
gerritbot added a comment.Feb 2 2023, 2:17 PM

Change 882571 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Nearby: Load thumbnails on click only

https://gerrit.wikimedia.org/r/882571

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 2 2023, 3:00 PM
lilients_WMDE updated the task description. (Show Details)Feb 2 2023, 3:00 PM
gerritbot added a comment.Feb 2 2023, 5:05 PM

Change 886009 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Nearby: Scroll popup into view after thumbnail is retreived

https://gerrit.wikimedia.org/r/886009

gerritbot added a comment.Feb 2 2023, 5:07 PM

Change 886041 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Nearby: Rebuild popup creation to avoid private call

https://gerrit.wikimedia.org/r/886041

lilients_WMDE updated the task description. (Show Details)Feb 3 2023, 11:48 AM
gerritbot added a comment.Feb 6 2023, 11:25 AM

Change 882574 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Nearby: Cache thumbnail API responses

https://gerrit.wikimedia.org/r/882574

lilients_WMDE updated the task description. (Show Details)Feb 7 2023, 4:28 PM
WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2023-01-18 board.Feb 8 2023, 9:55 AM
WMDE-Fisch updated the task description. (Show Details)Feb 13 2023, 8:04 AM
thiemowmde moved this task from Ready for story time to In sprint on the WMDE-GeoInfo-FocusArea board.Feb 13 2023, 9:25 AM
thiemowmde closed this task as Resolved.Feb 13 2023, 10:39 AM
thiemowmde claimed this task.
gerritbot added a comment.Feb 16 2023, 8:31 AM

Change 882586 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] Nearby: Fetch up to 50 thumbnails in 1 API request

Reason:

https://gerrit.wikimedia.org/r/882586

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2023, 9:10 AM
gerritbot added a comment.Jun 2 2023, 7:59 AM

Change 926415 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Nearby: Don't create popup HTML twice without/with thumbnail

https://gerrit.wikimedia.org/r/926415

gerritbot added a project: Patch-For-Review.Jun 2 2023, 7:59 AM
gerritbot added a comment.Jun 7 2023, 12:15 PM

Change 926415 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Nearby: Don't create popup HTML twice without/with thumbnail

https://gerrit.wikimedia.org/r/926415

Maintenance_bot removed a project: Patch-For-Review.Jun 7 2023, 12:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 7 2023, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL