Page MenuHomePhabricator

Increase threshold for table of contents collapsing
Closed, ResolvedPublic1 Estimated Story Points

Description

Per discussion with @alexhollender_WMF and community feedback increase table of contents so it collapses at 28 rather than 20.

TODO

  • Change limit from 20 to 28

QA

https://en.wikipedia.org/wiki/The%20Legend%20of%20Vox%20Machina should appear expanded by default

QA Results - Prod

ACStatusDetails
1T328045#8576662

Event Timeline

Change 884035 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Increase threshold for table of contents collapsing

https://gerrit.wikimedia.org/r/884035

LGoto triaged this task as Medium priority.Jan 26 2023, 6:32 PM
LGoto set the point value for this task to 1.

Change 884055 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Increase threshold for table of contents collapsing

https://gerrit.wikimedia.org/r/884055

Change 884055 merged by jenkins-bot:

[operations/mediawiki-config@master] Increase threshold for table of contents collapsing

https://gerrit.wikimedia.org/r/884055

Mentioned in SAL (#wikimedia-operations) [2023-01-26T21:39:03Z] <thcipriani@deploy1002> Started scap: Backport for [[gerrit:884055|Increase threshold for table of contents collapsing (T328045)]], [[gerrit:879664|Remove redundant block for search descriptions (T324859)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-26T21:40:42Z] <thcipriani@deploy1002> thcipriani and jdlrobson: Backport for [[gerrit:884055|Increase threshold for table of contents collapsing (T328045)]], [[gerrit:879664|Remove redundant block for search descriptions (T324859)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-26T21:47:53Z] <thcipriani@deploy1002> Finished scap: Backport for [[gerrit:884055|Increase threshold for table of contents collapsing (T328045)]], [[gerrit:879664|Remove redundant block for search descriptions (T324859)]] (duration: 08m 49s)

Change 884035 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Increase threshold for table of contents collapsing

https://gerrit.wikimedia.org/r/884035

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki, testwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: table of contents collapses at 28 rather than 20.

Screenshot 2023-01-31 at 3.32.51 PM.png (1×1 px, 516 KB)

Screenshot 2023-01-31 at 3.30.30 PM.png (1×1 px, 477 KB)

Screenshot 2023-01-31 at 3.31.52 PM.png (1×1 px, 529 KB)

Screenshot 2023-01-31 at 3.24.50 PM.png (1×1 px, 476 KB)

Looks good, resolving