Page MenuHomePhabricator

Verify impact of Design Systems Team's Codex Update on Web properties
Closed, ResolvedPublic

Description

Background

As part of the Jan 31 release, the Design Systems Team will be updating the Codex library with a change (see gerrit here) that has the potential to impact Web products. If all goes well, we intend for this change to ride the Feb 6 train.

The intended impact of this change is that font size will change in the typeahead search window and thumbnails will be getting smaller.

This is the web-side of this task, to capture testing and verifying the impact of this change on products we own, ensuring that we file bugs appropriately -- adding them as subtasks of this task (which has been dual-filed to both Web's Sprint Board and the DST board) and to be assessed and triaged by DST.

AC

  • Test all typeahead search use cases, especially those involving sizing and thumbnails
  • Test QuickSurveys to ensure it still functions and looks appropriate

(@Jdlrobson please update with additional use cases)

QA Results - Prod

ACStatusDetails
1aT328053#8616836
1bT328053#8616836

Related Objects

StatusSubtypeAssignedTask
Resolvedegardner
ResolvedNone
OpenNone
OpenNone
Duplicate STH
InvalidNone
ResolvedVolker_E
ResolvedCatrope
ResolvedVolker_E
ResolvedNone
Resolvedbmartinezcalvo
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
Resolvedldelench_wmf
ResolvedVolker_E
Resolved EUdoh-WMF
ResolvedSarai-WMDE
Resolved DAbad
ResolvedVolker_E
Resolvedbmartinezcalvo
Resolved KieranMcCann
OpenNone
DuplicateNone
ResolvedVolker_E
Resolved DAbad
ResolvedVolker_E
Resolved DAbad
ResolvedSarai-WMDE
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
ResolvedSarai-WMDE
ResolvedVolker_E
Resolvedbmartinezcalvo
ResolvedCatrope
Resolved DAbad
ResolvedVolker_E
OpenNone
ResolvedCatrope
Resolvedovasileva
ResolvedBUG REPORTVolker_E

Event Timeline

Restricted Application triaged this task as High priority. · View Herald TranscriptJan 26 2023, 5:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
NBaca-WMF reassigned this task from EUdoh-WMF to Edtadros.
NBaca-WMF added a subscriber: Edtadros.
NBaca-WMF added a subscriber: EUdoh-WMF.

@bwang FYI, I looked at https://pixel.wmcloud.org/reports/desktop/index.html a bit more, and I think the MediaWiki_Test_vector-2022_sidebar-open_collapsed-toc-open_0_viewport_0_phone.png test failure is actually not flaky — I can reproduce this locally — but still a false positive because I think it's intentional. It looks like the new focus results in the browser scrolling to the focused element which I think is the desired result from T325020?

2023-02-06_13-38-19.png (1×5 px, 349 KB)

Thanks @nray that makes sense to me, it looks like expected from T325020. All the other changes are also either from T325020 or from codex change. @Jdlrobson Ive also tested the updated search component with different levels of zoom and it looks good to me.

bwang removed bwang as the assignee of this task.Feb 6 2023, 11:24 PM
bwang moved this task from QA to Ready for Signoff on the Web-Team FY2022-23 Q3 Sprint 2 board.
bwang subscribed.

(We should check this again in production when it's live)

To QA in production I suggest some exploratory testing on production:

Test Result - Prod

Status: ✅ PASS
Environment: itwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1a: https://it.wikipedia.org/wiki/Special:Nearby

Screen Recording 2023-02-14 at 3.29.12 PM.mov.gif (824×1 px, 272 KB)

✅ AC1b: Search feature
Validated search UI, functionality, type ahead, and voice over for wide, narrow, and sticky header.

Screenshot 2023-02-14 at 3.30.05 PM.png (666×610 px, 170 KB)

Screenshot 2023-02-14 at 3.29.45 PM.png (658×598 px, 108 KB)

Screenshot 2023-02-14 at 3.31.00 PM.png (718×716 px, 140 KB)

Everything looks good! Resolving