11:16:58 There was 1 failure: 11:16:58 11:16:58 1) ResourcesTest::testUnsatisfiableDependencies 11:16:58 * The module 'ext.pageTriage.views.toolbar' must not have target 'mobile' because its dependency 'ext.pageTriage.externalTagsOptions' does not have it 11:16:58 11:16:58 Failed asserting that two arrays are equal. 11:16:58 --- Expected 11:16:58 +++ Actual 11:16:58 @@ @@ 11:16:58 Array ( 11:16:58 + 0 => 'ext.pageTriage.views.toolbar' 11:16:58 )
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web | |||
| Resolved | Jdlrobson | T127268 Dismantle ResourceLoader's "targets" system | |||
| Resolved | BUG REPORT | kostajh | T328500 ResourcesTest::testUnsatisfiableDependencies blocks CI on certain extensions | ||
| Resolved | kostajh | T328535 ResourcesTest::testUnsatisfiableDependencies: The module 'ext.pageTriage.views.toolbar' must not have target 'mobile' because its dependency 'ext.pageTriage.externalTagsOptions' does not have it |
Event Timeline
Comment Actions
Probably related to https://lists.wikimedia.org/hyperkitty/list/wikitech-l@lists.wikimedia.org/thread/4N7QWHBHZBRYSPQGGG5E4BZBYAYKKY4C/ if that helps.
This should be a harmless change, but may be unintentionally triggering failures in testUnsatisfiableDependencies tests as it seems some extension/skins are not included in the MediaWiki core PHPUnit test run. If you encounter this issue, the fix is relatively simple - you must define targets explicitly (see this example [6] and apologies in advance for any annoyance this may cause)
[6] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PropertySuggester/+/885432/
Comment Actions
Indeed, and we can fix it with setting the targets to desktop/mobile, but that feels like the wrong fix. AIUI, PageTriage currently models the "ideal state" of not defining any targets at all. I think the problem is that ExternalTagsOptions class extends RL\Module, and that one specifies default targets of 'desktop', whereas the other RL modules set targets of 'desktop' and 'mobile'. I'm not sure if that is intentional.
Comment Actions
Change 885788 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/core@master] Adjust default targets in RL/Module
Comment Actions
This should be fixed on the short term with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/885881
I'm creating a user notice/task to handle this on the long term (T328610).