Page MenuHomePhabricator

Toolforge: decide what to do with tools that have 'stretch' in their service manifests
Closed, ResolvedPublic

Description

I found some tools that have stretch in their service manifest:

Feb 14 12:18:28 tools-sgecron-2 collector-runner[4667]: 2023-02-14 12:18:28,884 Starting webservice for tool lalm
Feb 14 12:18:28 tools-sgecron-2 sudo[20118]:     root : TTY=unknown ; PWD=/ ; USER=tools.lalm ; COMMAND=/bin/bash -c /usr/bin/webservice --backend=gridengine --release=stretch restart
Feb 14 12:18:28 tools-sgecron-2 sudo[20118]: pam_unix(sudo:session): session opened for user tools.lalm by (uid=0)
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]: usage: webservice [-h] [--template TEMPLATE_FILE]
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]:                   [--backend {gridengine,kubernetes}]
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]:                   [--buildservice-image BUILDSERVICE_IMAGE]
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]:                   [--release {buster}] [-m MEMORY] [-c CPU] [-r REPLICAS]
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]:                   [TYPE] ACTION [... [... ...]]
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]: webservice: error: argument --release: invalid choice: 'stretch' (choose from 'buster')
Feb 14 12:18:29 tools-sgecron-2 sudo[20118]: pam_unix(sudo:session): session closed for user tools.lalm
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]: 2023-02-14 12:18:29,306 Could not start webservice for tool lalm
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]: Traceback (most recent call last):
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]:   File "/usr/lib/python3/dist-packages/tools/manifest/webservicemonitor.py", line 195, in _start_webservice
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]:     subprocess.check_output(command, timeout=30)  # 30 second timeout!
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]:   File "/usr/lib/python3.7/subprocess.py", line 395, in check_output
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]:     **kwargs).stdout
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]:   File "/usr/lib/python3.7/subprocess.py", line 487, in run
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]:     output=stdout, stderr=stderr)
Feb 14 12:18:29 tools-sgecron-2 collector-runner[4667]: subprocess.CalledProcessError: Command '['/usr/bin/sudo', '-i', '-u', 'tools.lalm', '/usr/bin/webservice', '--backend=gridengine', '--release=stretch', 'restart']' returned non-zero exit status 2.

File:

tools.lalm@tools-sgebastion-11:~$ cat service.manifest 
# This file is used by Toolforge infrastructure.
# Please do not edit manually at this time.
# Thu Jun 23 14:46:55 2022
backend: gridengine
release: stretch
version: 4
web: tomcat

I don't know off hand what is the best course of actions in this situation. Perhaps just declare the tool abandoned, unmaintained, or whatever

Event Timeline

aborrero updated the task description. (Show Details)
aborrero added a subscriber: bd808.
aborrero triaged this task as Lowest priority.Feb 14 2023, 12:27 PM
aborrero moved this task from Backlog to Waiting for information on the Toolforge board.

A reasonable approach here might be to try to start them as buster once, and if that fails shut it properly down (and if it's the only thing on the tool, file it as unmaintained somewhere?).

taavi claimed this task.
komla renamed this task from Toolforge: decide what to do with tools that have 'strecth' in their service manifests to Toolforge: decide what to do with tools that have 'stretch' in their service manifests.Mar 7 2023, 2:38 PM