Page MenuHomePhabricator
Create Task
Maniphest T332434

Update TemplateData for IP masking
Closed, ResolvedPublic
Actions

Description

Required changes identified in the review on T327570:

Details

SubjectRepoBranchLines +/-
Update TemplateDataEditor logging for IP maskingmediawiki/extensions/TemplateDatamaster+4 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Mar 17 2023, 6:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2023, 6:56 PM
matmarex added a parent task: T326876: Update Editing Team-owned products that may be affected by temporary users.Mar 17 2023, 6:59 PM
matmarex mentioned this in T327570: [SPIKE] Document the changes IP Masking will require the Editing Team to make.
Maintenance_bot added a project: VisualEditor.Mar 17 2023, 7:29 PM
matmarex added a project: Temporary accounts.Mar 23 2023, 3:21 PM
VPuffetMichel moved this task from To Triage to Triaged on the VisualEditor board.Mar 23 2023, 3:40 PM
gerritbot added a comment.Apr 11 2023, 7:47 PM

Change 907968 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/TemplateData@master] Update TemplateDataEditor logging for IP masking

https://gerrit.wikimedia.org/r/907968

gerritbot added a project: Patch-For-Review.Apr 11 2023, 7:47 PM
matmarex claimed this task.Apr 11 2023, 7:48 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
matmarex added a subtask: T332437: Change EditAttemptStep and other schemas and logging to support temp users.Apr 11 2023, 7:54 PM
matmarex updated the task description. (Show Details)Apr 11 2023, 8:20 PM
thiemowmde moved this task from Backlog to Doing on the TemplateData board.Apr 12 2023, 7:05 AM
thiemowmde added a project: WMDE-TechWish-Sprint-2023-04-05.
thiemowmde moved this task from Sprint Backlog to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2023-04-05 board.
thiemowmde added subscribers: awight, thiemowmde.
matmarex updated the task description. (Show Details)Apr 12 2023, 8:09 PM
matmarex removed a subtask: T332437: Change EditAttemptStep and other schemas and logging to support temp users.Apr 18 2023, 7:31 PM
gerritbot added a comment.Apr 21 2023, 11:32 AM

Change 907968 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Update TemplateDataEditor logging for IP masking

https://gerrit.wikimedia.org/r/907968

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2023, 12:12 PM
matmarex closed this task as Resolved.Apr 21 2023, 5:25 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.
matmarex added a project: Skipped QA.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 6:01 PM
ppelberg mentioned this in T344468: QA Editing-related IP Masking changes.Aug 17 2023, 10:23 PM
Ryasmeen edited projects, added Verified; removed Skipped QA.Sep 8 2023, 9:04 PM
Ryasmeen subscribed.

The events here are recorded server-side, so I am not seeing them being triggered from my browser.
I looked at two places: https://schema.wikimedia.org/repositories/secondary/jsonschema/analytics/legacy/templatedataeditor/latest.yaml and https://meta.wikimedia.org/wiki/Schema:TemplateDataEditor. I do not see user_is_temp there.

@matmarex confirmed it doesn't have a user_is_temp field, only user_id, which is 0 for logged-out and temp users and that's what the change was about.

That is all we can verify from our end.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL