Page MenuHomePhabricator
Create Task
Maniphest T332541

Replace mediawiki.ui variables with mediawiki.skin.variables
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Volker_E
Mar 20 2023, 8:45 AM
Tags
Referenced Files
None
Subscribers
AnneT
Catrope
CCiufo-WMF
Jdforrester-WMF
Jdlrobson
kostajh
ldelench_wmf
View All 12 Subscribers
Tokens
"Party Time" token, awarded by CCiufo-WMF.

Description

Background

Since MW v1.41.0 'mediawiki.skin.variables.less' features Codex design tokens. These are providing a themeable, scalable nomenclature and are following mediwiki.ui variables Wikimedia's stylesheet variable naming convention.

Goal

Replace 'mediawiki.ui/variables.less' @imports with 'mediawiki.skin.variables.less' and on the course also replace deprecated T319381 vars and static values where easily identifiable.

Benefits
  • Reduce design debt
  • Reduce technical debt
  • Ensure that single source of truth is clarified and established with Codex design tokens via skin variables
  • Extension developers benefit from skin aware tokens (vars). Extensions magically adapt to MW skins. The extent is still on extension author (for example only color tokens used, or everything)
Risks
  • The change requires MW v1.41, if your extension is required to be further backwards-compatible, please reach out to find intermediate solutions
  • As with every code change, there's a minimal chance of human error in token application. The patches provided should not result in visual change aside of a few major extension, where the known small changes are flagged.
Acceptance criteria for done

Related for mediawiki.skin.variables becoming single source of truth is T334934: [EPIC] Replace WikimediaUI Base variables with Codex design tokens (mediawiki.skin.variables)
The final step for mediawiki.ui/variables is tackled in T335822: Deprecate and remove mediawiki.ui variables

Details

SubjectRepoBranchLines +/-
styles: Replace old variables calls with skin variablesmediawiki/extensions/GrowthExperimentsmaster+537 -1 K
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/skins/MinervaNeuemaster+155 -197
ext.uls.mixins: Use LESS variables from skinmediawiki/extensions/UniversalLanguageSelectormaster+2 -2
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/ContentTranslationmaster+256 -241
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/UniversalLanguageSelectormaster+422 -80
styles: Use MediaWiki skin variables for all colors and bordersmediawiki/extensions/Graphmaster+5 -5
styles: Replace 'mediawiki.ui/variables' call with Codex design tokensmediawiki/extensions/Translatemaster+344 -20
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/Collectionmaster+17 -15
mediawiki.special: Replace mediawiki.ui variables with skin varsmediawiki/coremaster+4 -4
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/WikibaseLexememaster+33 -35
styles: Replace 'mediawiki.ui/variables'mediawiki/extensions/WikibaseQualityConstraintsmaster+27 -22
styles: Remove 'mediawiki.ui/variables' callmediawiki/skins/Vectormaster+36 -41
mediawiki.widgets, mediawiki.ui: Use skin variablesmediawiki/coremaster+238 -235
RCFilters: Use skin variablesmediawiki/coremaster+96 -98
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/SearchVuemaster+14 -11
styles: Remove unnecessary 'mediawiki.ui/variables' importmediawiki/extensions/CentralNoticemaster+0 -1
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/WikidataPageBannermaster+12 -7
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/AdvancedSearchmaster+25 -21
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/Wikisourcemaster+14 -12
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/CampaignEventsmaster+29 -24
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/ExternalGuidancemaster+16 -16
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/Flowmaster+174 -141
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/Echomaster+76 -78
styles: Replace old variables calls with skin variablesmediawiki/extensions/MultimediaViewermaster+50 -55
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/TemplateWizardmaster+11 -11
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/RelatedArticlesmaster+9 -9
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/CheckUsermaster+28 -25
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/Kartographermaster+2 -2
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/IPInfomaster+6 -11
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/MobileFrontendmaster+121 -121
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/InputBoxmaster+6 -6
mediawiki.special: Replace 'mediawiki.ui/variables' call with skin varsmediawiki/coremaster+102 -89
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/CirrusSearchmaster+14 -14
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/WikiEditormaster+49 -36
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/Inboxmaster+3 -3
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/FileImportermaster+10 -10
styles: Remove 'mediawiki.ui/variables' entirelymediawiki/skins/Metrolookmaster+2 -8
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/Popupsmaster+43 -33
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/Wikistoriesmaster+121 -114
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/MsUploadmaster+25 -26
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/QuickSurveysmaster+6 -6
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/EntitySchemamaster+12 -12
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/DiscussionToolsmaster+27 -35
mediawiki.less: Provide comments on mediawiki.ui gray color replacementsmediawiki/coremaster+16 -2
mediawiki.less: Deprecate Codex design tokens replaced variablesmediawiki/coremaster+58 -33
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/Wikistoriesmaster+2 -2
styles: Replace 'mediawiki.ui/variables' call with skin variablesmediawiki/extensions/CampaignEventsmaster+5 -5
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Apr 19 2023, 2:23 PM

Change 909744 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909744

gerritbot added a comment.Apr 19 2023, 2:25 PM

Change 904254 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904254

gerritbot added a comment.Apr 19 2023, 2:25 PM

Change 909723 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909723

gerritbot added a comment.Apr 19 2023, 2:25 PM

Change 904257 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] styles: Replace old variables calls with skin variables

https://gerrit.wikimedia.org/r/904257

gerritbot added a comment.Apr 19 2023, 4:10 PM

Change 906773 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906773

Volker_E updated the task description. (Show Details)Apr 19 2023, 4:17 PM
Volker_E added a project: MediaViewer.Apr 19 2023, 4:29 PM
Volker_E updated the task description. (Show Details)
CCiufo-WMF subscribed.EditedApr 19 2023, 7:08 PM

@Volker_E just confirming -- this should be in "Code Review" not "Blocked" on the sprint board, right?

or is it blocked on T334790?

gerritbot added a comment.Apr 20 2023, 8:25 AM

Change 910420 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/AdvancedSearch@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/910420

Volker_E added a subscriber: ldelench_wmf.Apr 20 2023, 1:22 PM

@CCiufo-WMF In the past if we haven't had full control about dependencies, in this case needing other teams to review the patches and agree with the architecture, we've put tasks into the “Blocked” column. Only if we alone are responsible to get it through the sprint process steps, it was supposed to move cols. Has anything been clarified around this take @ldelench_wmf?

gerritbot added a comment.Apr 20 2023, 1:53 PM

Change 904886 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904886

gerritbot added a comment.Apr 20 2023, 2:08 PM

Change 909666 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/909666

gerritbot added a comment.Apr 20 2023, 2:08 PM

Change 910420 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/910420

Volker_E updated the task description. (Show Details)Apr 20 2023, 2:29 PM
Volker_E updated the task description. (Show Details)Apr 20 2023, 2:41 PM
Volker_E closed subtask T333811: Echo: Replace mediawiki.ui variables with mediawiki.skin.variables as Resolved.Apr 21 2023, 2:41 PM
gerritbot added a comment.Apr 22 2023, 1:20 PM

Change 910821 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CentralNotice@master] styles: Remove unnecessary 'mediawiki.ui/variables' import

https://gerrit.wikimedia.org/r/910821

Volker_E added a project: MediaWiki-extensions-CentralNotice.Apr 22 2023, 1:36 PM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Apr 22 2023, 2:54 PM

Change 910821 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] styles: Remove unnecessary 'mediawiki.ui/variables' import

https://gerrit.wikimedia.org/r/910821

Volker_E updated the task description. (Show Details)Apr 22 2023, 3:30 PM
gerritbot added a comment.Apr 23 2023, 1:56 PM

Change 910865 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Remove 'mediawiki.ui/variables' call

https://gerrit.wikimedia.org/r/910865

Volker_E added a comment.Apr 23 2023, 9:30 PM

Also provided a patch for Github-based ProfessionalWiki/WikibaseRDF.

Volker_E updated the task description. (Show Details)Apr 23 2023, 9:57 PM
Restricted Application added a subscriber: Lens0021. · View Herald TranscriptApr 23 2023, 9:57 PM
ldelench_wmf added a comment.Apr 24 2023, 2:58 PM

Sounds like "blocked" and "code review" both work here if we're blocked on code reviews from other teams.

Volker_E updated the task description. (Show Details)Apr 24 2023, 4:36 PM
gerritbot added a comment.Apr 25 2023, 4:50 PM

Change 906786 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906786

Volker_E mentioned this in rESVU4bfd1e4b4f51: styles: Replace 'mediawiki.ui/variables' call with skin variables.Apr 25 2023, 4:51 PM
Volker_E updated the task description. (Show Details)Apr 25 2023, 5:33 PM
gerritbot added a comment.Apr 25 2023, 6:49 PM

Change 908519 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.widgets, mediawiki.ui: Use skin variables

https://gerrit.wikimedia.org/r/908519

gerritbot added a comment.Apr 25 2023, 6:49 PM

Change 909245 merged by jenkins-bot:

[mediawiki/core@master] RCFilters: Use skin variables

https://gerrit.wikimedia.org/r/909245

Volker_E updated the task description. (Show Details)Apr 25 2023, 7:59 PM
gerritbot added a comment.Apr 25 2023, 11:01 PM

Change 910865 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Remove 'mediawiki.ui/variables' call

https://gerrit.wikimedia.org/r/910865

Volker_E updated the task description. (Show Details)Apr 25 2023, 11:33 PM
gerritbot added a comment.Apr 25 2023, 11:41 PM

Change 906791 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906791

gerritbot added a comment.Apr 28 2023, 10:01 AM

Change 900810 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] styles: Replace 'mediawiki.ui/variables'

https://gerrit.wikimedia.org/r/900810

gerritbot added a comment.Apr 28 2023, 10:39 AM

Change 906785 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/906785

Volker_E updated the task description. (Show Details)Apr 28 2023, 11:03 AM
gerritbot added a comment.Apr 28 2023, 11:32 AM

Change 913145 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.special: Replace mediawiki.ui variables with skin vars

https://gerrit.wikimedia.org/r/913145

gerritbot added a comment.Apr 28 2023, 12:13 PM

Change 913145 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.special: Replace mediawiki.ui variables with skin vars

https://gerrit.wikimedia.org/r/913145

gerritbot added a comment.Apr 28 2023, 4:11 PM

Change 904252 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904252

Volker_E added a project: Collection.Apr 28 2023, 4:13 PM
Volker_E updated the task description. (Show Details)
Lens0021 updated the task description. (Show Details)Apr 28 2023, 4:30 PM
Lens0021 unsubscribed.
Volker_E added a subscriber: Lens0021.Apr 28 2023, 8:12 PM

Thanks @Lens0021!

gerritbot added a comment.Apr 29 2023, 5:43 PM

Change 913634 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/ContentTranslation@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/913634

Jdlrobson unsubscribed.May 1 2023, 4:15 PM
PatchDemoBot added a comment.May 2 2023, 12:04 PM

Test wiki created on Patch demo by KHarlan (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/cfdfa13682/w

Volker_E added a project: MediaWiki-extensions-Translate.May 2 2023, 4:11 PM
Volker_E updated the task description. (Show Details)
Volker_E mentioned this in T335822: Deprecate and remove mediawiki.ui variables.May 2 2023, 10:00 PM
gerritbot added a comment.May 3 2023, 9:52 AM

Change 914725 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Graph@master] styles: Use MediaWiki skin variables for all colors and borders

https://gerrit.wikimedia.org/r/914725

gerritbot added a comment.May 3 2023, 12:14 PM

Change 909722 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] styles: Replace 'mediawiki.ui/variables' call with Codex design tokens

https://gerrit.wikimedia.org/r/909722

Volker_E updated the task description. (Show Details)May 3 2023, 2:41 PM
gerritbot added a comment.May 3 2023, 3:34 PM

Change 914725 merged by jenkins-bot:

[mediawiki/extensions/Graph@master] styles: Use MediaWiki skin variables for all colors and borders

https://gerrit.wikimedia.org/r/914725

gerritbot added a comment.May 4 2023, 4:44 AM

Change 904259 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/904259

gerritbot added a comment.May 4 2023, 5:02 AM

Change 915101 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ext.uls.mixins: Use LESS variables from skin

https://gerrit.wikimedia.org/r/915101

Volker_E updated the task description. (Show Details)May 4 2023, 9:44 AM
Volker_E updated the task description. (Show Details)May 4 2023, 9:58 AM
Volker_E updated the task description. (Show Details)May 4 2023, 11:10 AM
gerritbot added a comment.May 4 2023, 11:28 AM

Change 913634 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] styles: Replace 'mediawiki.ui/variables' call with skin variables

https://gerrit.wikimedia.org/r/913634

Jdlrobson mentioned this in T335932: mw-tag-marker border radius too small on mobile versions.May 4 2023, 2:01 PM
gerritbot added a comment.May 4 2023, 2:26 PM

Change 915101 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ext.uls.mixins: Use LESS variables from skin

https://gerrit.wikimedia.org/r/915101

Jdlrobson added a comment.May 4 2023, 10:27 PM

Hey @Volker_E this seems to have caused a UI regression: T335932. Could you please take a look?

ldelench_wmf added a subtask: T335932: mw-tag-marker border radius too small on mobile versions.May 5 2023, 4:10 PM
Volker_E added a subscriber: Jdlrobson.May 6 2023, 8:20 PM
In T332541#8828458, @Jdlrobson wrote:

Hey @Volker_E this seems to have caused a UI regression: T335932. Could you please take a look?

Fixed!

Volker_E closed subtask T335932: mw-tag-marker border radius too small on mobile versions as Resolved.May 9 2023, 1:45 PM
Jdlrobson removed a project: MediaViewer.May 9 2023, 7:22 PM
gerritbot added a comment.May 10 2023, 5:43 PM

Change 901217 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] styles: Replace old variables calls with skin variables

https://gerrit.wikimedia.org/r/901217

Volker_E closed subtask T319381: Replace or remove deprecated mediawiki.ui Less variables as Resolved.May 10 2023, 6:09 PM
Volker_E removed a subtask: T332567: GrowthExperiments: Replace 'mediawiki.ui/variables' and WikimediaUI Base with skin variables and clarify resulting design questions.May 10 2023, 9:25 PM
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
Volker_E mentioned this in T334934: [EPIC] Replace WikimediaUI Base variables with Codex design tokens (mediawiki.skin.variables).May 11 2023, 6:11 AM
Volker_E closed this task as Resolved.May 11 2023, 10:38 PM
Volker_E claimed this task.
Volker_E updated the task description. (Show Details)

Successfully resolved! ✨

Volker_E updated the task description. (Show Details)May 11 2023, 10:42 PM
Volker_E moved this task from Blocked ⛔ to Product Sign-Off on the Design-System-Team (Design-System-Sprint) board.May 11 2023, 11:20 PM
CCiufo-WMF awarded a token.May 12 2023, 12:47 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.9; 2023-05-15); removed MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).May 15 2023, 2:47 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.10; 2023-05-23); removed MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 16 2023, 7:02 AM
PatchDemoBot added a comment.Jul 3 2023, 1:37 PM

Test wiki on Patch demo by KHarlan (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/cfdfa13682/w/

happy5214 moved this task from Backlog to Closed on the WikiEditor board.Jul 31 2023, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL