Page MenuHomePhabricator
Create Task
Maniphest T332985

Reduce kartotherian empty group logspam caused by Wikivoyage
Closed, ResolvedPublic
Actions

Description

On Wikivoyage wikis it's common to configure mapframes using templates or modules so that they try to display all commonly used groups even if they are empty. This behavior leads to the vast majority of logspam in the kartotherian logs when the requested groups are empty.

Received failed group: Error: Received empty response for group "Ausgehen"

Note, that the Received empty response for group error originates from the mapdata lib and is forwarded to kartotherian where it's logged. Let's not trigger/log these warnings, when the group is named. The cases relevant to us are these where the group id is a hash.

See also https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Kartographer/+/834353/

Details

SubjectRepoBranchLines +/-
Reduce logspam for empty groupsmediawiki/services/kartotherianmaster+8 -8
Reduce logspam for empty groupsmediawiki/extensions/Kartographermaster+26 -17
Properly track the names of empty/failed groupsmapdatamaster+7 -2
Reduce logspam for empty groupsmapdatamaster+9 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Mar 24 2023, 12:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2023, 12:27 PM
WMDE-Fisch updated the task description. (Show Details)Mar 24 2023, 12:32 PM
WMDE-Fisch moved this task from Incoming to Backlog on the WMDE-TechWish-Maintenance board.
gerritbot added a comment.Apr 4 2023, 1:51 PM

Change 905639 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mapdata@master] Reduce logspam for empty groups

https://gerrit.wikimedia.org/r/905639

gerritbot added a project: Patch-For-Review.Apr 4 2023, 1:52 PM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2023-04-19.Apr 20 2023, 8:05 AM
gerritbot added a comment.Apr 20 2023, 8:49 AM

Change 910422 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] [POC] Reduce logspam for empty groups

https://gerrit.wikimedia.org/r/910422

gerritbot added a comment.Apr 20 2023, 8:55 AM

Change 910423 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mapdata@master] Properly track the names of empty/failed groups

https://gerrit.wikimedia.org/r/910423

gerritbot added a comment.Apr 20 2023, 9:00 AM

Change 910424 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/services/kartotherian@master] Reduce logspam for empty groups

https://gerrit.wikimedia.org/r/910424

WMDE-Fisch moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2023-04-19 board.Apr 20 2023, 11:51 AM
WMDE-Fisch added a parent task: T331977: Deploy recent map server work to production ( May 2023 ).May 3 2023, 7:27 AM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2023-05-03.May 3 2023, 8:06 AM
Lena_WMDE moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2023-05-03 board.May 3 2023, 8:06 AM
gerritbot added a comment.May 4 2023, 11:04 AM

Change 910423 merged by jenkins-bot:

[mapdata@master] Properly track the names of empty/failed groups

https://gerrit.wikimedia.org/r/910423

gerritbot added a comment.May 4 2023, 11:05 AM

Change 905639 abandoned by WMDE-Fisch:

[mapdata@master] Reduce logspam for empty groups

Reason:

Better approach in Id42c2b2bb2864f44ca046c55b67df37a2255fbee

https://gerrit.wikimedia.org/r/905639

gerritbot added a comment.May 5 2023, 12:35 PM

Change 910422 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Reduce logspam for empty groups

https://gerrit.wikimedia.org/r/910422

WMDE-Fisch moved this task from Tech Review to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2023-05-03 board.May 8 2023, 4:35 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 12:01 PM
thiemowmde moved this task from Backlog to In progress on the WMDE-TechWish-Maintenance board.May 17 2023, 8:27 AM
gerritbot added a comment.Jun 16 2023, 6:06 AM

Change 910424 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Reduce logspam for empty groups

https://gerrit.wikimedia.org/r/910424

WMDE-Fisch mentioned this in rMSKAc3116417d1ae: Reduce logspam for empty groups.Jun 16 2023, 6:06 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 16 2023, 6:10 AM
Stashbot mentioned this in T329924: Update kartotherian to use mapdata 0.9.0 (external data is expanded in-place).Aug 1 2023, 5:05 PM
Stashbot mentioned this in T332664: Kartotherian "Cannot read property 'coordinates' of null".
Stashbot mentioned this in T334668: Host sprites and glyphs in kartotherian for Android WebGL map.

Mentioned in SAL (#wikimedia-operations) [2023-08-01T17:05:19Z] <mbsantos@deploy1002> Started deploy [kartotherian/deploy@ee544cb]: Update kartotherian to e28ea7ef (T334668 T332985 T332664 T329924)

Stashbot added a comment.Aug 1 2023, 5:09 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-01T17:09:44Z] <mbsantos@deploy1002> Finished deploy [kartotherian/deploy@ee544cb]: Update kartotherian to e28ea7ef (T334668 T332985 T332664 T329924) (duration: 04m 25s)

WMDE-Fisch closed this task as Resolved.Aug 7 2023, 5:13 PM

Thanks for the deployment. ~50% less log spam \o/

WMDE-Fisch mentioned this in T331977: Deploy recent map server work to production ( May 2023 ).Aug 7 2023, 5:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL