Post-edit dialog for non-suggested edits should not appear on user page edits
Closed, ResolvedPublicBUG REPORT
Actions

Description

While testing another patch, I noticed that I am seeing the "try suggested edits" dialog while editing another user's user page.

Details

	Subject	Repo	Branch	Lines +/-
	Leveling up: Only show try suggested edits dialog on articles	mediawiki/extensions/GrowthExperiments	master	+13 -11

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		KStoller-WMF	T248330 [EPIC] Growth: Positive reinforcement
Open		None	T317813 [EPIC] Positive Reinforcement: Leveling Up
Resolved		Tgr	T322387 New post-edit dialog for non-suggested edits
Resolved	BUG REPORT	Tgr	T333658 Post-edit dialog for non-suggested edits should not appear on user page edits

Event Timeline

kostajh renamed this task from Post-edit dialog for non-suggseted edits should not appear on user page edits to Post-edit dialog for non-suggested edits should not appear on user page edits.Mar 31 2023, 9:09 AM

kostajh created this task.

kostajh changed the subtype of this task from "Task" to "Bug Report".

The fix for this would probably also address T332582: Avoid showing the Try New Task panel on the history page.

In T333658#8745405, @kostajh wrote:

The fix for this would probably also address T332582: Avoid showing the Try New Task panel on the history page.

It wouldn't, the "try new task" and "try suggested edits" dialogs are triggered in very different ways.

Tgr claimed this task.Apr 3 2023, 8:28 AM

Tgr moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 905749 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Leveling up: Only show try suggested edits dialog on articles

https://gerrit.wikimedia.org/r/905749

gerritbot added a project: Patch-For-Review.Apr 4 2023, 9:43 PM

Tgr moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 4 2023, 9:43 PM

In T333658#8749420, @Tgr wrote:

In T333658#8745405, @kostajh wrote:

The fix for this would probably also address T332582: Avoid showing the Try New Task panel on the history page.

It wouldn't, the "try new task" and "try suggested edits" dialogs are triggered in very different ways.