Page MenuHomePhabricator

Support Special:MyLanguage/ in editIntro parameter
Closed, ResolvedPublicFeature

Description

Feature summary:
Given a translatable EditIntroTemplate English page.

With the following URL, I would like the edit intro to be in my user interface language or in an appropriate fallback language chen there is no translation for my language:
index.php?action=edit&editintro=Special:MyLanguage/EditIntroTemplate&title=My_new_page

The same feature has already been implemented for preload param in T299544.

Use case(s):
Provide guidelines in user language about how to edit the page.

Grants already use a workaround

Benefits:
The workaround ({{#ifexist:EditIntroTemplate/{{PAGELANGUAGE}} |EditIntroTemplate/{{PAGELANGUAGE}} | EditIntroTemplate }}) does not allow to benefit from language fallback chain.

Event Timeline

Why did you tag the Language team?

I'd speculate that they thought your team owns the i18n and user language system inside MediaWiki, including Special:MyLanguage/ etc. routing controls, which https://www.mediawiki.org/wiki/Developers/Maintainers#MediaWiki_core says. Is this not the case?

Indeed, I only tag Language team for a more precise triaging, given I was not sure about what project tags to add.

Anyway, I think this is actually something the Editing team would oversee in practice; happy to write a quick patch.

Change 909702 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Support Special:MyPage for editIntro param too

https://gerrit.wikimedia.org/r/909702

Change 909703 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] EditPage: Support Special:MyLanguage for editIntro param

https://gerrit.wikimedia.org/r/909703

Why did you tag the Language team?

I'd speculate that they thought your team owns the i18n and user language system inside MediaWiki, including Special:MyLanguage/ etc. routing controls, which https://www.mediawiki.org/wiki/Developers/Maintainers#MediaWiki_core says. Is this not the case?

Yes and no. More detailed information is on https://phabricator.wikimedia.org/project/profile/18/#repos which says we are not working on that area even though we probably are considered de facto maintainers of it.

Adding Language-Team tag is appropriate for non-urgent tasks and we will look at that board in our triage meetings. After we triage a task and find a "home" for it, we remove the team tag, unless we plan to work on it in the same quarter.

I asked the question to see if there are implicit expectations about us doing something about the task – information that is good to know while triaging.

Does DiscussionTools need to be updated to support this, or does the VisualEditor patch resolve this in DT as well?

DiscussionTools uses VisualEditor's API for fetching edit notices, because there isn't one in core (T45683). (Ugh…) (Mobile apps do as well… ughhhh…)

Change 909703 merged by jenkins-bot:

[mediawiki/core@master] EditPage: Support Special:MyLanguage for editIntro param

https://gerrit.wikimedia.org/r/909703

Change 909702 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Support Special:MyLanguage for editIntro param too

https://gerrit.wikimedia.org/r/909702

DiscussionTools uses VisualEditor's API for fetching edit notices, because there isn't one in core (T45683). (Ugh…) (Mobile apps do as well… ughhhh…)

Yeah, horrible cruft is horrible. Once T157658 is done this'll all be trivial, right? ;-(

matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.
matmarex added a project: Skipped QA.
matmarex moved this task from Incoming to Ready for Sign Off on the Editing-team (Kanban Board) board.