Page MenuHomePhabricator
Create Task
Maniphest T336001

Mobile post-edit notifications have two versions
Closed, ResolvedPublic
Actions

Description

Mobile post-edit notifications have two versions:

  • If you edit using the mobile JS wikitext editor, you'll see:
    image.png (2×1 px, 75 KB)
  • If you edit using the non-JS wikitext editor (used for workflows not supported by the JS editor, e.g. undoing edits), you'll see:
    image.png (2×1 px, 73 KB)

Note that the icon is misplaced in the second one.

Furthermore, if any other notification is shown, they will overlap:

image.png (2×1 px, 94 KB)

Details

SubjectRepoBranchLines +/-
editor: Use core post-edit notificationsmediawiki/extensions/MobileFrontendmaster+38 -47
Improve styles for mw.notify and post-edit messagesmediawiki/skins/MinervaNeuemaster+20 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.May 4 2023, 7:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2023, 7:10 PM
matmarex claimed this task.May 4 2023, 7:10 PM
matmarex moved this task from Backlog to Team:Editing on the MobileFrontend board.
matmarex added a project: Editing-team (Kanban Board).
matmarex added parent tasks: T158181: Aim for workflow equivalence for MediaWiki on desktop and mobile web, T332433: Update page editing features in MobileFrontend for IP masking.May 4 2023, 7:59 PM
gerritbot added a comment.May 4 2023, 8:24 PM

Change 915839 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Improve styles for mw.notify and post-edit messages

https://gerrit.wikimedia.org/r/915839

gerritbot added a project: Patch-For-Review.May 4 2023, 8:24 PM

Change 915840 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] editor: Use core post-edit notifications

https://gerrit.wikimedia.org/r/915840

matmarex moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.May 4 2023, 8:31 PM
gerritbot added a comment.May 5 2023, 4:14 PM

Change 915839 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Improve styles for mw.notify and post-edit messages

https://gerrit.wikimedia.org/r/915839

gerritbot added a comment.May 9 2023, 5:55 PM

Change 915840 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] editor: Use core post-edit notifications

https://gerrit.wikimedia.org/r/915840

Maintenance_bot removed a project: Patch-For-Review.May 9 2023, 6:10 PM
matmarex moved this task from Doing to QA on the Editing-team (Kanban Board) board.May 10 2023, 1:42 AM
matmarex added a project: Editing QA.
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.May 10 2023, 9:45 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 1:02 PM
matmarex closed this task as Resolved.May 17 2023, 4:11 PM
matmarex mentioned this in T217264: Mobile UI states edit saved when doing dummy edits.May 20 2023, 10:19 AM
ppelberg mentioned this in T344468: QA Editing-related IP Masking changes.Aug 17 2023, 10:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL