Page MenuHomePhabricator

Review the rules for notifications sent when a new mentor is assigned to a given user
Closed, ResolvedPublic

Description

Reassigning mentors sends a notification to their mentees.
The table listing relations between mentors and mentees lists a mentor for everyone who hasn't opted-out mentorship.
Sometimes these mentees are not aware of the existence of their mentor until they get a notification about their new mentor. It creates surprise.

Following what was done for T335462: Claim mentee sends notification to users without access to mentorship, we should have stricter rules when reassigning mentors.

We shouldn't send a reassignment notification to:

  • accounts who opted-out mentorship (already covered)
  • accounts created before mentorship deployment at a given wiki, except if they visited their homepage
  • accounts who never accessed their homepage

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 937897 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] ChangeMentor: Refactor the notification conditions

https://gerrit.wikimedia.org/r/937897

Change 937897 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ChangeMentor: Refactor the notification conditions

https://gerrit.wikimedia.org/r/937897

Change 940462 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.18] ChangeMentor: Refactor the notification conditions

https://gerrit.wikimedia.org/r/940462

Change 940462 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.18] ChangeMentor: Refactor the notification conditions

https://gerrit.wikimedia.org/r/940462

Mentioned in SAL (#wikimedia-operations) [2023-07-24T07:33:05Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:940462|ChangeMentor: Refactor the notification conditions (T336875)]]

Mentioned in SAL (#wikimedia-operations) [2023-07-24T07:40:08Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:940462|ChangeMentor: Refactor the notification conditions (T336875)]] (duration: 07m 02s)