Prevent Thanks from setting preferences for temporary accounts
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• AGueyte
	May 31 2023, 11:46 AM

Description

Following T335971, it appears the extension is saving preferences for temporary users.
Update the code to treat temporary users like anon users.

Wherever these do something different based on whether a user is anonymous or registered, they may need updating (including comments).

Tests and comments should also be updated.

Notes
To help with searching:

In PHP preferences are saved via UserOptionsManager::saveOptions
In JS preferences are saved via methods defined on options.js: https://gerrit.wikimedia.org/g/mediawiki/core/+/809d4c9a9dd2cff6321cdae7a41e75b6c362cbbd/resources/src/mediawiki.api/options.js

	Subject	Repo	Branch	Lines +/-
	Hooks: Don't set Echo options for temp users	mediawiki/extensions/Thanks	master	+1 -1

Status	Assigned	Task
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 Update features for temporary accounts
Open	KStoller-WMF	T326877 [Epic] Update Growth Team-owned products that may be affected by IP Masking
Resolved	• AGueyte	T335971 Prevent extensions from setting preferences for temporary accounts
Resolved	kostajh	T337851 Prevent Thanks from setting preferences for temporary accounts

Change 925680 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Thanks@master] Hooks: Don't set Echo options for temp users

Change 925680 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] Hooks: Don't set Echo options for temp users