Page MenuHomePhabricator
Create Task
Maniphest T338824

Bitu is not responsive
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Navigate to idm.wikimedia.org on a mobile device

What happens?:

image.png (1×708 px, 52 KB)

What should have happened instead?:

  • All of the page contents are visible
  • Clicking the hamburger menu button on the top right corner does something

Software version (skip for WMF-hosted wikis like Wikipedia): n/a

Other information (browser name/version, screenshots, etc.): Screenshot taken using Firefox 102.11.0esr developer tools, but I can also reproduce using Safari on iOS 16.5.

Details

SubjectRepoBranchLines +/-
Implement Codex design, from design team.operations/software/bitumaster+528 -141
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT189531 All Wikimedia developer services should use single sign-on
 OpenNoneT363125 sustainability of wikitech.wikimedia.org
 OpenNoneT161859 Make Wikitech an SUL wiki
 OpenSLyngshede-WMFT163478 Allow viewing/searching LDAP account creations including date
 ResolvedNoneT153821 wikitech.wikimedia.org missing from pageviews API
 OpenNoneT148048 Store Wikimedia unified account name (SUL) in LDAP directory
 Open• taaviT359428 Striker should use ID instead of username to identify SUL accounts
 OpenNoneT237773 Move Wikitech onto the production MW cluster
 ResolvedMarosteguiT167973 Move database for wikitech (labswiki) to a main cluster section
 ResolvedAndrewT188029 Move labswiki database to m5
ResolvedMarosteguiT282074 Audit labswiki grants
 ResolvedAndrewT282209 Enable connection from labweb1001/labweb1002 to s6
 DeclinedAndrewT282573 Move labweb/cloudweb hosts to private IPs
 ResolvedAndrewT284106 Replicate & sanitize wikitech data
 ResolvedAndrewT284108 Bring labswiki database tables up to date
 ResolvedLadsgroupT269348 wikitech database has almost all of its varbinary fields wrong
 DuplicateNoneT284736 Create views on labswiki on clouddb* hosts
 Resolved• BstormT287442 Create views for labswiki (wikitech)
 DeclinedNoneT237889 Install php-ldap on all MW appservers
 Resolved• taaviT237890 Remove and empty useless user groups
 ResolvedJdforrester-WMFT196466 Remove 'shell user' right on wikitech
 DeclinedNoneT246405 On wikitech, make sysops unable to edit site JS, and then retire contentadmin
 OpenjijikiT292707 Migrate Wikitech to Kubernetes
 OpenNoneT359551 Replace wikitech as source of two-factor auth protection for developer accounts
 OpenFeatureNoneT359554 Use IDP for authentication in Striker
 StalledFeatureNoneT359590 Use IDP for authentication in Horizon
 OpenFeatureSLyngshede-WMFT359552 Enable self-service IDP two-factor authentication management
 OpenNoneT359820 Add developer account (un)blocking support to Bitu
 OpenAndrewT360795 Set up a bitu instance for codfw1dev
 OpenSLyngshede-WMFT362128 Site: 1 VM for codfw1dev bitu deployment
 ResolvedABran-WMFT362619 Database request for Bitu Cloud DEV installation
 Resolved• taaviT360883 Disable email address changes in Wikitech
 OpenNoneT364605 Move Striker to Bitu username validation API
 In ProgressSLyngshede-WMFT362318 Add Bitu container to Striker development environment
 ResolvedPRODUCTION ERRORTgrT195253 Special:Notifications gives a consistent PHP exception on load ("The trash icon is not registered") for users with OpenStackManager notifications
 OpenNoneT106123 Extensions needing to be removed from Wikimedia wikis
 Resolvedbd808T53642 Get rid of SemanticMediaWiki/SRF/SF from wikitech.wikimedia.org
 ResolvedyuvipandaT103995 Build a simple tool to query which instances have which roles / puppet variables
 Resolvedbd808T161662 Replace SMW data on project instances with a tool using the OpenStack APIs
 Resolvedbd808T162508 Implement Tool Labs membership application and processing in Striker
 Resolvedbd808T164787 Keystone permissions exception when trying to approve Tool Labs membership request via Striker
 Open• taaviT161553 Remove OpenStackManager from Wikitech
 Resolved• taaviT196171 Developer account creation without OpenStackManager
 DeclinedNoneT179463 Create a single application to provision and manage developer (LDAP) accounts
 OpenNoneT319405 Create an IDM for Wikimedia developer accounts
 OpenSLyngshede-WMFT320801 Build-out for self service
 ResolvedSLyngshede-WMFT320802 Create a mockup and involve designers
 ResolvedBUG REPORTSLyngshede-WMFT338824 Bitu is not responsive

Event Timeline

• taavi created this task.Jun 12 2023, 5:00 PM
Restricted Application added a project: Infrastructure-Foundations. · View Herald TranscriptJun 12 2023, 5:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TheresNoTime renamed this task from Bitu is not responsible to Bitu is not responsive.Jun 12 2023, 10:09 PM
SLyngshede-WMF added a parent task: T320802: Create a mockup and involve designers.Jun 29 2023, 10:05 AM
SLyngshede-WMF changed the task status from Open to In Progress.Sep 29 2023, 11:09 AM
SLyngshede-WMF claimed this task.
SLyngshede-WMF triaged this task as Medium priority.
gerritbot added a comment.Sep 29 2023, 11:09 AM

Change 962003 had a related patch set uploaded (by Slyngshede; author: Slyngshede):

[operations/software/bitu@master] Implement Codex design, from design team.

https://gerrit.wikimedia.org/r/962003

gerritbot added a project: Patch-For-Review.Sep 29 2023, 11:09 AM
gerritbot added a comment.Oct 4 2023, 1:47 PM

Change 962003 merged by Slyngshede:

[operations/software/bitu@master] Implement Codex design, from design team.

https://gerrit.wikimedia.org/r/962003

Maintenance_bot removed a project: Patch-For-Review.Oct 4 2023, 2:11 PM
SLyngshede-WMF added a subscriber: Ladsgroup.Oct 6 2023, 10:14 AM

@taavi / @Ladsgroup Responsive design based on Codex is now live at https://idm-test.wikimedia.org

Feedback is much appreciated :-)

Ladsgroup added a comment.Oct 6 2023, 12:38 PM

Slightly unrelated, the padding in the button is wrong in desktop

image.png (48×323 px, 4 KB)

Otherwise looks good.

SLyngshede-WMF added a comment.Oct 6 2023, 12:40 PM

Wonky... Which browser?

Ladsgroup added a comment.Oct 6 2023, 12:49 PM

firefox

• taavi added a comment.Oct 6 2023, 1:07 PM

Why is it loading the styles from and leaking user IPs to a third party CDN?

SLyngshede-WMF added a comment.Oct 9 2023, 7:22 AM

@taavi That is a really good point. Technically that is how the design team suggests using Codex, if you can't use/won't use VueJS. It won't work when we build the Debian package anyway, so I'll just pull in the styling and serve it locally.

I've also raised the CDN issue with the design team and asked that they distribute the CSS version for Codex as a download from our own website for future releases.

The test installation have been updated and now serves the Codex style sheet locally.

SLyngshede-WMF closed this task as Resolved.Nov 6 2023, 9:22 AM

We still have a little feedback from the design team to integrate, but overall Bitu is not responsive.

CSS has been pulled in and is served locally, rather than via a third-party CDN.

SLyngshede-WMF moved this task from Backlog to Resolved on the Bitu board.Apr 11 2024, 10:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL