Page MenuHomePhabricator
Create Task
Maniphest T339104

Create feature flag to always show `mul` in “in more languages” section of desktop termbox
Closed, ResolvedPublic
Actions

Description

After T339103: Show MUL as last language in Termbox if any MUL terms exist is done, we should introduce a feature flag which, when enabled, will cause mul to always be shown as the last language in the “in more languages” section of the desktop termbox, regardless of whether there are any existing mul terms or not.

This means that the “soft rollout” of T316767 is the default behavior, and the new feature flag is used to opt out of the soft rollout into the “after soft rollout” phase.

This feature flag will be toggled in production in context of T312176.
It will be removed from our code base again in context of T330217.

Details

SubjectRepoBranchLines +/-
Beta-Wikidata: Always show mul on desktop Termboxoperations/mediawiki-configmaster+11 -0
Always show `mul` in the desktop Termbox, depending on the feature flagmediawiki/extensions/Wikibasemaster+68 -7
Add feature flag to always show MUL in Termbox (PHP)mediawiki/extensions/Wikibasemaster+38 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 14 2023, 10:38 AM
ItamarWMDE changed the task status from Open to Stalled.Jun 22 2023, 12:04 PM

Waiting for T339103 to be completed

Michael moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Jun 29 2023, 1:19 PM
Michael changed the task status from Stalled to Open.Jul 3 2023, 10:57 AM
Michael claimed this task.
Michael moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.

T339103 is fully implemented, just awaiting product verification. That is good enough to get started with this next step.

Restricted Application added a project: User-Michael. · View Herald TranscriptJul 3 2023, 10:57 AM
gerritbot added a comment.Jul 3 2023, 12:59 PM

Change 935057 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Add feature flag to always show MUL in Termbox (PHP)

https://gerrit.wikimedia.org/r/935057

gerritbot added a project: Patch-For-Review.Jul 3 2023, 12:59 PM

Change 935058 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Always show `mul` in the desktop Termbox, depending on the feature flag

https://gerrit.wikimedia.org/r/935058

Michael updated the task description. (Show Details)Jul 4 2023, 4:38 AM
Michael moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Jul 4 2023, 5:14 AM
gerritbot added a comment.Jul 5 2023, 12:56 PM

Change 935057 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add feature flag to always show MUL in Termbox (PHP)

https://gerrit.wikimedia.org/r/935057

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 5 2023, 1:00 PM
gerritbot added a comment.Jul 5 2023, 3:55 PM

Change 935770 had a related patch set uploaded (by Michael Große; author: Michael Große):

[operations/mediawiki-config@master] Beta-Wikidata: Always show mul on desktop Termbox

https://gerrit.wikimedia.org/r/935770

gerritbot added a comment.Jul 6 2023, 10:37 AM

Change 935058 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Always show `mul` in the desktop Termbox, depending on the feature flag

https://gerrit.wikimedia.org/r/935058

gerritbot added a comment.Jul 6 2023, 11:26 AM

Change 935770 merged by jenkins-bot:

[operations/mediawiki-config@master] Beta-Wikidata: Always show mul on desktop Termbox

https://gerrit.wikimedia.org/r/935770

Stashbot added a comment.Jul 6 2023, 11:26 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-06T11:26:33Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:935770|Beta-Wikidata: Always show mul on desktop Termbox (T339104)]]

Stashbot added a comment.Jul 6 2023, 11:27 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-06T11:27:53Z] <lucaswerkmeister-wmde@deploy1002> migr and lucaswerkmeister-wmde: Backport for [[gerrit:935770|Beta-Wikidata: Always show mul on desktop Termbox (T339104)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Maintenance_bot removed a project: Patch-For-Review.Jul 6 2023, 11:30 AM
Stashbot added a comment.Jul 6 2023, 11:34 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-06T11:34:11Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:935770|Beta-Wikidata: Always show mul on desktop Termbox (T339104)]] (duration: 07m 37s)

Lucas_Werkmeister_WMDE added a comment.Jul 7 2023, 8:57 AM

Seems to be working on https://wikidata.beta.wmflabs.org/wiki/Q354008.

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 7 2023, 2:29 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Our work done on the Wikidata Dev Team (Sprint-∞) board.

I think we can close this and leave the product verification to the parent task.

karapayneWMDE moved this task from Our work done to 2023 completed tasks on the Wikidata Dev Team (Sprint-∞) board.Jul 11 2023, 10:15 AM
Manuel mentioned this in T343409: MUL - Configure Test Wikidata to full-rollout mode.Aug 3 2023, 7:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL